RFR: 8304893: Link Time Optimization with gcc can be faster

2023-03-24 Thread Julian Waters
A previous argument against link time optimization support that we have for gcc is that it was extremely slow. After some checks it turns out we are passing rather inefficient flags to gcc in optimized builds. Changing these flags to run the linker optimizations in parallel and passing additiona

Re: RFR: 8303485: Replacing os.name for operating system customization [v6]

2023-03-24 Thread Michael Osipov
On Fri, 24 Mar 2023 17:01:37 GMT, Roger Riggs wrote: >> That is acceptable, totally. > > Not the rabbit-hole I expected to go down today or for an informal comment on > an internal API. > I have no skin in that game. > https://www.redhat.com/en/topics/linux/what-is-linux Joke, they should know

Re: RFR: 8303485: Replacing os.name for operating system customization [v6]

2023-03-24 Thread Roger Riggs
On Fri, 24 Mar 2023 16:53:05 GMT, Michael Osipov wrote: >> If you are referring to "Red Hat Enterprise Linux", it'd be correct (AFAIK) >> to say that Red Hat identifies "Red Hat Enterprise Linux" as an operating >> system, but I wouldn't go so far as to say that Red Hat calls "Linux" an >> ope

Re: RFR: 8303485: Replacing os.name for operating system customization [v7]

2023-03-24 Thread Roger Riggs
> Improvements to support OS specific customization for JDK internal use: > - To select values and code; allowing elimination of unused code and values > - Optionally evaluated by build processes, compilation, or archiving (i.e. > CDS) > - Simple API to replace adhoc comparisons with `os.name`

Re: RFR: JDK-8304689: Add hidden option to disable external spec page [v2]

2023-03-24 Thread Hannes Wallnöfer
On Thu, 23 Mar 2023 13:37:19 GMT, Jonathan Gibbons wrote: >> Please review a change to introduce a hidden option to temporarily disable >> the "External Specifications" page while we add `@spec` tags, and until we >> have a critical mass of such tags. > > Jonathan Gibbons has updated the pull r

Re: RFR: 8303485: Replacing os.name for operating system customization [v6]

2023-03-24 Thread David M . Lloyd
On Fri, 24 Mar 2023 16:41:02 GMT, Michael Osipov wrote: >> A bit of a quibble, several internet sources identify Linux as an operating >> system (including Redhat). > > Well, no. It is just a kernel. Without a userland not an OS. That is why they > call it GNU/Linux. Kernel + userland. If you

Re: RFR: 8303485: Replacing os.name for operating system customization [v6]

2023-03-24 Thread Michael Osipov
On Fri, 24 Mar 2023 16:51:46 GMT, David M. Lloyd wrote: >> Well, no. It is just a kernel. Without a userland not an OS. That is why >> they call it GNU/Linux. Kernel + userland. > > If you are referring to "Red Hat Enterprise Linux", it'd be correct (AFAIK) > to say that Red Hat identifies "Red

Re: RFR: 8303485: Replacing os.name for operating system customization [v6]

2023-03-24 Thread Michael Osipov
On Fri, 24 Mar 2023 16:08:30 GMT, Roger Riggs wrote: >> src/java.base/share/classes/jdk/internal/util/OperatingSystem.java line 66: >> >>> 64: >>> 65: /** >>> 66: * The Linux Operating system. >> >> For the sake if completeness, Linux isn't an operating system, so this >> statement i

Re: RFR: 8303485: Replacing os.name for operating system customization [v6]

2023-03-24 Thread Roger Riggs
On Fri, 24 Mar 2023 16:04:38 GMT, Roger Riggs wrote: >> src/java.base/share/classes/jdk/internal/util/OperatingSystem.java line 81: >> >>> 79: */ >>> 80: AIX, >>> 81: ; >> >> So no Unknown value? > > Correct, as explained above. If additional OS values are needed, they can be adde

Re: RFR: 8303485: Replacing os.name for operating system customization [v6]

2023-03-24 Thread Naoto Sato
On Fri, 24 Mar 2023 00:27:42 GMT, Roger Riggs wrote: >> Improvements to support OS specific customization for JDK internal use: >> - To select values and code; allowing elimination of unused code and values >> - Optionally evaluated by build processes, compilation, or archiving (i.e. >> CDS) >

Re: RFR: 8303485: Replacing os.name for operating system customization [v6]

2023-03-24 Thread Roger Riggs
On Fri, 24 Mar 2023 16:03:26 GMT, Michael Osipov wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Rename OperatingSystem enum values to uppercase > > src/java.base/share/classes/jdk/internal/util/OperatingSystem.java

Re: RFR: 8303485: Replacing os.name for operating system customization [v6]

2023-03-24 Thread Roger Riggs
On Fri, 24 Mar 2023 16:02:59 GMT, Michael Osipov wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Rename OperatingSystem enum values to uppercase > > src/java.base/share/classes/jdk/internal/util/OperatingSystem.java

Re: RFR: 8303485: Replacing os.name for operating system customization [v6]

2023-03-24 Thread Alan Bateman
On Fri, 24 Mar 2023 00:27:42 GMT, Roger Riggs wrote: >> Improvements to support OS specific customization for JDK internal use: >> - To select values and code; allowing elimination of unused code and values >> - Optionally evaluated by build processes, compilation, or archiving (i.e. >> CDS) >

Re: RFR: 8303485: Replacing os.name for operating system customization [v6]

2023-03-24 Thread Michael Osipov
On Fri, 24 Mar 2023 00:27:42 GMT, Roger Riggs wrote: >> Improvements to support OS specific customization for JDK internal use: >> - To select values and code; allowing elimination of unused code and values >> - Optionally evaluated by build processes, compilation, or archiving (i.e. >> CDS) >

Integrated: 8304353: Add lib-test tier1 testing in GHA

2023-03-24 Thread Zdenek Zambersky
On Thu, 16 Mar 2023 15:44:48 GMT, Zdenek Zambersky wrote: > Tier1 testing in GitHub should include lib-test. This pull request has now been integrated. Changeset: 57276101 Author:Zdenek Zambersky Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk/commit/57276101df79f07b14

Re: RFR: 8304353: Add lib-test tier1 testing in GHA [v2]

2023-03-24 Thread Zdenek Zambersky
On Fri, 24 Mar 2023 09:17:52 GMT, Aleksey Shipilev wrote: >> Zdenek Zambersky has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Perform lib-test testing with debug builds > > Looks good. Maybe @magicus wants to bless it too. @shipilev @ma

RFR: 8304871: Use default visibility for static library builds

2023-03-24 Thread Severin Gehwolf
Please review this change for symbol visibility of static library artefacts. This fixes an issue when OpenJDK is being used as a base for generating native images preventing the symbols from being exported and looked up from the executable. Note that symbol visibity is now controlled by a linker

Re: RFR: JDK-8304867: Explicitly disable dtrace for ppc builds [v2]

2023-03-24 Thread Matthias Baesken
> Currently the support for the JVM feature 'dtrace' is not implemented in the > HS codebase on ppc, so we should disable it in the jvm-features make > detection as well. Otherwise we could run into building with dtrace feature > support if e.g. the 'dtrace' tool and related header(s) are availa

Re: RFR: JDK-8304867: Explicitly disable dtrace for ppc builds [v2]

2023-03-24 Thread Aleksey Shipilev
On Fri, 24 Mar 2023 12:20:32 GMT, Matthias Baesken wrote: >> Currently the support for the JVM feature 'dtrace' is not implemented in the >> HS codebase on ppc, so we should disable it in the jvm-features make >> detection as well. Otherwise we could run into building with dtrace feature >> su

Re: RFR: 8304353: Add lib-test tier1 testing in GHA [v2]

2023-03-24 Thread Magnus Ihse Bursie
On Fri, 24 Mar 2023 02:14:56 GMT, Zdenek Zambersky wrote: >> Tier1 testing in GitHub should include lib-test. > > Zdenek Zambersky has updated the pull request incrementally with one > additional commit since the last revision: > > Perform lib-test testing with debug builds Marked as reviewe

Re: RFR: JDK-8304867: Explicitly disable dtrace for ppc builds [v2]

2023-03-24 Thread Erik Joelsson
On Fri, 24 Mar 2023 12:20:32 GMT, Matthias Baesken wrote: >> Currently the support for the JVM feature 'dtrace' is not implemented in the >> HS codebase on ppc, so we should disable it in the jvm-features make >> detection as well. Otherwise we could run into building with dtrace feature >> su

Re: RFR: JDK-8304867: Explicitly disable dtrace for ppc builds

2023-03-24 Thread Matthias Baesken
On Fri, 24 Mar 2023 11:40:01 GMT, Matthias Baesken wrote: > Currently the support for the JVM feature 'dtrace' is not implemented in the > HS codebase on ppc, so we should disable it in the jvm-features make > detection as well. Otherwise we could run into building with dtrace feature > suppor

Re: RFR: JDK-8304867: Explicitly disable dtrace for ppc builds

2023-03-24 Thread Aleksey Shipilev
On Fri, 24 Mar 2023 11:40:01 GMT, Matthias Baesken wrote: > Currently the support for the JVM feature 'dtrace' is not implemented in the > HS codebase on ppc, so we should disable it in the jvm-features make > detection as well. Otherwise we could run into building with dtrace feature > suppor

RFR: JDK-8304867: Explicitly disable dtrace for ppc builds

2023-03-24 Thread Matthias Baesken
Currently the support for the JVM feature 'dtrace' is not implemented in the HS codebase on ppc, so we should disable it in the jvm-features make detection as well. Otherwise we could run into building with dtrace feature support if e.g. the 'dtrace' tool and related header(s) are available on t

Re: RFR: 8304353: Add lib-test tier1 testing in GHA [v2]

2023-03-24 Thread Aleksey Shipilev
On Fri, 24 Mar 2023 02:14:56 GMT, Zdenek Zambersky wrote: >> Tier1 testing in GitHub should include lib-test. > > Zdenek Zambersky has updated the pull request incrementally with one > additional commit since the last revision: > > Perform lib-test testing with debug builds Looks good. Maybe

Re: RFR: 8304265: Implementation of Foreign Function and Memory API (Third Preview) [v8]

2023-03-24 Thread ExE Boss
On Wed, 22 Mar 2023 14:09:07 GMT, Per Minborg wrote: >> API changes for the FFM API (third preview) >> >> Specdiff: >> https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html >> >> Javadoc: >> https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.ht