Breaking this into two parts :
1. Implementing socket options for AIX
2. DontFragmentTest failure
- Implementing socket options for AIX :
Unlike the linux, windows and macOS, AIX uses the default implementation for
socket options such as ipDontFragmentSupported(), keepAliveOptionsSupported()
On Thu, 30 Mar 2023 04:11:58 GMT, Guoxiong Li wrote:
>> Hi all,
>>
>> This patch adds the RISC-V related content to `building.md`. But I didn't
>> generate `building.html` locally, because I know the `pandoc` version
>> may influencethe the output of `building.html` (Need help here).
>>
>> I
On Wed, 29 Mar 2023 10:28:37 GMT, Aleksey Shipilev wrote:
> RISC-V cross-compiles with sysroots fine:
> https://builds.shipilev.net/openjdk-jdk/configure-logs/configure-openjdk-jdk-linux-riscv64-server-release-gcc10-glibc2.31.log
>
> https://builds.shipilev.net/openjdk-jdk/build-logs/build-ope
On Wed, 29 Mar 2023 13:37:36 GMT, Erik Joelsson wrote:
>> Guoxiong Li has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Add riscv64 related content to 'Debian sysroots'
>> - qemu-debootstrap has been deprecated, use debootstrap instea
> Hi all,
>
> This patch adds the RISC-V related content to `building.md`. But I didn't
> generate `building.html` locally, because I know the `pandoc` version
> may influencethe the output of `building.html` (Need help here).
>
> I know there are many steps and subtle points about cross-compil
On Wed, 29 Mar 2023 08:55:08 GMT, Per Minborg wrote:
>> API changes for the FFM API (third preview)
>>
>> Specdiff:
>> https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html
>>
>> Javadoc:
>> https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.ht
On Wed, 29 Mar 2023 22:32:20 GMT, Paul Sandoz wrote:
>> I've updated the specs as per how I interpret the comments above. Let me
>> know your thoughts on this.
>
> This is much clearer. Are the names of the struct members guaranteed to be
> symbols that can be found up via the linker's default
On Wed, 29 Mar 2023 08:55:08 GMT, Per Minborg wrote:
>> API changes for the FFM API (third preview)
>>
>> Specdiff:
>> https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html
>>
>> Javadoc:
>> https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.ht
> Please review this redo of the following changes:
> 8302189: Mark assertion failures noreturn
> 8302799: Refactor Debugging variable usage for noreturn crash reporting
>
> The original change tripped over a bug the handling of noreturn and
> __builtin_unreachable by Xcode12 (so probably generic
On Mon, 27 Mar 2023 23:57:45 GMT, Kim Barrett wrote:
> Please review this redo of the following changes:
> 8302189: Mark assertion failures noreturn
> 8302799: Refactor Debugging variable usage for noreturn crash reporting
>
> The original change tripped over a bug the handling of noreturn and
>
On Mon, 27 Mar 2023 09:40:22 GMT, Severin Gehwolf wrote:
>> Please review this change for symbol visibility of static library artefacts.
>> This fixes an issue when
>> OpenJDK is being used as a base for generating native images preventing the
>> symbols from being
>> exported and looked up fro
On Wed, 29 Mar 2023 18:09:39 GMT, Coleen Phillimore wrote:
>> Please review this redo of the following changes:
>> 8302189: Mark assertion failures noreturn
>> 8302799: Refactor Debugging variable usage for noreturn crash reporting
>>
>> The original change tripped over a bug the handling of nor
On Wed, 22 Mar 2023 14:07:14 GMT, Per Minborg wrote:
>> Back to @PaulSandoz question - "how does the caller know what the structure
>> contains?". The caller typically doesn't care too much about what the
>> returned struct is. But it might care about which "values" can be captured.
>> That s
On Mon, 27 Mar 2023 23:57:45 GMT, Kim Barrett wrote:
> Please review this redo of the following changes:
> 8302189: Mark assertion failures noreturn
> 8302799: Refactor Debugging variable usage for noreturn crash reporting
>
> The original change tripped over a bug the handling of noreturn and
>
On Wed, 29 Mar 2023 08:55:08 GMT, Per Minborg wrote:
>> API changes for the FFM API (third preview)
>>
>> Specdiff:
>> https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html
>>
>> Javadoc:
>> https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.ht
On Wed, 29 Mar 2023 13:04:39 GMT, Amit Kumar wrote:
> As stated in JBS-issue, `dtrace` functionality is not available on s390x. So
> disabling it explicitly in the build.
LGTM
-
Marked as reviewed by mbaesken (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13228#pullreque
On Wed, 29 Mar 2023 13:04:39 GMT, Amit Kumar wrote:
> As stated in JBS-issue, `dtrace` functionality is not available on s390x. So
> disabling it explicitly in the build.
Changes are trivial, so /integrate (ing). I request **R**eviewer/committer to
sponsor my changes 😊
-
PR Comme
On Wed, 29 Mar 2023 13:04:39 GMT, Amit Kumar wrote:
> As stated in JBS-issue, `dtrace` functionality is not available on s390x. So
> disabling it explicitly in the build.
Looks good and trivial.
For formal reasons, we may want to wait for the GHA to complete before we
integrate and sponsor.
On Wed, 29 Mar 2023 13:04:39 GMT, Amit Kumar wrote:
> As stated in JBS-issue, `dtrace` functionality is not available on s390x. So
> disabling it explicitly in the build.
Marked as reviewed by erikj (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13228#pullrequestreview-
On Wed, 29 Mar 2023 10:14:49 GMT, Guoxiong Li wrote:
> Hi all,
>
> This patch adds the RISC-V related content to `building.md`. But I didn't
> generate `building.html` locally, because I know the `pandoc` version
> may influencethe the output of `building.html` (Need help here).
>
> I know th
On Wed, 29 Mar 2023 13:04:39 GMT, Amit Kumar wrote:
> As stated in JBS-issue, `dtrace` functionality is not available on s390x. So
> disabling it explicitly in the build.
Still you can see output is different for these strings.
But thanks for pointing out the line number. Mistakenly I was loo
On Mon, 27 Mar 2023 05:47:28 GMT, David Holmes wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Comment not required
>
> make/hotspot/lib/JvmFeatures.gmk line 173:
>
>> 171: ifeq ($(call isCompiler, gcc), true)
On Wed, 29 Mar 2023 13:20:00 GMT, Amit Kumar wrote:
> @MBaesken , @erikj79 , @RealLucy Please review. 🙂
>
> Probably I'm missing something, But I'm a bit confused that string `xs390x`
> is not recognised as a valid CPU here.
Hello Amit, I don't have prior knowledge of these build files, but f
On Wed, 29 Mar 2023 13:04:39 GMT, Amit Kumar wrote:
> As stated in JBS-issue, `dtrace` functionality is not available on s390x. So
> disabling it explicitly in the build.
@MBaesken , @erikj79 , @RealLucy Please review. 🙂
Probably I'm missing something, But I'm a bit confused that string `xs39
As stated in JBS-issue, `dtrace` functionality is not available on s390x. So
disabling it explicitly in the build.
-
Commit messages:
- disable dtrace feature
Changes: https://git.openjdk.org/jdk/pull/13228/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13228&range=00
Is
On Wed, 29 Mar 2023 10:14:49 GMT, Guoxiong Li wrote:
> Hi all,
>
> This patch adds the RISC-V related content to `building.md`. But I didn't
> generate `building.html` locally, because I know the `pandoc` version
> may influencethe the output of `building.html` (Need help here).
>
> I know th
Hi all,
This patch adds the RISC-V related content to `building.md`. But I didn't
generate `building.html` locally, because I know the `pandoc` version
may influencethe the output of `building.html` (Need help here).
I know there are many steps and subtle points about cross-compiling the
exter
> API changes for the FFM API (third preview)
>
> Specdiff:
> https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html
>
> Javadoc:
> https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.html
Per Minborg has updated the pull request incrementally wit
> API changes for the FFM API (third preview)
>
> Specdiff:
> https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html
>
> Javadoc:
> https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.html
Per Minborg has updated the pull request incrementally wit
> API changes for the FFM API (third preview)
>
> Specdiff:
> https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html
>
> Javadoc:
> https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.html
Per Minborg has updated the pull request incrementally wit
On Fri, 24 Mar 2023 12:19:17 GMT, Matthias Baesken wrote:
>> Currently the support for the JVM feature 'dtrace' is not implemented in the
>> HS codebase on ppc, so we should disable it in the jvm-features make
>> detection as well. Otherwise we could run into building with dtrace feature
>> su
On Fri, 24 Mar 2023 12:20:32 GMT, Matthias Baesken wrote:
>> Currently the support for the JVM feature 'dtrace' is not implemented in the
>> HS codebase on ppc, so we should disable it in the jvm-features make
>> detection as well. Otherwise we could run into building with dtrace feature
>> su
On Fri, 24 Mar 2023 11:40:01 GMT, Matthias Baesken wrote:
> Currently the support for the JVM feature 'dtrace' is not implemented in the
> HS codebase on ppc, so we should disable it in the jvm-features make
> detection as well. Otherwise we could run into building with dtrace feature
> suppor
33 matches
Mail list logo
