Re: RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v6]

2023-04-04 Thread Alan Bateman
On Wed, 5 Apr 2023 04:35:27 GMT, David Holmes wrote: >> src/java.base/share/classes/java/lang/Thread.java line 1846: >> >>> 1844: /** >>> 1845: * Returns true if this thread is alive. >>> 1846: * This method is non-final so it can be overridden. >> >> Suggestion: >> >> * Thi

Re: RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v6]

2023-04-04 Thread David Holmes
On Wed, 5 Apr 2023 04:04:11 GMT, ExE Boss wrote: >> David Holmes has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Switch from using synchronized to using a volatile eetop field >> - Added Shipilev's test (with a small addition) > > src

Re: RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v6]

2023-04-04 Thread David Holmes
On Wed, 5 Apr 2023 02:30:15 GMT, David Holmes wrote: >> We have the strange situation where calling `t.isAlive()` on a >> `java.lang.Thread` `t`, will call into the VM (via `alive()` then >> `isAlive0()`) where the VM then examines the `eetop` field of `t` to extract >> its `JavaThread` pointe

Re: RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v6]

2023-04-04 Thread ExE Boss
On Wed, 5 Apr 2023 02:30:15 GMT, David Holmes wrote: >> We have the strange situation where calling `t.isAlive()` on a >> `java.lang.Thread` `t`, will call into the VM (via `alive()` then >> `isAlive0()`) where the VM then examines the `eetop` field of `t` to extract >> its `JavaThread` pointe

Re: RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v6]

2023-04-04 Thread ExE Boss
On Wed, 5 Apr 2023 02:30:15 GMT, David Holmes wrote: >> We have the strange situation where calling `t.isAlive()` on a >> `java.lang.Thread` `t`, will call into the VM (via `alive()` then >> `isAlive0()`) where the VM then examines the `eetop` field of `t` to extract >> its `JavaThread` pointe

Re: RFR: JDK-8305118: Add RISC-V related content to building.md [v2]

2023-04-04 Thread Guoxiong Li
On Thu, 30 Mar 2023 04:21:01 GMT, Chen Liang wrote: >> Guoxiong Li has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - Add riscv64 related content to 'Debian sysroots' >> - qemu-debootstrap has been deprecated, use debootstrap instead.

Re: RFR: JDK-8305118: Add RISC-V related content to building.md [v3]

2023-04-04 Thread Guoxiong Li
> Hi all, > > This patch adds the RISC-V related content to `building.md`. But I didn't > generate `building.html` locally, because I know the `pandoc` version > may influencethe the output of `building.html` (Need help here). > > I know there are many steps and subtle points about cross-compil

Re: RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v6]

2023-04-04 Thread David Holmes
> We have the strange situation where calling `t.isAlive()` on a > `java.lang.Thread` `t`, will call into the VM (via `alive()` then > `isAlive0()`) where the VM then examines the `eetop` field of `t` to extract > its `JavaThread` pointer and compare it to null. We can simply read `eetop` > dir

Re: RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v5]

2023-04-04 Thread David Holmes
> We have the strange situation where calling `t.isAlive()` on a > `java.lang.Thread` `t`, will call into the VM (via `alive()` then > `isAlive0()`) where the VM then examines the `eetop` field of `t` to extract > its `JavaThread` pointer and compare it to null. We can simply read `eetop` > dir

Re: RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v4]

2023-04-04 Thread David Holmes
On Tue, 4 Apr 2023 22:50:00 GMT, David Holmes wrote: >> We have the strange situation where calling `t.isAlive()` on a >> `java.lang.Thread` `t`, will call into the VM (via `alive()` then >> `isAlive0()`) where the VM then examines the `eetop` field of `t` to extract >> its `JavaThread` pointe

Re: RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v4]

2023-04-04 Thread David Holmes
> We have the strange situation where calling `t.isAlive()` on a > `java.lang.Thread` `t`, will call into the VM (via `alive()` then > `isAlive0()`) where the VM then examines the `eetop` field of `t` to extract > its `JavaThread` pointer and compare it to null. We can simply read `eetop` > dir

Re: RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v3]

2023-04-04 Thread David Holmes
On Tue, 4 Apr 2023 09:22:29 GMT, Aleksey Shipilev wrote: >> David Holmes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Ensure HB relationship exists; additional explanatory comments > > src/java.base/share/classes/java/lang/Thread.java

Re: RFR: 8305089: Implement missing socket options on AIX [v2]

2023-04-04 Thread Vyom Tewari
On Thu, 30 Mar 2023 16:05:08 GMT, Varada M wrote: >> Breaking this into two parts : >> >> 1. Implementing socket options for AIX >> 2. DontFragmentTest failure >> >> - Implementing socket options for AIX : >> >> Unlike the linux, windows and macOS, AIX uses the default implementation for >

Re: RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v3]

2023-04-04 Thread Aleksey Shipilev
On Mon, 3 Apr 2023 22:41:44 GMT, David Holmes wrote: >> We have the strange situation where calling `t.isAlive()` on a >> `java.lang.Thread` `t`, will call into the VM (via `alive()` then >> `isAlive0()`) where the VM then examines the `eetop` field of `t` to extract >> its `JavaThread` pointe