On Tue, 11 Apr 2023 18:07:41 GMT, Martin Doerr wrote:
> Another remark: Old JDK on s390 used "os.arch = zArch_64", current one
> "os.arch = s390x". @offamitkumar: You probably want to take a look.
Martin, only concern was that I didn't have a good experience with `s390x`
string in
[past](http
On Tue, 11 Apr 2023 21:09:43 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X
> Define an internal jdk.internal.util.Architecture enumeration and static
> methods to replace uses of the system property `os.arch`.
> The enumeration values are defined to match those used in the build.
> The initial values are: `X64, X86, AARCH64, RISCV64, S390, PPC64`
> Note that `amd64` and
On Tue, 11 Apr 2023 18:35:56 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X
On Tue, 11 Apr 2023 18:35:56 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X
On Tue, 11 Apr 2023 19:33:28 GMT, Roger Riggs wrote:
>>> > Would be great if you could support "os.arch = ppc64" for AIX and legacy
>>> > linux, too.
>>>
>>> Changing os.arch is out of scope for this PR. The best way for that would
>>> someone supporting ppc to develop and propose a PR.
>>
>>
On Tue, 11 Apr 2023 18:37:11 GMT, Glavo wrote:
>>> Would be great if you could support "os.arch = ppc64" for AIX and legacy
>>> linux, too.
>>
>> Changing os.arch is out of scope for this PR.
>> The best way for that would someone supporting ppc to develop and propose a
>> PR.
>
>> > Would be
> Please review a cleanup in DocCommentParser to merge blockContent and
> inlineContent into a single method to parse "rich content" in a doc comment.
Jonathan Gibbons has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 59 commits:
- Me
On Tue, 11 Apr 2023 16:58:13 GMT, Roger Riggs wrote:
> > Would be great if you could support "os.arch = ppc64" for AIX and legacy
> > linux, too.
>
> Changing os.arch is out of scope for this PR. The best way for that would
> someone supporting ppc to develop and propose a PR.
It seems that y
> Define an internal jdk.internal.util.Architecture enumeration and static
> methods to replace uses of the system property `os.arch`.
> The enumeration values are defined to match those used in the build.
> The initial values are: `X64, X86, AARCH64, RISCV64, S390, PPC64`
> Note that `amd64` and
> Please review a cleanup in DocCommentParser to merge blockContent and
> inlineContent into a single method to parse "rich content" in a doc comment.
Jonathan Gibbons has updated the pull request incrementally with 42 additional
commits since the last revision:
- Merge remote-tracking branch
Please review a cleanup in DocCommentParser to merge blockContent and
inlineContent into a single method to parse "rich content" in a doc comment.
-
Depends on: https://git.openjdk.org/jdk/pull/13362
Commit messages:
- JDK-8305713: DocCommentParser: merge blockContent and inlineCon
On Tue, 11 Apr 2023 18:02:14 GMT, Martin Doerr wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Modified test to check Architecture is64bits() and isLittleEndian()
>> against Unsafe respective values.
>> Relocate
On Tue, 11 Apr 2023 17:58:54 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X
On Thu, 6 Apr 2023 10:54:18 GMT, Per Minborg wrote:
>> API changes for the FFM API (third preview)
>>
>> Specdiff:
>> https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html
>>
>> Javadoc:
>> https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.htm
On Tue, 11 Apr 2023 17:58:54 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X
> Define an internal jdk.internal.util.Architecture enumeration and static
> methods to replace uses of the system property `os.arch`.
> The enumeration values are defined to match those used in the build.
> The initial values are: `X64, X86, AARCH64, RISCV64, S390, PPC64`
> Note that `amd64` and
On Thu, 6 Apr 2023 10:54:18 GMT, Per Minborg wrote:
>> API changes for the FFM API (third preview)
>>
>> Specdiff:
>> https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html
>>
>> Javadoc:
>> https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.htm
On Tue, 11 Apr 2023 10:39:39 GMT, Martin Doerr wrote:
>> This should (probably) be correct:
>> Suggestion:
>>
>> case PPC64 -> !OperatingSystem.isAix() &&
>> Architecture.isLittleEndian();
>
> Looks correct, but makes the test pointless for any linux on PPC64.
Will change to compar
On Tue, 11 Apr 2023 11:41:24 GMT, Glavo wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unused static and import of Stabile
>
> src/java.base/share/classes/jdk/internal/util/PlatformProps.java.template
> lin
On Sat, 8 Apr 2023 18:00:53 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X8
On Tue, 11 Apr 2023 10:26:02 GMT, ExE Boss wrote:
>> test/jdk/jdk/internal/util/ArchTest.java line 128:
>>
>>> 126: case RISCV64 -> true;
>>> 127: case S390 -> false;
>>> 128: case PPC64 -> true;
>>
>> This is not always true. The PPC64 architecture supports
On Tue, 11 Apr 2023 10:15:27 GMT, Martin Doerr wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unused static and import of Stabile
>
> test/jdk/jdk/internal/util/ArchTest.java line 128:
>
>> 126:
On Sat, 8 Apr 2023 18:00:53 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X8
24 matches
Mail list logo
