On Thu, 11 May 2023 15:40:50 GMT, Justin Lu wrote:
> Please review changes to `EquivMapsGenerator.java` (which is used to generate
> the Locale equivalencies for the JDK).
>
> The file previously used large concatenated Strings, which are now replaced
> with text blocks, in addition to some cl
On Mon, 15 May 2023 18:46:00 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> This is a redo of JDK-8307855, where issues were found after integration.
>
> The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because
> of security concerns. The issue was addressed in
> [JDK-8296812](h
Hi,
This is a redo of JDK-8307855, where issues were found after integration.
The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because of
security concerns. The issue was addressed in
[JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for building
failure, and
[JDK
> Please review changes to `EquivMapsGenerator.java` (which is used to generate
> the Locale equivalencies for the JDK).
>
> The file previously used large concatenated Strings, which are now replaced
> with text blocks, in addition to some cleanup. No functionality is changed,
> the Locale equ
On Mon, 15 May 2023 17:18:01 GMT, Jim Laskey wrote:
>> src/java.base/share/classes/jdk/internal/misc/MainMethodFinder.java line 146:
>>
>>> 144:
>>> 145: if (Modifier.isStatic(mods) &&
>>> mainMethod.getDeclaringClass() != mainClass) {
>>> 146: System.err.println("W
> Add flexible main methods and anonymous main classes to the Java language.
Jim Laskey has updated the pull request incrementally with one additional
commit since the last revision:
Requested Changes #2
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13689/files
- new: ht
On Mon, 15 May 2023 07:48:26 GMT, Alan Bateman wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update VirtualParser.java
>
> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 896:
>
>> 894:
On Mon, 15 May 2023 07:13:49 GMT, Alan Bateman wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update VirtualParser.java
>
> src/java.base/share/classes/jdk/internal/misc/MainMethodFinder.java line 134:
>
>> 132:
>
On Mon, 15 May 2023 06:38:48 GMT, Alan Bateman wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update VirtualParser.java
>
> src/java.base/share/classes/jdk/internal/misc/MainMethodFinder.java line 146:
>
>> 144:
>
On Mon, 15 May 2023 06:45:45 GMT, Alan Bateman wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update VirtualParser.java
>
> test/jdk/tools/launcher/InstanceMainTest.java line 31:
>
>> 29: * @run main InstanceMainT
On Mon, 15 May 2023 06:31:40 GMT, Alan Bateman wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update VirtualParser.java
>
> src/java.base/share/classes/jdk/internal/misc/MainMethodFinder.java line 35:
>
>> 33: publ
On Mon, 15 May 2023 10:00:42 GMT, Aleksey Shipilev wrote:
> Currently failing at host configuration step with:
>
>
> The following packages have unmet dependencies:
> libc6:i386 : Depends: libgcc-s1:i386 but it is not going to be installed
> libtiffxx5:i386 : Depends: libstdc++6:i386 (>= 5) b
On Mon, 15 May 2023 10:00:42 GMT, Aleksey Shipilev wrote:
> Currently failing at host configuration step with:
>
>
> The following packages have unmet dependencies:
> libc6:i386 : Depends: libgcc-s1:i386 but it is not going to be installed
> libtiffxx5:i386 : Depends: libstdc++6:i386 (>= 5) b
On Mon, 15 May 2023 13:22:12 GMT, Aleksey Shipilev wrote:
> > Thank you for fixing this
>
> Thanks for looking at it. Trivial, right?
Trivial.
-
PR Comment: https://git.openjdk.org/jdk/pull/13981#issuecomment-1547890912
On Mon, 15 May 2023 10:20:51 GMT, Thomas Stuefe wrote:
> Thank you for fixing this
Thanks for looking at it.
Trivial, right?
GHAs do not complain anymore.
-
PR Comment: https://git.openjdk.org/jdk/pull/13981#issuecomment-1547852643
On Mon, 15 May 2023 08:38:54 GMT, Adam Sotona wrote:
> Package `jdk.internal.classfile.java.lang.constant` containing `ModuleDesc`
> and `PackageDesc` become obsolete after
> [JDK-8306729](https://bugs.openjdk.org/browse/JDK-8306729).
> All references to `jdk.internal.classfile.java.lang.const
On Fri, 12 May 2023 21:51:59 GMT, Kim Barrett wrote:
>> src/hotspot/cpu/ppc/c1_LIRGenerator_ppc.cpp line 426:
>>
>>> 424: // Missing test if instr is commutative and if we should swap.
>>> 425: if (right.value()->type()->as_LongConstant() &&
>>> 426: (x->op() == Bytecodes::_lsub &&
>>
On Fri, 12 May 2023 16:16:01 GMT, JoKern65 wrote:
>> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
>> on AIX , we run into various "warnings as errors".
>> Many of those are in the aix or ppc specific codebase and could be addressed
>> by small adjustments.
>> A l
On Mon, 15 May 2023 10:00:42 GMT, Aleksey Shipilev wrote:
> Currently failing at host configuration step with:
>
>
> The following packages have unmet dependencies:
> libc6:i386 : Depends: libgcc-s1:i386 but it is not going to be installed
> libtiffxx5:i386 : Depends: libstdc++6:i386 (>= 5) b
Currently failing at host configuration step with:
The following packages have unmet dependencies:
libc6:i386 : Depends: libgcc-s1:i386 but it is not going to be installed
libtiffxx5:i386 : Depends: libstdc++6:i386 (>= 5) but it is not going to be
installed
```
The fix is to add the dependen
On Mon, 15 May 2023 09:32:26 GMT, Kim Barrett wrote:
>> I see, so `size` is kind of macro-like, and is just textually splicing its
>> argument expression into another expression.
>> And without the added parens the resulting full expression for the assert
>> isn't checking what's intended, due
On Fri, 12 May 2023 22:01:46 GMT, Kim Barrett wrote:
>> JoKern65 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> cosmetic changes
>
> src/java.desktop/aix/native/libawt/porting_aix.c line 49:
>
>> 47: for (;;) {
>> 48: if (addr >=
On Fri, 12 May 2023 21:59:11 GMT, Kim Barrett wrote:
>> JoKern65 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> cosmetic changes
>
> src/hotspot/os/aix/os_aix.cpp line 464:
>
>> 462: guarantee0(shmid != -1); // Should always work
On Mon, 15 May 2023 09:30:52 GMT, Kim Barrett wrote:
>> /data/d042520/xlc17/jdk/src/hotspot/cpu/ppc/c1_LIRGenerator_ppc.cpp:426:97:
>> error: shifting a negative signed value is undefined
>> [-Werror,-Wshift-negative-value]
>> I reverted my change in c1_LIRGenerator_ppc.cpp and added
>> shift-
On Mon, 15 May 2023 08:29:31 GMT, JoKern65 wrote:
>> src/hotspot/cpu/ppc/ppc.ad line 11444:
>>
>>> 11442: effect(KILL cr0);
>>> 11443: ins_cost(DEFAULT_COST * 5);
>>> 11444: size((VM_Version::has_brw() ? 16 : 20));
>>
>> What is it complaining about here?
>
> /data/d042520/xlc17/jdk/src/h
Package `jdk.internal.classfile.java.lang.constant` containing `ModuleDesc` and
`PackageDesc` become obsolete after
[JDK-8306729](https://bugs.openjdk.org/browse/JDK-8306729).
All references to `jdk.internal.classfile.java.lang.constant.ModuleDesc` and
`jdk.internal.classfile.java.lang.constant
On Fri, 12 May 2023 21:56:50 GMT, Kim Barrett wrote:
>> JoKern65 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> cosmetic changes
>
> src/hotspot/cpu/ppc/ppc.ad line 11444:
>
>> 11442: effect(KILL cr0);
>> 11443: ins_cost(DEFAULT_CO
On Thu, 11 May 2023 11:25:51 GMT, Jim Laskey wrote:
>> Add flexible main methods and anonymous main classes to the Java language.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update VirtualParser.java
src/java.base/share/
28 matches
Mail list logo
