Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v5]

2023-06-05 Thread Kelvin Nilsen
On Sun, 4 Jun 2023 21:39:58 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v10]

2023-06-05 Thread Alexander Zuev
On Thu, 1 Jun 2023 12:40:55 GMT, Alexander Zvegintsev wrote: >> Modern Linux systems often come with >> [Wayland](https://wayland.freedesktop.org/) by default. >> This comes with some difficulties, and one of them is the inability to get >> screenshots from the system. >> This is because we no

Re: RFR: 8309501: Remove workaround in bin/idea.sh for non standard JVMCI file layout

2023-06-05 Thread Erik Joelsson
On Mon, 5 Jun 2023 19:12:52 GMT, Tom Rodriguez wrote: > This allows bin/idea.sh to properly see the JVMCI files again. Marked as reviewed by erikj (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14318#pullrequestreview-1463324474

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v5]

2023-06-05 Thread Kelvin Nilsen
On Sun, 4 Jun 2023 21:39:58 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: 8309501: Remove workaround in bin/idea.sh for non standard JVMCI file layout

2023-06-05 Thread Doug Simon
On Mon, 5 Jun 2023 19:12:52 GMT, Tom Rodriguez wrote: > This allows bin/idea.sh to properly see the JVMCI files again. Marked as reviewed by dnsimon (Committer). Finally ;-) - PR Review: https://git.openjdk.org/jdk/pull/14318#pullrequestreview-1463296723 PR Comment: https://git.op

RFR: 8309501: Remove workaround in bin/idea.sh for non standard JVMCI file layout

2023-06-05 Thread Tom Rodriguez
This allows bin/idea.sh to properly see the JVMCI files again. - Commit messages: - 8309501: Remove workaround in bin/idea.sh for non standard JVMCI file layout Changes: https://git.openjdk.org/jdk/pull/14318/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14318&range=00 I

Integrated: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview)

2023-06-05 Thread Jim Laskey
On Thu, 27 Apr 2023 12:38:11 GMT, Jim Laskey wrote: > Add flexible main methods and anonymous main classes to the Java language. This pull request has now been integrated. Changeset: 98b53c06 Author:Jim Laskey URL: https://git.openjdk.org/jdk/commit/98b53c06cfffe7b2e21968546b4aa1523

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v35]

2023-06-05 Thread Jim Laskey
> Add flexible main methods and anonymous main classes to the Java language. Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: -Xprint unnamed classes to use e.getSimpleName() - Changes: - all: https://git.openjdk.org/jdk

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v4]

2023-06-05 Thread Christine Flood
On Fri, 2 Jun 2023 02:49:25 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v34]

2023-06-05 Thread Jim Laskey
> Add flexible main methods and anonymous main classes to the Java language. Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 55 commits: - Merge branch 'master' into 8306112 - Final clean up - Merge branch 'master' into

Integrated: 8308969: make test-prebuilt doesn't return the correct exit code

2023-06-05 Thread Antonios Printezis
On Fri, 26 May 2023 16:07:36 GMT, Antonios Printezis wrote: > For 'make' test and 'make test-only' the existence of exit-with-error is > checked in the main target in Init.gmk. Is there a better way to fix this > than to check for the existence of exit-with-error in RunTestsPrebuilt.gmk? This

Re: RFR: JDK-8309225: Fix xlc17 clang 15 warnings in security and servicability

2023-06-05 Thread Goetz Lindenmaier
On Fri, 2 Jun 2023 10:19:53 GMT, JoKern65 wrote: > This pr is a split off from JDK-8308288: Fix xlc17 clang warnings in shared > code https://github.com/openjdk/jdk/pull/14146 > It handles the part in security and servicability. > > Compiling on AIX with xlc17 which contains the new clang 15 fr

Re: RFR: JDK-8309225: Fix xlc17 clang 15 warnings in security and servicability

2023-06-05 Thread Goetz Lindenmaier
On Fri, 2 Jun 2023 10:19:53 GMT, JoKern65 wrote: > This pr is a split off from JDK-8308288: Fix xlc17 clang warnings in shared > code https://github.com/openjdk/jdk/pull/14146 > It handles the part in security and servicability. > > Compiling on AIX with xlc17 which contains the new clang 15 fr

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v33]

2023-06-05 Thread Jim Laskey
> Add flexible main methods and anonymous main classes to the Java language. Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 53 commits: - Merge branch 'master' into 8306112 - Requested clean ups - Source code launcher t

Re: RFR: 8308969: make test-prebuilt doesn't return the correct exit code [v3]

2023-06-05 Thread Erik Joelsson
On Sat, 3 Jun 2023 12:47:39 GMT, Antonios Printezis wrote: >> For 'make' test and 'make test-only' the existence of exit-with-error is >> checked in the main target in Init.gmk. Is there a better way to fix this >> than to check for the existence of exit-with-error in RunTestsPrebuilt.gmk? > >

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v5]

2023-06-05 Thread Kelvin Nilsen
On Sun, 4 Jun 2023 21:39:58 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v5]

2023-06-05 Thread Kelvin Nilsen
On Mon, 5 Jun 2023 12:46:58 GMT, Kelvin Nilsen wrote: >> Kelvin Nilsen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove three asserts making comparisons between atomic volatile variables >> >> Though changes to the volatile va

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v5]

2023-06-05 Thread Kelvin Nilsen
On Sun, 4 Jun 2023 21:39:58 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v32]

2023-06-05 Thread Jim Laskey
On Sat, 3 Jun 2023 01:53:41 GMT, Joe Darcy wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update the specification for TypeElement#getQualifiedName and >> TypeElement#getSimpleName > > src/java.base/share/classes/j