Hi,
The version section gets stripped because the toolchain links with
--as-needed and libjawt.so is not using any libc symbols. The loader
behaviour that allows loading an unversioned symbol instead of a
specific version looks like a bug.
Unfortunately, I can not think of any other solution othe
On Thu, 29 Jun 2023 13:05:58 GMT, Leo Korinth wrote:
> My changes look like this in the diff output
> ```
> }
> -
> ```
Thanks for showing this and other output. To me this looked like the final
newline had been removed. I would have expected to see something that more
obviously showed more
On Thu, 29 Jun 2023 18:36:55 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> update for review: changed test, removed commented out code in module,
>> fixed switch statement, added --limit-m
On Mon, 26 Jun 2023 22:52:18 GMT, Anthony Scarpino
wrote:
>> Hi,
>>
>> I need a code review for moving the contents of the jdk.crypto.ec module
>> into java.base. This moves the SunEC JCE Provider (Elliptic Curve) into
>> java.base. EC has always been separate from the base module/pkg becau
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote:
> Remove trailing "blank" lines in source files.
>
> I like to use global-whitespace-cleanup-mode, but I can not use it if the
> files are "dirty" to begin with. This fix will make more files "clean". I
> also considered adding a check for t
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote:
> Remove trailing "blank" lines in source files.
>
> I like to use global-whitespace-cleanup-mode, but I can not use it if the
> files are "dirty" to begin with. This fix will make more files "clean". I
> also considered adding a check for t
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote:
> Remove trailing "blank" lines in source files.
>
> I like to use global-whitespace-cleanup-mode, but I can not use it if the
> files are "dirty" to begin with. This fix will make more files "clean". I
> also considered adding a check for t
On Thu, 29 Jun 2023 12:40:34 GMT, Coleen Phillimore wrote:
> You could fix your emacs functions.
It is a *very nice* feature of global-whitespace-cleanup-mode
-
PR Comment: https://git.openjdk.org/jdk/pull/14698#issuecomment-1613252347
On Thu, 29 Jun 2023 12:11:40 GMT, David Holmes wrote:
> Neither the PR diffs nor the webrev make it easy to see exactly what is being
> changed here. It appeared to me that the last empty line of each file was
> being deleted, leaving no newline at the end.
My changes look like this in the dif
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote:
> Remove trailing "blank" lines in source files.
>
> I like to use global-whitespace-cleanup-mode, but I can not use it if the
> files are "dirty" to begin with. This fix will make more files "clean". I
> also considered adding a check for t
On Thu, 29 Jun 2023 12:01:03 GMT, Coleen Phillimore wrote:
> Why do we care about this?
I care because of global-whitespace-cleanup-mode (in emacs). It helps me remove
trailing whitespaces and blanklines when saving but it will not fix a file that
was "dirty" when it was opened. Trailing blank
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote:
> Remove trailing "blank" lines in source files.
>
> I like to use global-whitespace-cleanup-mode, but I can not use it if the
> files are "dirty" to begin with. This fix will make more files "clean". I
> also considered adding a check for t
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote:
> Remove trailing "blank" lines in source files.
>
> I like to use global-whitespace-cleanup-mode, but I can not use it if the
> files are "dirty" to begin with. This fix will make more files "clean". I
> also considered adding a check for t
On Wed, 17 May 2023 12:28:47 GMT, Artem Semenov wrote:
> When using the clang compiler to build OpenJDk on Linux, we encounter various
> "warnings as errors".
> They can be fixed with small changes.
This pull request has now been integrated.
Changeset: 98a954ee
Author:Artem Semenov
URL:
On Thu, 29 Jun 2023 07:41:11 GMT, David Holmes wrote:
> This seems to run contrary to the requirement that files end in a newline,
> which git will complain about if the newline is missing.
>
> It also seems far too large and disruptive.
Do you still think it is too disruptive after Erik's expl
On Thu, 29 Jun 2023 07:41:11 GMT, David Holmes wrote:
> This seems to run contrary to the requirement that files end in a newline,
> which git will complain about if the newline is missing.
The patch is leaving exactly one newline at the end of the file.
-
PR Comment: https://git.
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote:
> Remove trailing "blank" lines in source files.
>
> I like to use global-whitespace-cleanup-mode, but I can not use it if the
> files are "dirty" to begin with. This fix will make more files "clean". I
> also considered adding a check for t
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote:
> Remove trailing "blank" lines in source files.
>
> I like to use global-whitespace-cleanup-mode, but I can not use it if the
> files are "dirty" to begin with. This fix will make more files "clean". I
> also considered adding a check for t
Hi Vladimir,
This is not the first time this has come up:
https://mail.openjdk.org/pipermail/build-dev/2020-February/026730.html
but no real resolution.
David
On 27/06/2023 6:31 pm, Vladimir Petko wrote:
Dear Maintainers,
There is a bug[1] submitted in Debian that a number of games crash
19 matches
Mail list logo
