Re: [jdk21] RFR: 8308585: AC_REQUIRE: `PLATFORM_EXTRACT_TARGET_AND_BUILD' was expanded before it was required

2023-06-30 Thread Mikael Vidstedt
On Fri, 30 Jun 2023 09:40:11 GMT, Erik Joelsson wrote: > This is a clean backport of what was initially a configure warning fix, but > turned out to also fix the original intention of JEP 449: deprecating the > Windows 32-bit port. Marked as reviewed by mikael (Reviewer). - PR Re

Re: RFR: 8311043: Remove trailing blank lines in source files

2023-06-30 Thread Daniel D . Daugherty
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote: > Remove trailing "blank" lines in source files. > > I like to use global-whitespace-cleanup-mode, but I can not use it if the > files are "dirty" to begin with. This fix will make more files "clean". I > also considered adding a check for t

Re: RFR: 8310948: Fix ignored-qualifiers warning in Hotspot

2023-06-30 Thread Daniel Jeliński
On Tue, 27 Jun 2023 12:22:43 GMT, Daniel Jeliński wrote: > Please review this attempt to fix ignored-qualifiers warning. > > Example warnings: > > src/hotspot/share/oops/method.hpp:413:19: warning: 'volatile' type qualifier > on return type has no effect [-Wignored-qualifiers] >CompiledMet

Re: RFR: JDK-8310550: Adjust references to rt.jar [v3]

2023-06-30 Thread Matthias Baesken
> There are a few references to rt.jar in comments and in the codebase itself. > Some of them might be removed or adjusted. Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: remove import - Changes: - all: https://g

Re: RFR: JDK-8310550: Adjust references to rt.jar [v2]

2023-06-30 Thread Matthias Baesken
On Wed, 28 Jun 2023 13:22:20 GMT, Matthias Baesken wrote: >>> Hi Alan, regarding usage of class VM I get 'package jdk.internal.misc is >>> declared in module java.base, which does not export it to module java.sql' >>> Is there any concern to export it as well to module java.sql ? And btw did >

Re: RFR: JDK-8310550: Adjust references to rt.jar [v2]

2023-06-30 Thread Matthias Baesken
> There are a few references to rt.jar in comments and in the codebase itself. > Some of them might be removed or adjusted. Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: Adjust comment in src/java.sql/share/classes/java/sql/Dri

[jdk21] RFR: 8308585: AC_REQUIRE: `PLATFORM_EXTRACT_TARGET_AND_BUILD' was expanded before it was required

2023-06-30 Thread Erik Joelsson
This is a clean backport of what was initially a configure warning fix, but turned out to also fix the original intention of JEP 449: deprecating the Windows 32-bit port. - Commit messages: - Backport 554b4d7243f2c7bb3cc3260358fc7c3c636d7536 Changes: https://git.openjdk.org/jdk21/