Re: Terminating failing tests on Windows

2023-07-06 Thread David Holmes
On 2/07/2023 11:53 am, - wrote: Hello, I am using the JDK's make build system to run JDK's tests on cygwin; however, the tests often lock the directories of failing runs, blocking Intellij Idea IDE and subsequent runs, and I cannot figure out what processes are doing so. What processes should

RFR: 8311545: Allow test symbol files to be kept in the test image

2023-07-06 Thread David Holmes
Please review this simple change to allow a test to request that its symbol files be copied across into the test image. Testing: - sanity test - tiers 1-3 - direct testing in the context of [JDK-8311541](https://bugs.openjdk.org/browse/JDK-8311541) Thanks - Commit messages: - 8

Withdrawn: 8301991: Convert l10n properties resource bundles to UTF-8 native

2023-07-06 Thread duke
On Thu, 23 Feb 2023 09:04:23 GMT, Justin Lu wrote: > This PR converts Unicode sequences to UTF-8 native in .properties file. > (Excluding the Unicode space and tab sequence). The conversion was done using > native2ascii. > > In addition, the build logic is adjusted to support reading in the >

Re: OpenJDK Build with JavaFX

2023-07-06 Thread Philip Race
You don't have to build either of them yourself. You can create a jlinked image from pre-built binaries. Eg get JDK 20 from https://www.oracle.com/java/technologies/downloads/ unpack it and add it to your PATH Get pre-built JavaFX 20 jmods from https://gluonhq.com/products/javafx/ eg javafx-jmod

OpenJDK Build with JavaFX

2023-07-06 Thread Michael Gasche
Hello Does anyone have resources/documentation on how to build an OpenJDK and to directly bundle it with JavaFX that could be shared? Thanks. Best, mike

Re: OpenJDK Build

2023-07-06 Thread yumin qi
try configure --disable-warnings-as-errors On Thu, Jul 6, 2023 at 8:32 AM Michael Gasche wrote: > Hi > > Would you mind giving me a little assistance here (see below) with the > OpenJDK build-error? > Couldn’t find out what it is. > > Thank you! > > Best, Michael > > —— > > > 0. Configure > —— >

OpenJDK Build

2023-07-06 Thread Michael Gasche
Hi Would you mind giving me a little assistance here (see below) with the OpenJDK build-error? Couldn’t find out what it is. Thank you! Best, Michael —— 0. Configure —— OK. 1. Logs - It’s empty: —— ./build/jdk/build/macosx-x86_64-server-release/make-support/failure-logs 2. System —— - m

Re: Terminating failing tests on Windows

2023-07-06 Thread -
Thank you Jaikiran! I am running tests amid development for java.lang.invoke packages, for a few of my active patches (like lazy static var handle and reimplementation of method handle proxies). My configuration line is: (with `bash make/devkit/createJMHBundle.sh` ran ahead) bash configure --enable

Re: Terminating failing tests on Windows

2023-07-06 Thread Jaikiran Pai
Hello Chen, I don't use Windows and am not familiar with cygwin either, but I know of others who use Windows for their builds and jtreg testing. Perhaps they can help if you add some more details like what exact command you use to launch the tests and which specific tests are you running. Also

Re: RFR: JDK-8310550: Adjust references to rt.jar [v4]

2023-07-06 Thread Matthias Baesken
On Wed, 5 Jul 2023 15:07:15 GMT, Matthias Baesken wrote: >> There are a few references to rt.jar in comments and in the codebase itself. >> Some of them might be removed or adjusted. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revi

Re: RFR: JDK-8310550: Adjust references to rt.jar [v5]

2023-07-06 Thread Matthias Baesken
> There are a few references to rt.jar in comments and in the codebase itself. > Some of them might be removed or adjusted. Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: Adjust comment - Changes: - all: https://

Re: RFR: JDK-8310550: Adjust references to rt.jar [v5]

2023-07-06 Thread David Holmes
On Thu, 22 Jun 2023 09:23:05 GMT, Matthias Baesken wrote: >> test/langtools/tools/javap/4798312/JavapShouldLoadClassesFromRTJarTest.java >> line 1: >> >>> 1: /* >> >> The name of this test includes RTJar. It needs to be changed too I think. >> Does this test actually still test something? > >