Withdrawn: 8308961: Automatically find configuration matching name of checked of branch

2023-07-27 Thread duke
On Mon, 29 May 2023 13:21:27 GMT, Erik Duveblad wrote: > Hi all, > > please review this smaller patch to the build system. This patch changes what > the build system will do when there are multiple configurations available and > none has been selected (neither via `CONF` nor via `SPEC`). Inste

Integrated: 8313082: Enable CreateCoredumpOnCrash for testing in makefiles

2023-07-27 Thread Leonid Mesnik
On Thu, 27 Jul 2023 03:41:24 GMT, Leonid Mesnik wrote: > The option > CreateCoredumpOnCrash > is enabled by default except the Windows client systems with release > binaries. > > So it makes sense to switch it on explicitly in makefiles on Windows while > testing. It still could be redefined

Re: RFR: 8313082: Enable CreateCoredumpOnCrash for testing in makefiles [v3]

2023-07-27 Thread Leonid Mesnik
> The option > CreateCoredumpOnCrash > is enabled by default except the Windows client systems with release > binaries. > > So it makes sense to switch it on explicitly in makefiles on Windows while > testing. It still could be redefined by adding '-XX-CreateCoredumpOnCrash' as > jtreg -vmopti

Integrated: JDK-8312466: /bin/nm usage in AIX makes needs -X64 flag

2023-07-27 Thread Andreas Steiner
On Wed, 26 Jul 2023 07:52:44 GMT, Andreas Steiner wrote: > On AIX the 'nm' needs -X64 option. This pull request has now been integrated. Changeset: 44576a7c Author:Andreas Steiner Committer: Christoph Langer URL: https://git.openjdk.org/jdk/commit/44576a7cca18108adafa7efe88de2a4655

Re: RFR: JDK-8312466: /bin/nm usage in AIX makes needs -X64 flag [v2]

2023-07-27 Thread Julian Waters
On Wed, 26 Jul 2023 10:29:25 GMT, Andreas Steiner wrote: >> On AIX the 'nm' needs -X64 option. > > Andreas Steiner has updated the pull request incrementally with one > additional commit since the last revision: > > correction of comment Marked as reviewed by jwaters (Committer). --

Re: RFR: JDK-8312466: /bin/nm usage in AIX makes needs -X64 flag [v2]

2023-07-27 Thread Matthias Baesken
On Wed, 26 Jul 2023 10:29:25 GMT, Andreas Steiner wrote: >> On AIX the 'nm' needs -X64 option. > > Andreas Steiner has updated the pull request incrementally with one > additional commit since the last revision: > > correction of comment There might be room for improvement for the general ha

Re: RFR: JDK-8312467: relax the builddir check in make/autoconf/basic.m4 [v2]

2023-07-27 Thread Matthias Baesken
On Wed, 26 Jul 2023 07:21:13 GMT, Matthias Baesken wrote: >> In case of issues in the configure step, we run into error messages like >> this : >> >> configure: Current directory is /openjdk/jdk_4/build_mymachine. >> configure: Since this is not the source root, configure will output the >> co

Re: RFR: 8313082: Enable CreateCoredumpOnCrash for testing in makefiles [v2]

2023-07-27 Thread David Holmes
On Thu, 27 Jul 2023 04:02:00 GMT, Leonid Mesnik wrote: >> The option >> CreateCoredumpOnCrash >> is enabled by default except the Windows client systems with release >> binaries. >> >> So it makes sense to switch it on explicitly in makefiles on Windows while >> testing. It still could be red

Re: RFR: 8312882: Update the CONTRIBUTING.md with pointers to lifecycle of a PR

2023-07-27 Thread David Holmes
On Thu, 29 Jun 2023 18:59:45 GMT, Jesse Glick wrote: > @jaikiran in > https://github.com/openjdk/jdk/pull/12871#issuecomment-1612310113 pointed me > to a resource I had not previously found. https://openjdk.org/contribute is > fine at a high level but still says things like > >> When your cha