Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v28]

2023-09-26 Thread Jorn Vernee
> This patch contains the implementation of the foreign linker & memory API JEP > for Java 22. The initial patch is composed of commits brought over directly > from the [panama-foreign repo](https://github.com/openjdk/panama-foreign). > The main changes found in this patch come from the followin

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v27]

2023-09-26 Thread Jorn Vernee
On Tue, 26 Sep 2023 21:59:35 GMT, Paul Sandoz wrote: > In the implementation the functional interfaces > `BindingInterpreter.StoreFunc/LoadFunc` are package private, but are used in > internal public signatures. This was previously like this and it's not a big > deal but i recommend making tho

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v27]

2023-09-26 Thread Jorn Vernee
On Tue, 26 Sep 2023 18:44:01 GMT, Paul Sandoz wrote: >> Jorn Vernee has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix typos > > src/java.base/share/classes/java/lang/Module.java line 328: > >> 326: System.err.printf(""

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v27]

2023-09-26 Thread Jorn Vernee
On Tue, 26 Sep 2023 21:28:43 GMT, Paul Sandoz wrote: >> Jorn Vernee has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix typos > > src/java.base/share/classes/java/lang/foreign/Linker.java line 35: > >> 33: >> 34: import java.lang.invok

Re: RFR: 8306630: Bump minimum boot jdk to JDK 21

2023-09-26 Thread Iris Clark
On Tue, 26 Sep 2023 21:22:07 GMT, Mikael Vidstedt wrote: > With the JDK 21 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 22. > > Testing: tier1-5, GHA (in progress) Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/159

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v27]

2023-09-26 Thread Paul Sandoz
On Mon, 25 Sep 2023 16:54:10 GMT, Jorn Vernee wrote: >> This patch contains the implementation of the foreign linker & memory API >> JEP for Java 22. The initial patch is composed of commits brought over >> directly from the [panama-foreign >> repo](https://github.com/openjdk/panama-foreign).

Re: RFR: 8306630: Bump minimum boot jdk to JDK 21

2023-09-26 Thread Erik Joelsson
On Tue, 26 Sep 2023 21:22:07 GMT, Mikael Vidstedt wrote: > With the JDK 21 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 22. > > Testing: tier1-5, GHA (in progress) Marked as reviewed by erikj (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v27]

2023-09-26 Thread Paul Sandoz
On Mon, 25 Sep 2023 16:54:10 GMT, Jorn Vernee wrote: >> This patch contains the implementation of the foreign linker & memory API >> JEP for Java 22. The initial patch is composed of commits brought over >> directly from the [panama-foreign >> repo](https://github.com/openjdk/panama-foreign).

Re: RFR: 8306630: Bump minimum boot jdk to JDK 21

2023-09-26 Thread Joe Darcy
On Tue, 26 Sep 2023 21:22:07 GMT, Mikael Vidstedt wrote: > With the JDK 21 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 22. > > Testing: tier1-5, GHA (in progress) Marked as reviewed by darcy (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15

RFR: 8306630: Bump minimum boot jdk to JDK 21

2023-09-26 Thread Mikael Vidstedt
With the JDK 21 GA out it's time to bump the minimum boot JDK version for mainline/JDK 22. Testing: tier1-5, GHA (in progress) - Commit messages: - 8306630: Bump minimum boot jdk to JDK 21 Changes: https://git.openjdk.org/jdk/pull/15934/files Webrev: https://webrevs.openjdk.org/?

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v27]

2023-09-26 Thread Paul Sandoz
On Mon, 25 Sep 2023 16:54:10 GMT, Jorn Vernee wrote: >> This patch contains the implementation of the foreign linker & memory API >> JEP for Java 22. The initial patch is composed of commits brought over >> directly from the [panama-foreign >> repo](https://github.com/openjdk/panama-foreign).

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v27]

2023-09-26 Thread Paul Sandoz
On Mon, 25 Sep 2023 16:54:10 GMT, Jorn Vernee wrote: >> This patch contains the implementation of the foreign linker & memory API >> JEP for Java 22. The initial patch is composed of commits brought over >> directly from the [panama-foreign >> repo](https://github.com/openjdk/panama-foreign).

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v27]

2023-09-26 Thread Paul Sandoz
On Mon, 25 Sep 2023 16:54:10 GMT, Jorn Vernee wrote: >> This patch contains the implementation of the foreign linker & memory API >> JEP for Java 22. The initial patch is composed of commits brought over >> directly from the [panama-foreign >> repo](https://github.com/openjdk/panama-foreign).

Re: RFR: 8308753: Class-File API transition to Preview [v2]

2023-09-26 Thread Adam Sotona
On Tue, 26 Sep 2023 13:10:15 GMT, Chen Liang wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> PreviewFeature annotated with JEP 457 > > src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java line 82: > >

Re: RFR: 8308753: Class-File API transition to Preview [v2]

2023-09-26 Thread Chen Liang
On Tue, 26 Sep 2023 12:32:37 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK

Re: RFR: 8308753: Class-File API transition to Preview [v2]

2023-09-26 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

RFR: 8316645: RISC-V: Remove dependency on libatomic by adding cmpxchg 1b

2023-09-26 Thread Robbin Ehn
Hi all, please consider. latomic is used for non native atomic operation which causes problems with extra dependency. This have been fixed in recent gcc, so latomic is no longer needed. Added new gtest, passes t1 on vf2/qemu. - Commit messages: - Remove latomic, add cmpxchg 1 byte

Re: RFR: 8314438: NMT: Performance benchmarks are needed to have a baseline for comparison of improvements [v3]

2023-09-26 Thread Afshin Zafari
On Tue, 26 Sep 2023 09:51:32 GMT, Magnus Ihse Bursie wrote: > Should there not be a label to alert NMT folks for reviewing? Thanks for the comment. - PR Comment: https://git.openjdk.org/jdk/pull/15563#issuecomment-1735229316

Re: RFR: 8308753: Class-File API transition to Preview

2023-09-26 Thread Magnus Ihse Bursie
On Wed, 13 Sep 2023 09:48:00 GMT, Adam Sotona wrote: > Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and t

Re: RFR: 8314438: NMT: Performance benchmarks are needed to have a baseline for comparison of improvements [v3]

2023-09-26 Thread Magnus Ihse Bursie
On Tue, 26 Sep 2023 08:57:43 GMT, Afshin Zafari wrote: >> A new benchmark for measuring the NMT overhead in `summary` and `detail` >> modes. >> The tests are run using: >> >> make CONF=debug test TEST="micro:java.util.NMTBenchmark" >> MICRO="RESULTS_FORMAT=json" >> >> The results are writte

RFR: 8308753: Class-File API transition to Preview

2023-09-26 Thread Adam Sotona
Classfile API is an internal library under package `jdk.internal.classfile` in JDK 21. This pull request turns the Classfile API into a preview feature and moves it into `java.lang.classfile`. It repackages all uses across JDK and tests and adds lots of missing Javadoc. This PR goes in sync with

Re: RFR: 8295795: hsdis does not build with binutils 2.39+ [v3]

2023-09-26 Thread Andrew Haley
On Mon, 25 Sep 2023 12:01:41 GMT, Robbin Ehn wrote: > > Maybe, but would it really be easier? I don't see that it would be > > _significantly_ easier, and it would be much more riscv community friendly > > to work on the shared disassembler. > > The build would be easier, no deps at all and co

Re: RFR: 8314438: NMT: Performance benchmarks are needed to have a baseline for comparison of improvements [v3]

2023-09-26 Thread Afshin Zafari
> A new benchmark for measuring the NMT overhead in `summary` and `detail` > modes. > The tests are run using: > > make CONF=debug test TEST="micro:java.util.NMTBenchmark" > MICRO="RESULTS_FORMAT=json" > > The results are written to a JSON file that can be visualized using [JMH > Visualizer]