I am currently facing the same error when build paths include Chinese
characters ,after setting the environment variable "export
LC_ALL=zh_CN.UTF-8" .The testing environment is also Ubuntu 2004.
The system locale settings are as follows: LANG=zh_CN.UTF-8
LANGUAGE=zh_CN:zh
LC_CTYPE="zh_CN.UTF-8"
LC_
On Mon, 20 Nov 2023 17:20:50 GMT, Jan Lahoda wrote:
>> Consider a simple module, like:
>>
>> module test {}
>>
>>
>> And compile it with JDK 22 and JDK 21 using:
>> javac --release 21
>>
>> The results of the compilations will differ: when compiling with JDK 21, the
>> mandated java.base dep
On Fri, 27 Oct 2023 11:35:54 GMT, Jan Lahoda wrote:
> Consider a simple module, like:
>
> module test {}
>
>
> And compile it with JDK 22 and JDK 21 using:
> javac --release 21
>
> The results of the compilations will differ: when compiling with JDK 21, the
> mandated java.base dependency wi
On Thu, 23 Nov 2023 09:19:11 GMT, Andrew Haley wrote:
>> Galder Zamarreño has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR. The pull request
>> contains two new
> FYI @theRealAph
>
> It includes a couple of commits to integrate with Capstone v6 while still
> working with Capstone v5 and before:
> * `CAPSTONE_ARCH` for aarch64 is now `CS_ARCH_AARCH64` instead of
> `CS_ARCH_ARM64`. See [this
> document](https://github.com/Rot127/capstone/blob/v6-release-
On Thu, 23 Nov 2023 15:08:42 GMT, Magnus Ihse Bursie wrote:
> The OpenJDK build system does not support building when the source code
> resides on a path that contains a space. This requirement is documented in
> the build instructions but not enforced by the configure script.
>
> This change
On Thu, 23 Nov 2023 08:57:23 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on X
On Thu, 23 Nov 2023 08:57:23 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on X
On Thu, 23 Nov 2023 14:23:54 GMT, Magnus Ihse Bursie wrote:
>> Yea, you are correct. Apparently the gcc extension is not turned off even if
>> you use -ansi.
>> clang on the other hand complains.
>>
>> @galderz your suggested patch is correct, can you open PR ?
>
> @robehn Way ahead of you: htt
On Thu, 23 Nov 2023 14:24:40 GMT, Magnus Ihse Bursie wrote:
> The C snippet in AC_COMPILE_IFELSE is incorrect.
>
> As noted by @galderz:
> https://github.com/openjdk/jdk/pull/15138#discussion_r1402918327
This pull request has now been integrated.
Changeset: beaa79c2
Author:Magnus Ihse Bu
The OpenJDK build system does not support building when the source code resides
on a path that contains a space. This requirement is documented in the build
instructions but not enforced by the configure script.
This change adds an explicit checks to the wrapper `configure` script that fail
the
On Thu, 23 Nov 2023 14:24:40 GMT, Magnus Ihse Bursie wrote:
> The C snippet in AC_COMPILE_IFELSE is incorrect.
>
> As noted by @galderz:
> https://github.com/openjdk/jdk/pull/15138#discussion_r1402918327
Thank you @magicus and @galderz!
Looks good!
-
Marked as reviewed by rehn
On Thu, 23 Nov 2023 09:09:37 GMT, Galder Zamarreño wrote:
>> FYI @theRealAph
>>
>> It includes a couple of commits to integrate with Capstone v6 while still
>> working with Capstone v5 and before:
>> * `CAPSTONE_ARCH` for aarch64 is now `CS_ARCH_AARCH64` instead of
>> `CS_ARCH_ARM64`. See [thi
On Thu, 23 Nov 2023 14:23:54 GMT, Magnus Ihse Bursie wrote:
>> Yea, you are correct. Apparently the gcc extension is not turned off even if
>> you use -ansi.
>> clang on the other hand complains.
>>
>> @galderz your suggested patch is correct, can you open PR ?
>
> @robehn Way ahead of you: htt
The C snippet in AC_COMPILE_IFELSE is incorrect.
As noted by @galderz:
https://github.com/openjdk/jdk/pull/15138#discussion_r1402918327
-
Commit messages:
- 8320663: Fix C syntax in LIB_SETUP_HSDIS_BINUTILS
Changes: https://git.openjdk.org/jdk/pull/16795/files
Webrev: https://we
Congratulations! You get to test drive the recently updated build
instructions for Windows locale requirements! :-)
Please see
https://github.com/openjdk/jdk/blob/master/doc/building.md#locale-requirements
In particular, I believe you need to set your system locale.
Please report back if tha
On Thu, 23 Nov 2023 13:54:47 GMT, Robbin Ehn wrote:
>> @robehn I think that is a gcc extension; not ANSI C.
>
> Yea, you are correct. Apparently the gcc extension is not turned off even if
> you use -ansi.
> clang on the other hand complains.
>
> @galderz your suggested patch is correct, can yo
On Thu, 23 Nov 2023 11:52:38 GMT, Stefan Karlsson wrote:
>> In the rewrites made for:
>> [JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757) `VM_ThreadDump
>> asserts in interleaved ObjectMonitor::deflate_monitor calls`
>>
>> I removed the filtering of *owned ObjectMonitors with dead obj
On Thu, 23 Nov 2023 01:41:46 GMT, Xiaohong Gong wrote:
>> As I said above, you should not mix the two together. Keep the library
>> handling for libsleef. Move the march setting to where it belongs. And
>> rename the files, functions and variables after this.
>
> OK, I see. It makes sense that
On Thu, 23 Nov 2023 08:57:23 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on X
On Thu, 23 Nov 2023 11:52:38 GMT, Stefan Karlsson wrote:
>> In the rewrites made for:
>> [JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757) `VM_ThreadDump
>> asserts in interleaved ObjectMonitor::deflate_monitor calls`
>>
>> I removed the filtering of *owned ObjectMonitors with dead obj
On Thu, 23 Nov 2023 08:57:23 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on X
On Thu, 23 Nov 2023 13:42:22 GMT, Magnus Ihse Bursie wrote:
>> I don't know why.
>>
>>
>> [rehn@rehn-xps ~]$ cat m.c
>> int main() {
>> void foo() {
>> return;
>> };
>> foo();
>> return 0;
>> }
>> [rehn@rehn-xps ~]$ gcc -Wall -Wextra -std=c89 m.c
>> [rehn@rehn-xps ~]$
>
> @robehn I
On Thu, 23 Nov 2023 08:40:57 GMT, Xiaohong Gong wrote:
>> Thanks for the advice! I will take a consideration for it.
>
>> Thirdly, I do not like at all how you just come crashing in setting -march
>> like that. The -march flag is handled by FLAGS_SETUP_ABI_PROFILE.
>
> `-march=armv8-a+sve` is j
On Thu, 23 Nov 2023 07:53:46 GMT, Robbin Ehn wrote:
>>> But nested function are fine, so there is actually no issue with it.
>>
>> Is it? The compilation error above says "error: function definition is not
>> allowed here". It seems to me is saying that the compilation fails because
>> of the
On Thu, 23 Nov 2023 00:48:19 GMT, David Holmes wrote:
> > Previously, the locked monitors never got unlocked because the
> > ObjectMonitor iterator never exposed these monitors to the JNI detach code
>
> I had not realized that. It explains some confusion in a separate issue I had
> been looki
> In the rewrites made for:
> [JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757) `VM_ThreadDump
> asserts in interleaved ObjectMonitor::deflate_monitor calls`
>
> I removed the filtering of *owned ObjectMonitors with dead objects*. The
> reasoning was that you should never have an owned
> In the rewrites made for:
> [JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757) `VM_ThreadDump
> asserts in interleaved ObjectMonitor::deflate_monitor calls`
>
> I removed the filtering of *owned ObjectMonitors with dead objects*. The
> reasoning was that you should never have an owned
On Thu, 23 Nov 2023 02:10:41 GMT, David Holmes wrote:
>> Stefan Karlsson has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Tweaked comment in test
>> - Rewrite tests
>
> test/hotspot/jtreg/runtime/Monitor/libIterateMonitorWithDeadObject
On Thu, 23 Nov 2023 02:07:59 GMT, David Holmes wrote:
>> In the rewrites made for:
>> [JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757) `VM_ThreadDump
>> asserts in interleaved ObjectMonitor::deflate_monitor calls`
>>
>> I removed the filtering of *owned ObjectMonitors with dead object
On Thu, 23 Nov 2023 00:48:19 GMT, David Holmes wrote:
>> In the rewrites made for:
>> [JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757) `VM_ThreadDump
>> asserts in interleaved ObjectMonitor::deflate_monitor calls`
>>
>> I removed the filtering of *owned ObjectMonitors with dead object
On Thu, 23 Nov 2023 09:09:37 GMT, Galder Zamarreño wrote:
>> FYI @theRealAph
>>
>> It includes a couple of commits to integrate with Capstone v6 while still
>> working with Capstone v5 and before:
>> * `CAPSTONE_ARCH` for aarch64 is now `CS_ARCH_AARCH64` instead of
>> `CS_ARCH_ARM64`. See [thi
> FYI @theRealAph
>
> It includes a couple of commits to integrate with Capstone v6 while still
> working with Capstone v5 and before:
> * `CAPSTONE_ARCH` for aarch64 is now `CS_ARCH_AARCH64` instead of
> `CS_ARCH_ARM64`. See [this
> document](https://github.com/Rot127/capstone/blob/v6-release-
On Thu, 23 Nov 2023 01:38:57 GMT, David Holmes wrote:
>> In the rewrites made for:
>> [JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757) `VM_ThreadDump
>> asserts in interleaved ObjectMonitor::deflate_monitor calls`
>>
>> I removed the filtering of *owned ObjectMonitors with dead object
> Currently the vector floating-point math APIs like
> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
> which causes large performance gap on AArch64. Note that those APIs are
> optimized by C2 compiler on X86 platforms by calling Intel's SVML code [1].
> To close th
On Thu, 23 Nov 2023 01:29:24 GMT, David Holmes wrote:
>> In the rewrites made for:
>> [JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757) `VM_ThreadDump
>> asserts in interleaved ObjectMonitor::deflate_monitor calls`
>>
>> I removed the filtering of *owned ObjectMonitors with dead object
On Wed, 15 Nov 2023 01:32:00 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on X
On Thu, 23 Nov 2023 01:28:32 GMT, David Holmes wrote:
>> In the rewrites made for:
>> [JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757) `VM_ThreadDump
>> asserts in interleaved ObjectMonitor::deflate_monitor calls`
>>
>> I removed the filtering of *owned ObjectMonitors with dead object
On Thu, 23 Nov 2023 01:28:40 GMT, Xiaohong Gong wrote:
>> Ah, now I se what you are trying to do here. First of all, in the detection
>> part, only set `SVE_FEATURE_SUPPORT`. Then you can handle the `SVE_CFLAGS`
>> addition elsewhere/later.
>>
>> Secondly, you should not mix these `SVE_CFLAGS
On Thu, 23 Nov 2023 01:27:24 GMT, David Holmes wrote:
>> In the rewrites made for:
>> [JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757) `VM_ThreadDump
>> asserts in interleaved ObjectMonitor::deflate_monitor calls`
>>
>> I removed the filtering of *owned ObjectMonitors with dead object
40 matches
Mail list logo
