On Thu, 14 Mar 2024 14:24:57 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Thu, 14 Mar 2024 15:56:42 GMT, Erik Joelsson wrote:
>> Magnus Ihse Bursie has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains four
>> additional
On Thu, 14 Mar 2024 15:53:37 GMT, Erik Joelsson wrote:
>> Magnus Ihse Bursie has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains four
>> additional
On Thu, 14 Mar 2024 20:54:32 GMT, Mandy Chung wrote:
> About the configure options,
>
> ```
> --enable-keep-packaged-modules
> enable keeping of packaged modules in jdk image
> [enabled]
> --enable-runtime-link-image
> enable producing an
On Thu, 14 Mar 2024 14:24:57 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Thu, 14 Mar 2024 15:16:53 GMT, Magnus Ihse Bursie wrote:
>> We are setting one of the flags `CFLAGS_JDKLIB`, `CXXFLAGS_JDKLIB`,
>> `CFLAGS_JDKEXE` or `CXXFLAGS_JDKEXE` to `CFLAGS` or `CXXFLAGS`,
>> respectively, in basically all calls to `SetupJdkLibrary` and
>> `SetupJdkExecutable`.
>>
>>
On Thu, 14 Mar 2024 14:24:57 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Thu, 14 Mar 2024 14:27:47 GMT, Severin Gehwolf wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comment in autoconf file
>
> make/Images.gmk line 33:
>
>> 31: include Modules.gmk
>> 32: include Utils.gmk
On Thu, 14 Mar 2024 14:03:07 GMT, Magnus Ihse Bursie wrote:
>> We are adding LIBCXX to LIBS in calls to SetupJdkLibrary whenever LINK_TYPE
>> is C++. We should do this automatically in SetupJdkLibrary for C++ linking.
>>
>> I also removed the superfluous `-lc` from some places where it had been
On Thu, 14 Mar 2024 09:14:04 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks
>>
>> This is a continuation of work based on [1] by @XiaohongGong, most work was
>> done in that pr. In this new pr, just rebased the code in [1], then added
>> some minor changes (renami
On Thu, 14 Mar 2024 11:20:26 GMT, Robbin Ehn wrote:
> Hi, thanks for continuing with this.
>
> As this is similar to SVML, comments applies to x86 also:
>
> * There is no way to stop the VM from trying to load vmath ?
> There is both a UseNeon and a UseSVE, if I set both to false I wo
On Thu, 14 Mar 2024 09:14:04 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks
>>
>> This is a continuation of work based on [1] by @XiaohongGong, most work was
>> done in that pr. In this new pr, just rebased the code in [1], then added
>> some minor changes (renami
> We are setting one of the flags `CFLAGS_JDKLIB`, `CXXFLAGS_JDKLIB`,
> `CFLAGS_JDKEXE` or `CXXFLAGS_JDKEXE` to `CFLAGS` or `CXXFLAGS`, respectively,
> in basically all calls to `SetupJdkLibrary` and `SetupJdkExecutable`.
>
> These flag variables contain a lot of duplication.
>
> The first step
> Please review this patch which adds a jlink mode to the JDK which doesn't
> need the packaged modules being present. A.k.a run-time image based jlink.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory `jm
On Thu, 14 Mar 2024 14:24:57 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Tue, 27 Feb 2024 22:04:47 GMT, Erik Joelsson wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Only show runtime image suffix for JDK modules
>
> make/autoconf/jdk-options.m4 line 596:
>
>> 594:
>> ##
On Tue, 12 Mar 2024 14:07:32 GMT, Magnus Ihse Bursie wrote:
>> I don't see a race. The `rm` was there in the original code and is no
>> scarier in the modified version. The jdk image is constructed by a
>> combination of targets and recipes. The first one to run has to be jlink,
>> then we ove
On Tue, 27 Feb 2024 22:06:12 GMT, Erik Joelsson wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Only show runtime image suffix for JDK modules
>
> make/autoconf/spec.gmk.template line 904:
>
>> 902: RL_INTERMED
On Fri, 8 Mar 2024 17:25:18 GMT, Severin Gehwolf wrote:
>> make/Images.gmk line 96:
>>
>>> 94:
>>> 95: ifeq ($(JLINK_KEEP_PACKAGED_MODULES), true)
>>> 96: ifeq ($(JLINK_PRODUCE_RUNTIME_LINK_JDK), true)
>>
>> I don't get it. Why don't you use the JDK_LINK_OUTPUT_DIR from just above?
>
> Make
On Fri, 8 Mar 2024 19:49:19 GMT, Mandy Chung wrote:
>>> > @AlanBateman @mlchung I've now pushed an update of this patch which now
>>> > uses a build-time approach as discussed elsewhere. In order to produce a
>>> > linkable runtime JDK image, one needs to set --enable-runtime-link-image
>>> >
> Please review this patch which adds a jlink mode to the JDK which doesn't
> need the packaged modules being present. A.k.a run-time image based jlink.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory `jm
> We are adding LIBCXX to LIBS in calls to SetupJdkLibrary whenever LINK_TYPE
> is C++. We should do this automatically in SetupJdkLibrary for C++ linking.
>
> I also removed the superfluous `-lc` from some places where it had been added.
Magnus Ihse Bursie has updated the pull request with a ne
> We are setting one of the flags `CFLAGS_JDKLIB`, `CXXFLAGS_JDKLIB`,
> `CFLAGS_JDKEXE` or `CXXFLAGS_JDKEXE` to `CFLAGS` or `CXXFLAGS`, respectively,
> in basically all calls to `SetupJdkLibrary` and `SetupJdkExecutable`.
>
> These flag variables contain a lot of duplication.
>
> The first step
On Thu, 14 Mar 2024 13:29:05 GMT, Magnus Ihse Bursie wrote:
>> We are adding LIBCXX to LIBS in calls to SetupJdkLibrary whenever LINK_TYPE
>> is C++. We should do this automatically in SetupJdkLibrary for C++ linking.
>>
>> I also removed the superfluous `-lc` from some places where it had been
On Mon, 11 Mar 2024 17:46:14 GMT, Chad Rakoczy wrote:
> Fix for [8325621](https://bugs.openjdk.org/browse/JDK-8325621)
>
> Updates jspawnhelper to check that JDK version and jspawnhelper version are
> the same. Updates test to include check for version. Also tested manually by
> replacing jspa
> We are adding LIBCXX to LIBS in calls to SetupJdkLibrary whenever LINK_TYPE
> is C++. We should do this automatically in SetupJdkLibrary for C++ linking.
>
> I also removed the superfluous `-lc` from some places where it had been added.
Magnus Ihse Bursie has updated the pull request increment
On Wed, 13 Mar 2024 17:11:25 GMT, Chad Rakoczy wrote:
>> Fix for [8325621](https://bugs.openjdk.org/browse/JDK-8325621)
>>
>> Updates jspawnhelper to check that JDK version and jspawnhelper version are
>> the same. Updates test to include check for version. Also tested manually by
>> replacing
On Thu, 14 Mar 2024 12:36:05 GMT, Magnus Ihse Bursie wrote:
> We are setting one of the flags `CFLAGS_JDKLIB`, `CXXFLAGS_JDKLIB`,
> `CFLAGS_JDKEXE` or `CXXFLAGS_JDKEXE` to `CFLAGS` or `CXXFLAGS`, respectively,
> in basically all calls to `SetupJdkLibrary` and `SetupJdkExecutable`.
>
> These fl
We are setting one of the flags `CFLAGS_JDKLIB`, `CXXFLAGS_JDKLIB`,
`CFLAGS_JDKEXE` or `CXXFLAGS_JDKEXE` to `CFLAGS` or `CXXFLAGS`, respectively,
in basically all calls to `SetupJdkLibrary` and `SetupJdkExecutable`.
These flag variables contain a lot of duplication.
The first step towards bring
On Thu, 14 Mar 2024 12:36:05 GMT, Magnus Ihse Bursie wrote:
> We are setting one of the flags `CFLAGS_JDKLIB`, `CXXFLAGS_JDKLIB`,
> `CFLAGS_JDKEXE` or `CXXFLAGS_JDKEXE` to `CFLAGS` or `CXXFLAGS`, respectively,
> in basically all calls to `SetupJdkLibrary` and `SetupJdkExecutable`.
>
> These fl
On Thu, 14 Mar 2024 09:14:04 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks
>>
>> This is a continuation of work based on [1] by @XiaohongGong, most work was
>> done in that pr. In this new pr, just rebased the code in [1], then added
>> some minor changes (renami
On Thu, 14 Mar 2024 09:14:04 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks
>>
>> This is a continuation of work based on [1] by @XiaohongGong, most work was
>> done in that pr. In this new pr, just rebased the code in [1], then added
>> some minor changes (renami
On Thu, 14 Mar 2024 09:14:04 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks
>>
>> This is a continuation of work based on [1] by @XiaohongGong, most work was
>> done in that pr. In this new pr, just rebased the code in [1], then added
>> some minor changes (renami
We are adding LIBCXX to LIBS in calls to SetupJdkLibrary whenever LINK_TYPE is
C++. We should do this automatically in SetupJdkLibrary for C++ linking.
I also removed the superfluous `-lc` from some places where it had been added.
-
Commit messages:
- 8328146: Set LIBCXX automatica
On Thu, 11 Jan 2024 13:23:45 GMT, Julian Waters wrote:
>> Compile the JDK as C++17, enabling the use of all C++17 language features
>
> Julian Waters has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Require clang 13 in toolchain.m4
As I sai
Hi all,
I'm currently working on allowing hsdis to compile under different
Unix environments for Windows with gcc as the compiler, since it's
required for the binutils backend (For good measure I'll throw
capstone support in as well since it's relatively easy to add and it's
also a package under t
On Thu, 14 Mar 2024 08:59:09 GMT, Ludovic Henry wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix variable name in github workflow
>
> .github/workflows/build-cross-compile.yml line 138:
>
>> 136: --arch=
> Hi,
> Can you help to review this patch?
> Thanks
>
> This is a continuation of work based on [1] by @XiaohongGong, most work was
> done in that pr. In this new pr, just rebased the code in [1], then added
> some minor changes (renaming of calling method, add libsleef as extra lib in
> CI cro
On Thu, 14 Mar 2024 08:48:11 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review this patch?
> Thanks
>
> This is a continuation of work based on [1] by @XiaohongGong, most work was
> done in that pr. In this new pr, just rebased the code in [1], then added
> some minor changes (renaming of c
On Fri, 1 Mar 2024 15:10:30 GMT, Magnus Ihse Bursie wrote:
>> Xiaohong Gong has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix potential attribute issue
>
> Iirc, your assessment is right; the code should be ready for integration; I
>
Hi,
Can you help to review this patch?
Thanks
This is a continuation of work based on [1] by @XiaohongGong, most work was
done in that pr. In this new pr, just rebased the code in [1], then added some
minor changes (renaming of calling method, add libsleef as extra lib in CI
cross-build on aarc
On Tue, 12 Mar 2024 18:42:48 GMT, Erik Joelsson wrote:
>> Chad Rakoczy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Code cleanup
>
> I'm fine with just using VERSION_FEATURE. I think it's a simple and
> straightforward enough simplif
On Thu, 11 Jan 2024 13:23:45 GMT, Julian Waters wrote:
>> Compile the JDK as C++17, enabling the use of all C++17 language features
>
> Julian Waters has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Require clang 13 in toolchain.m4
Now the
On Wed, 13 Mar 2024 09:57:12 GMT, Magnus Ihse Bursie wrote:
> After we removed mapfiles, we can setup -fvisibility=hidden (and
> -Wl,--exclude-libs,ALL) in the most basic flags, so this applies to all
> compilation.
>
> This will remove duplicate code and make the underlying assumptions of the
On Wed, 13 Mar 2024 15:48:15 GMT, Magnus Ihse Bursie wrote:
> This is a collection of various improvements to `COMPARE_BUILD` I have been
> using lately.
>
> * Introducing `DEBUG_CDS_ARCHIVE` make variable, which is set automatically
> when using `COMPARE_BUILD`. This will create a detailed lo
45 matches
Mail list logo
