Re: RFR: 8319457: Update jpackage to support WiX Toolset 4 on Windows

2024-06-03 Thread Alexander Matveev
On Tue, 4 Jun 2024 01:29:15 GMT, Alexey Semenyuk wrote: > > Is there plan to add support for WiX 5? > > This patch supports WiX5 as well. There is not much difference between WiX4 > and WiX5 from jpackage perspective. I'll update the description I assume WiX5 will just work if installed instea

Re: RFR: 8319457: Update jpackage to support WiX Toolset 4 on Windows

2024-06-03 Thread Alexey Semenyuk
On Tue, 4 Jun 2024 01:24:15 GMT, Alexander Matveev wrote: > Is there plan to add support for WiX 5? This patch supports WiX5 as well. There is not much difference between WiX4 and WiX5 from jpackage perspective. I'll update the description - PR Comment: https://git.openjdk.org/jdk

Re: RFR: 8293980: Resolve CONSTANT_FieldRef at CDS dump time [v5]

2024-06-03 Thread Ioi Lam
> ### Overview > > This PR archives `CONSTANT_FieldRef` entries in the _resolved_ state when > it's safe to do so. > > I.e., when a `CONSTANT_FieldRef` constant pool entry in class `A` refers to a > *non-static* field `B.F`, > - `B` is the same class as `A`; or > - `B` is a supertype of `A`; o

Re: RFR: 8293980: Resolve CONSTANT_FieldRef at CDS dump time [v3]

2024-06-03 Thread Ioi Lam
On Fri, 31 May 2024 18:43:49 GMT, Ioi Lam wrote: >> The current algorithm says: >> >> for each bytecode in each method: >> switch(bytecode) { >> case getfield: >> case outfield: >> InterpreterRuntime::resolve_get_put(bc, raw_index, mh, cp, false >> /*initialize_holder*/, CHECK);

Re: RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v29]

2024-06-03 Thread Alan Bateman
On Mon, 3 Jun 2024 15:40:10 GMT, Severin Gehwolf wrote: > Does that proposal sound good? That table is useful, I think it's right. No change to default behavior. If someone configures with --enable-runtime-image then they get a JDK run-time image that supports jlink (with some limitations) but

Re: RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v29]

2024-06-03 Thread Severin Gehwolf
On Mon, 3 Jun 2024 12:55:54 GMT, Alan Bateman wrote: > So I think we may have the wrong default. Yes, they are separate configure > and jlink options but I'm wondering if it would be more sensible to > opt-in(not opt-out) to keep the packaged modules when configured with > --enable-runtime-lin

Re: RFR: 8333128: Linux x86_32 configure fail with --with-hsdis=binutils --with-binutils-src [v2]

2024-06-03 Thread SendaoYan
On Mon, 3 Jun 2024 09:16:36 GMT, SendaoYan wrote: >> Hi all, >> This PR try to fix linux x86_32 configure fail with `--with-hsdis=binutils >> --with-binutils-src`. The libiberty.a locates in >> `build/linux-x86-server-fastdebug/configure-support/binutils-install/lib32` >> on linux ubuntu20.

Re: RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v29]

2024-06-03 Thread Alan Bateman
On Sun, 2 Jun 2024 17:41:55 GMT, Alan Bateman wrote: >> Severin Gehwolf has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 110 commits: >> >> - Merge branch 'master' into jdk-8311302-jmodless-link >> - Fix new line in jlink.propert

Integrated: 8333128: Linux x86_32 configure fail with --with-hsdis=binutils --with-binutils-src

2024-06-03 Thread SendaoYan
On Sun, 2 Jun 2024 02:49:47 GMT, SendaoYan wrote: > Hi all, > This PR try to fix linux x86_32 configure fail with `--with-hsdis=binutils > --with-binutils-src`. The libiberty.a locates in > `build/linux-x86-server-fastdebug/configure-support/binutils-install/lib32` > on linux ubuntu20. The c

Re: RFR: 8333128: Linux x86_32 configure fail with --with-hsdis=binutils --with-binutils-src [v2]

2024-06-03 Thread SendaoYan
On Mon, 3 Jun 2024 09:16:36 GMT, SendaoYan wrote: >> Hi all, >> This PR try to fix linux x86_32 configure fail with `--with-hsdis=binutils >> --with-binutils-src`. The libiberty.a locates in >> `build/linux-x86-server-fastdebug/configure-support/binutils-install/lib32` >> on linux ubuntu20.

Re: RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v29]

2024-06-03 Thread Severin Gehwolf
On Sun, 2 Jun 2024 17:41:55 GMT, Alan Bateman wrote: > I've been looking through the changes. One thing that I'm wondering about is > whether --generate-runtime-link-image should disable the keeping of packaged > modules (set JLINK_KEEP_PACKAGED_MODULES to false). It seems surprising to > use

Integrated: 8333301: Remove static builds using --enable-static-build

2024-06-03 Thread Magnus Ihse Bursie
On Thu, 30 May 2024 19:14:43 GMT, Magnus Ihse Bursie wrote: > The original way of building static libraries in the JDK was to use the > configure argument --enable-static-build, which set the value of the make > variable STATIC_BUILD. (Note that this is not the same as the source code > defini

Re: RFR: 8333128: Linux x86_32 configure fail with --with-hsdis=binutils --with-binutils-src [v2]

2024-06-03 Thread Magnus Ihse Bursie
On Mon, 3 Jun 2024 09:16:36 GMT, SendaoYan wrote: >> Hi all, >> This PR try to fix linux x86_32 configure fail with `--with-hsdis=binutils >> --with-binutils-src`. The libiberty.a locates in >> `build/linux-x86-server-fastdebug/configure-support/binutils-install/lib32` >> on linux ubuntu20.

Re: RFR: 8333128: Linux x86_32 configure fail with --with-hsdis=binutils --with-binutils-src [v2]

2024-06-03 Thread SendaoYan
On Mon, 3 Jun 2024 08:59:50 GMT, Julian Waters wrote: >> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> "or $BINUTILS_INSTALL_DIR/lib64" should probably be on the new line in >> this comment > > make/autoconf/lib-hsdis.m4 lin

Re: RFR: 8333128: Linux x86_32 configure fail with --with-hsdis=binutils --with-binutils-src [v2]

2024-06-03 Thread Julian Waters
On Mon, 3 Jun 2024 09:13:57 GMT, SendaoYan wrote: >> Hi all, >> This PR try to fix linux x86_32 configure fail with `--with-hsdis=binutils >> --with-binutils-src`. The libiberty.a locates in >> `build/linux-x86-server-fastdebug/configure-support/binutils-install/lib32` >> on linux ubuntu20.

Re: RFR: 8333128: Linux x86_32 configure fail with --with-hsdis=binutils --with-binutils-src [v2]

2024-06-03 Thread SendaoYan
> Hi all, > This PR try to fix linux x86_32 configure fail with `--with-hsdis=binutils > --with-binutils-src`. The libiberty.a locates in > `build/linux-x86-server-fastdebug/configure-support/binutils-install/lib32` > on linux ubuntu20. The change has been verified, the risk is low. > > Addit

Re: RFR: 8333128: Linux x86_32 configure fail with --with-hsdis=binutils --with-binutils-src

2024-06-03 Thread Julian Waters
On Mon, 3 Jun 2024 09:02:47 GMT, Aleksey Shipilev wrote: > > Don't forget about me! :) > > Ah yes, you are also in Build Group now! Apologies. No worries, I was joking lightheartedly :P - PR Comment: https://git.openjdk.org/jdk/pull/19511#issuecomment-2144674185

Re: RFR: 8333128: Linux x86_32 configure fail with --with-hsdis=binutils --with-binutils-src

2024-06-03 Thread Aleksey Shipilev
On Mon, 3 Jun 2024 08:58:55 GMT, Julian Waters wrote: > Don't forget about me! :) Ah yes, you are also in Build Group now! Apologies. - PR Comment: https://git.openjdk.org/jdk/pull/19511#issuecomment-2144667812

Re: RFR: 8333128: Linux x86_32 configure fail with --with-hsdis=binutils --with-binutils-src

2024-06-03 Thread Julian Waters
On Sun, 2 Jun 2024 02:49:47 GMT, SendaoYan wrote: > Hi all, > This PR try to fix linux x86_32 configure fail with `--with-hsdis=binutils > --with-binutils-src`. The libiberty.a locates in > `build/linux-x86-server-fastdebug/configure-support/binutils-install/lib32` > on linux ubuntu20. The c

Re: RFR: 8333128: Linux x86_32 configure fail with --with-hsdis=binutils --with-binutils-src

2024-06-03 Thread Aleksey Shipilev
On Sun, 2 Jun 2024 02:49:47 GMT, SendaoYan wrote: > Hi all, > This PR try to fix linux x86_32 configure fail with `--with-hsdis=binutils > --with-binutils-src`. The libiberty.a locates in > `build/linux-x86-server-fastdebug/configure-support/binutils-install/lib32` > on linux ubuntu20. The c

Re: RFR: 8333128: Linux x86_32 configure fail with --with-hsdis=binutils --with-binutils-src

2024-06-03 Thread SendaoYan
On Sun, 2 Jun 2024 02:49:47 GMT, SendaoYan wrote: > Hi all, > This PR try to fix linux x86_32 configure fail with `--with-hsdis=binutils > --with-binutils-src`. The libiberty.a locates in > `build/linux-x86-server-fastdebug/configure-support/binutils-install/lib32` > on linux ubuntu20. The c

Re: RFR: 8333128: Linux x86_32 configure fail with --with-hsdis=binutils --with-binutils-src

2024-06-03 Thread Aleksey Shipilev
On Sun, 2 Jun 2024 02:49:47 GMT, SendaoYan wrote: > Hi all, > This PR try to fix linux x86_32 configure fail with `--with-hsdis=binutils > --with-binutils-src`. The libiberty.a locates in > `build/linux-x86-server-fastdebug/configure-support/binutils-install/lib32` > on linux ubuntu20. The c