Integrated: 8334763: --enable-asan: assert(_thread->is_in_live_stack((address)this)) failed: not on stack?

2024-06-27 Thread Jan Kratochvil
On Sat, 22 Jun 2024 13:58:32 GMT, Jan Kratochvil wrote: > fastdebug: > > > # A fatal error has been detected by the Java Runtime Environment: > # > # Internal Error > (/home/azul/azul/openjdk-git/src/hotspot/share/runtime/handles.inline.hpp:77), > pid=878152, tid=878158 > # assert(_thread-

Re: RFR: 8334763: --enable-asan: assert(_thread->is_in_live_stack((address)this)) failed: not on stack? [v6]

2024-06-27 Thread duke
On Thu, 27 Jun 2024 01:34:36 GMT, Jan Kratochvil wrote: >> fastdebug: >> >> >> # A fatal error has been detected by the Java Runtime Environment: >> # >> # Internal Error >> (/home/azul/azul/openjdk-git/src/hotspot/share/runtime/handles.inline.hpp:77), >> pid=878152, tid=878158 >> # assert

Re: RFR: 8329816: Add SLEEF version 3.6.1

2024-06-27 Thread Mikael Vidstedt
On Mon, 24 Jun 2024 13:30:35 GMT, Hamlin Li wrote: >> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to >> optimize vector math operations by leveraging the SLEEF library. For legal >> reasons the actual contribution of the SLEEF files needs to be handled >> separately.

Re: RFR: 8329816: Add SLEEF version 3.6.1 [v3]

2024-06-27 Thread Mikael Vidstedt
> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to > optimize vector math operations by leveraging the SLEEF library. For legal > reasons the actual contribution of the SLEEF files needs to be handled > separately. This enhancement adds the relevant files, enabling the re

Re: RFR: 8329816: Add SLEEF version 3.6.1 [v2]

2024-06-27 Thread Magnus Ihse Bursie
On Thu, 23 May 2024 12:49:42 GMT, Hamlin Li wrote: >> Okay, suffix works fine too. But the files currently in the patch is named >> e.g. `sleefinline_advsimd.h`, which does not indicate any platform at all. >> Is it a generic file, and the platform specific ones are still missing from >> this

Re: RFR: 8329816: Add SLEEF version 3.6.1 [v2]

2024-06-27 Thread Hamlin Li
On Thu, 23 May 2024 16:06:42 GMT, Magnus Ihse Bursie wrote: >> I think both `sleefinline_advsimd.h` and `sleefinline_sve.h` are specific >> for arm. >> In the future, on riscv the corresponding file name will be >> `sleefinline_rvvm1.h`. >> >> Only `misc.h` is a generic file shared among platf

Re: RFR: 8329816: Add SLEEF version 3.6.1 [v2]

2024-06-27 Thread Hamlin Li
On Thu, 23 May 2024 10:40:26 GMT, Magnus Ihse Bursie wrote: >>> So you'd need a different copy of sleef for each platform? >> >> I think it's one or more. >> >>> The files you have put in linux/native/libvectormath, what platform are >>> they for? Should we not put them in a platform-specific

Re: RFR: 8329816: Add SLEEF version 3.6.1 [v2]

2024-06-27 Thread Magnus Ihse Bursie
On Wed, 22 May 2024 09:39:43 GMT, Hamlin Li wrote: >> make/devkit/createSleef.sh line 32: >> >>> 30: # >>> 31: # 1. cd >>> 32: # 2. bash /make/devkit/createSleef.sh aarch64-gcc.cmake >>> /devkit >> >> So you'd need a different copy of sleef for each platform? The files you >> have put in

Re: RFR: 8329816: Add SLEEF version 3.6.1 [v2]

2024-06-27 Thread Hamlin Li
On Wed, 22 May 2024 09:31:27 GMT, Magnus Ihse Bursie wrote: > So you'd need a different copy of sleef for each platform? I think it's one or more. > The files you have put in linux/native/libvectormath, what platform are they > for? Should we not put them in a platform-specific subdirectory?

Re: RFR: 8329816: Add SLEEF version 3.6.1 [v2]

2024-06-27 Thread Magnus Ihse Bursie
On Thu, 27 Jun 2024 21:56:19 GMT, Mikael Vidstedt wrote: >> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to >> optimize vector math operations by leveraging the SLEEF library. For legal >> reasons the actual contribution of the SLEEF files needs to be handled >> separa

Re: RFR: 8329816: Add SLEEF version 3.6.1

2024-06-27 Thread Hamlin Li
On Fri, 10 May 2024 22:32:29 GMT, Mikael Vidstedt wrote: > [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to > optimize vector math operations by leveraging the SLEEF library. For legal > reasons the actual contribution of the SLEEF files needs to be handled > separately

Re: RFR: 8329816: Add SLEEF version 3.6.1

2024-06-27 Thread Magnus Ihse Bursie
On Fri, 10 May 2024 22:32:29 GMT, Mikael Vidstedt wrote: > [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to > optimize vector math operations by leveraging the SLEEF library. For legal > reasons the actual contribution of the SLEEF files needs to be handled > separately

Re: RFR: 8329816: Add SLEEF version 3.6.1

2024-06-27 Thread Mikael Vidstedt
On Fri, 10 May 2024 22:32:29 GMT, Mikael Vidstedt wrote: > [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to > optimize vector math operations by leveraging the SLEEF library. For legal > reasons the actual contribution of the SLEEF files needs to be handled > separately

Re: RFR: 8329816: Add SLEEF version 3.6.1 [v2]

2024-06-27 Thread Mikael Vidstedt
> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to > optimize vector math operations by leveraging the SLEEF library. For legal > reasons the actual contribution of the SLEEF files needs to be handled > separately. This enhancement adds the relevant files, enabling the re

Re: RFR: 8329816: Add SLEEF version 3.6.1

2024-06-27 Thread Hamlin Li
On Fri, 17 May 2024 16:45:19 GMT, Mikael Vidstedt wrote: > Thank you Hamlin. I'll try to keep my eyes open for the announcement of the > upcoming SLEEF release but do feel free to notify me if you see it first! Thank you @vidmik , sure, I will do it. > I, too, envision that we'll be importing

Re: RFR: 8334763: --enable-asan: assert(_thread->is_in_live_stack((address)this)) failed: not on stack? [v6]

2024-06-27 Thread Erik Joelsson
On Thu, 27 Jun 2024 01:34:36 GMT, Jan Kratochvil wrote: >> fastdebug: >> >> >> # A fatal error has been detected by the Java Runtime Environment: >> # >> # Internal Error >> (/home/azul/azul/openjdk-git/src/hotspot/share/runtime/handles.inline.hpp:77), >> pid=878152, tid=878158 >> # assert

Integrated: 8334895: OpenJDK fails to configure on linux aarch64 when CDS is disabled after JDK-8331942

2024-06-27 Thread Vladimir Petko
On Mon, 24 Jun 2024 22:22:38 GMT, Vladimir Petko wrote: > This PR sets COMPATIBLE_CDS_ALIGNMENT_DEFAULT to auto for aarch64. > This allows to avoid configure error on arm64: > > $ sh configure --disable-jvm-feature-cds > ... > checking if CDS archive is available... no (CDS is disabled) > check

Integrated: 8309634: Resolve CONSTANT_MethodRef at CDS dump time

2024-06-27 Thread Ioi Lam
On Mon, 24 Jun 2024 17:21:18 GMT, Ioi Lam wrote: > Resolve `CONSTANT_MethodRef` entries during CDS dump time to improve start-up > performance. > > - This PR uses the same framework introduced in #19355 and just added > handling for methods. > - Support for getstatic/putstatic/invokestatic wil

Re: RFR: 8309634: Resolve CONSTANT_MethodRef at CDS dump time [v3]

2024-06-27 Thread Ioi Lam
On Wed, 26 Jun 2024 18:17:00 GMT, Matias Saavedra Silva wrote: >> Ioi Lam has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains five additional commit

Re: RFR: 8309634: Resolve CONSTANT_MethodRef at CDS dump time [v3]

2024-06-27 Thread Ioi Lam
> Resolve `CONSTANT_MethodRef` entries during CDS dump time to improve start-up > performance. > > - This PR uses the same framework introduced in #19355 and just added > handling for methods. > - Support for getstatic/putstatic/invokestatic will be done separately in > [JDK-8334898](https://bu

Re: RFR: 8334031: Generated JfrNativeSettings seems off

2024-06-27 Thread duke
On Tue, 25 Jun 2024 18:55:14 GMT, Robert Toyonaga wrote: > This PR changes GenerateJfrFiles.java so that the generated > `JfrNativeSettings` union does not include JFR structs.`JfrNativeSettings` is > meant to hold the settings for JFR events, but previously also included JFR > structs such as

Re: RFR: 8334763: --enable-asan: assert(_thread->is_in_live_stack((address)this)) failed: not on stack? [v4]

2024-06-27 Thread duke
On Mon, 24 Jun 2024 14:11:35 GMT, Jan Kratochvil wrote: >> fastdebug: >> >> >> # A fatal error has been detected by the Java Runtime Environment: >> # >> # Internal Error >> (/home/azul/azul/openjdk-git/src/hotspot/share/runtime/handles.inline.hpp:77), >> pid=878152, tid=878158 >> # assert

Re: RFR: 8334895: OpenJDK fails to configure on linux aarch64 when CDS is disabled after JDK-8331942 [v3]

2024-06-27 Thread duke
On Tue, 25 Jun 2024 19:30:26 GMT, Vladimir Petko wrote: >> This PR sets COMPATIBLE_CDS_ALIGNMENT_DEFAULT to auto for aarch64. >> This allows to avoid configure error on arm64: >> >> $ sh configure --disable-jvm-feature-cds >> ... >> checking if CDS archive is available... no (CDS is disabled) >

Re: RFR: 8309634: Resolve CONSTANT_MethodRef at CDS dump time [v2]

2024-06-27 Thread Calvin Cheung
On Wed, 26 Jun 2024 03:11:41 GMT, Ioi Lam wrote: >> Resolve `CONSTANT_MethodRef` entries during CDS dump time to improve >> start-up performance. >> >> - This PR uses the same framework introduced in #19355 and just added >> handling for methods. >> - Support for getstatic/putstatic/invokestat

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v6]

2024-06-27 Thread Hamlin Li
On Thu, 27 Jun 2024 11:53:38 GMT, Fei Gao wrote: >> in progress... > > Hi @Hamlin-Li , thanks for your work. > > I tried to run benchmarks, > [FloatMaxVector](https://github.com/openjdk/panama-vector/blob/vectorIntrinsics/test/micro/org/openjdk/bench/jdk/incubator/vector/operation/FloatMaxVecto

Re: Is anyone able to build the JDK on Windows using VirtualBox to host Ubuntu?

2024-06-27 Thread erik . joelsson
Hello Anil, Building in a VM on a laptop should be doable, but given how resource intensive the JDK build is, you could run into problems like you describe. You are most likely to get the best build performance running natively on the machine and OS you have, so my recommendation is to build

Re: RFR: 8317611: Add a tool like jdeprscan to find usage of restricted methods [v9]

2024-06-27 Thread Jan Lahoda
On Mon, 24 Jun 2024 12:57:39 GMT, Jorn Vernee wrote: >> This PR adds a new JDK tool, called `jnativescan`, that can be used to find >> code that accesses native functionality. Currently this includes `native` >> method declarations, and methods marked with `@Restricted`. >> >> The tool accepts

Re: RFR: 8334031: Generated JfrNativeSettings seems off

2024-06-27 Thread Robert Toyonaga
On Wed, 26 Jun 2024 18:52:40 GMT, Erik Gahlin wrote: >> This PR changes GenerateJfrFiles.java so that the generated >> `JfrNativeSettings` union does not include JFR structs.`JfrNativeSettings` >> is meant to hold the settings for JFR events, but previously also included >> JFR structs such as

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v6]

2024-06-27 Thread Fei Gao
On Thu, 6 Jun 2024 07:52:02 GMT, Hamlin Li wrote: >> Hamlin Li has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update header files for arm > > in progress... Hi @Hamlin-Li , thanks for your work. I tried to run benchmarks, [FloatMaxVe

Is anyone able to build the JDK on Windows using VirtualBox to host Ubuntu?

2024-06-27 Thread Anil
I want to try out a small contribution to the JDK and want to build the JDK first. I have a Windows 11 laptop. I am not comfortable with the Windows commands and someone mentioned in this forum that most of the building is done on Linux. So I installed VirtualBox 7.0.18 and Ubuntu 24.04. however I

Re: RFR: 8334763: --enable-asan: assert(_thread->is_in_live_stack((address)this)) failed: not on stack? [v6]

2024-06-27 Thread Kim Barrett
On Thu, 27 Jun 2024 01:34:36 GMT, Jan Kratochvil wrote: >> fastdebug: >> >> >> # A fatal error has been detected by the Java Runtime Environment: >> # >> # Internal Error >> (/home/azul/azul/openjdk-git/src/hotspot/share/runtime/handles.inline.hpp:77), >> pid=878152, tid=878158 >> # assert

Re: RFR: 8334763: --enable-asan: assert(_thread->is_in_live_stack((address)this)) failed: not on stack? [v5]

2024-06-27 Thread Kim Barrett
On Thu, 27 Jun 2024 01:48:23 GMT, Jan Kratochvil wrote: >> make/autoconf/jdk-options.m4 line 449: >> >>> 447: if test "x$TOOLCHAIN_TYPE" = "xclang"; then >>> 448: ASAN_CFLAGS="$ASAN_CFLAGS >>> -fsanitize-address-use-after-return=never" >>> 449: fi >> >> There's