Re: RFR: 8336040: Missing closing anchor element in Docs.gmk

2024-07-16 Thread Jaikiran Pai
On Tue, 16 Jul 2024 14:12:54 GMT, Nizar Benalla wrote: > Can I please have a review for this bug fix to make file used to generate the > OpenJDK documentation. It adds the missing `` tag after `OTHER > SPECIFICATIONS`, this should help remove some HTML warnings in out generated > docs. > > Th

Re: RFR: 8335921: Fix HotSpot VM build without JVMTI

2024-07-16 Thread Vladimir Kozlov
On Wed, 17 Jul 2024 04:52:35 GMT, David Holmes wrote: >> Citing David Holmes from bug report: >> "We provided the ability to leave out certain VM services (JVMTI, GC's other >> than serial, ...) as part of the design of the MinimalVM to support Java SE >> Embedded, along with the Compact Profil

Re: RFR: 8335921: Fix HotSpot VM build without JVMTI

2024-07-16 Thread Vladimir Kozlov
On Wed, 17 Jul 2024 03:37:36 GMT, Vladimir Kozlov wrote: > Citing David Holmes from bug report: > "We provided the ability to leave out certain VM services (JVMTI, GC's other > than serial, ...) as part of the design of the MinimalVM to support Java SE > Embedded, along with the Compact Profile

Re: RFR: 8336091: Fix HTML warnings in the generated HTML files

2024-07-16 Thread David Holmes
On Tue, 16 Jul 2024 14:29:25 GMT, Nizar Benalla wrote: > Can I please have a review for this bug fix? This regex to avoid duplicate > "style" tags in our generated HTML, It can now match it even if the text > contains a newline character. > > Thanks in advance! Not a regex expert but this se

Re: RFR: 8336040: Missing closing anchor element in Docs.gmk

2024-07-16 Thread David Holmes
On Tue, 16 Jul 2024 14:12:54 GMT, Nizar Benalla wrote: > Can I please have a review for this bug fix to make file used to generate the > OpenJDK documentation. It adds the missing `` tag after `OTHER > SPECIFICATIONS`, this should help remove some HTML warnings in out generated > docs. > > Th

Re: RFR: 8335921: Fix HotSpot VM build without JVMTI

2024-07-16 Thread David Holmes
On Wed, 17 Jul 2024 03:37:36 GMT, Vladimir Kozlov wrote: > Citing David Holmes from bug report: > "We provided the ability to leave out certain VM services (JVMTI, GC's other > than serial, ...) as part of the design of the MinimalVM to support Java SE > Embedded, along with the Compact Profile

RFR: 8335921: Fix HotSpot VM build without JVMTI

2024-07-16 Thread Vladimir Kozlov
Citing David Holmes from bug report: "We provided the ability to leave out certain VM services (JVMTI, GC's other than serial, ...) as part of the design of the MinimalVM to support Java SE Embedded, along with the Compact Profiles of JDK 8. This manifested in the source code as a set of INCLUDE

Re: RFR: 8335880: More troubleshooting tips around windows space in path [v3]

2024-07-16 Thread Chen Liang
> Context: https://mail.openjdk.org/pipermail/build-dev/2024-July/045586.html > > People were confused on a few details around fixing windows space names, > including: > 1. setshortname can report confusing error message when the directory is in > use > 2. Many directories can have names set but

Re: RFR: 8335880: More troubleshooting tips around windows space in path [v2]

2024-07-16 Thread Chen Liang
> Context: https://mail.openjdk.org/pipermail/build-dev/2024-July/045586.html > > People were confused on a few details around fixing windows space names, > including: > 1. setshortname can report confusing error message when the directory is in > use > 2. Many directories can have names set but

Re: RFR: 8335880: More troubleshooting tips around windows space in path

2024-07-16 Thread Chen Liang
On Tue, 16 Jul 2024 15:38:13 GMT, Chen Liang wrote: > Context: https://mail.openjdk.org/pipermail/build-dev/2024-July/045586.html > > People were confused on a few details around fixing windows space names, > including: > 1. setshortname can report confusing error message when the directory is

Re: RFR: 8335880: More troubleshooting tips around windows space in path

2024-07-16 Thread SWinxy
On Tue, 16 Jul 2024 20:57:26 GMT, Chen Liang wrote: >> Does `configure` look for a particular short name for them to be? The >> documentation only says "Usually, it assumes those directories have short >> paths." The script didn't automatically detect the short paths for Microsoft >> Visual St

Re: RFR: 8335880: More troubleshooting tips around windows space in path

2024-07-16 Thread Chen Liang
On Tue, 16 Jul 2024 20:46:44 GMT, SWinxy wrote: >> Context: https://mail.openjdk.org/pipermail/build-dev/2024-July/045586.html >> >> People were confused on a few details around fixing windows space names, >> including: >> 1. setshortname can report confusing error message when the directory is

RFR: 8336498: [macos] [build]: install-file macro may run into permission denied error

2024-07-16 Thread Lutz Schmidt
On MacOS, files may have extended attributes attached. These attributes are copied together with the files. To prevent issues during further processing, the extended attributes of the copies must be removed. This action was implemented as solution of an older bug. The solution is incomplete bec

Re: RFR: 8335880: More troubleshooting tips around windows space in path

2024-07-16 Thread SWinxy
On Tue, 16 Jul 2024 15:38:13 GMT, Chen Liang wrote: > Context: https://mail.openjdk.org/pipermail/build-dev/2024-July/045586.html > > People were confused on a few details around fixing windows space names, > including: > 1. setshortname can report confusing error message when the directory is

RFR: 8335880: More troubleshooting tips around windows space in path

2024-07-16 Thread Chen Liang
Context: https://mail.openjdk.org/pipermail/build-dev/2024-July/045586.html People were confused on a few details around fixing windows space names, including: 1. setshortname can report confusing error message when the directory is in use 2. Many directories can have names set but only Microsoft

RFR: 8336091: Fix HTML warnings in the generated HTML files

2024-07-16 Thread Nizar Benalla
Can I please have a review for this bug fix? This regex to avoid duplicate "style" tags in our generated HTML, It can now match it even if the text contains a newline character. Thanks in advance! - Commit messages: - (C) - Improve style attribute regex Changes: https://git.ope

RFR: 8336040: Missing closing anchor element in Docs.gmk

2024-07-16 Thread Nizar Benalla
Can I please have a review for this bug fix to make file used to generate the OpenJDK documentation. It adds the missing `` tag after `OTHER SPECIFICATIONS`, this should help remove some HTML warnings in out generated docs. Thanks in advance. - Commit messages: - (C) - Added clo

Re: How to get the IDE debugger to use the OpenJDK source code instead of the decompiled class files?

2024-07-16 Thread Anil
I don't think that's sufficient. I feel you should also note that the fsutil short names command may work if you log out of the account. I posted details earlier. On Mon, Jul 15, 2024, 11:43 PM Chen Liang wrote: > I think I will just note that the built regular jdk is in images/jdk > instead of

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v11]

2024-07-16 Thread Hamlin Li
On Tue, 16 Jul 2024 10:42:24 GMT, Andrew Haley wrote: > We're only a couple of weeks away from the summit. What would be a long time? OK, then let's wait for it. - PR Comment: https://git.openjdk.org/jdk/pull/18605#issuecomment-2230591233

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v11]

2024-07-16 Thread Andrew Haley
On Tue, 16 Jul 2024 09:48:55 GMT, Andrew Haley wrote: > @theRealAph Thanks for clarification. > > I think there are several different parts involved in the above discussion, > please kindly correct me if I misunderstood. > > 1. package builders. This is about the release of jdk (both src a

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v9]

2024-07-16 Thread Hamlin Li
On Mon, 15 Jul 2024 17:35:59 GMT, Ludovic Henry wrote: >>> > I can't tell what problem we're trying to solve by not simply checking in >>> > the source code, in its preferred form, to the OpenJDK tree. Thhis has >>> > practical advantages to do with traceability and security, and >>> > in-prin

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v11]

2024-07-16 Thread Hamlin Li
On Tue, 16 Jul 2024 09:48:55 GMT, Andrew Haley wrote: >>> Currently, >>> >>> * in [8329816: Add SLEEF version 3.6.1 >>> #19185](https://github.com/openjdk/jdk/pull/19185) it generates the sleef >>> inline headers from sleef 3.6.1, which is tagged in sleef repo. >>> >>> * And with the

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v11]

2024-07-16 Thread Stewart X Addison
On Tue, 16 Jul 2024 08:21:04 GMT, Andrew Haley wrote: > This is starting to sound like we need a policy decision, because we don't > want to re-hash this discussion every time the question comes up, as it > surely will. +1 to this if we don't already have one While I haven't read through eve

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v11]

2024-07-16 Thread Andrew Dinn
On Tue, 9 Jul 2024 12:08:50 GMT, Hamlin Li wrote: >> Hi, >> Can you help to review the patch? >> This pr is based on previous work and discussion in [pr >> 16234](https://github.com/openjdk/jdk/pull/16234), [pr >> 18294](https://github.com/openjdk/jdk/pull/18294). >> * NOTE: This pr depends on

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v11]

2024-07-16 Thread Andrew Haley
On Tue, 16 Jul 2024 08:35:25 GMT, Andrew Haley wrote: >> Hamlin Li has updated the pull request incrementally with one additional >> commit since the last revision: >> >> skip TANH > >> Currently, >> >> * in [8329816: Add SLEEF version 3.6.1 >> #19185](https://github.com/openjdk/jdk/pul

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v11]

2024-07-16 Thread Hamlin Li
On Tue, 16 Jul 2024 08:35:25 GMT, Andrew Haley wrote: >> Hamlin Li has updated the pull request incrementally with one additional >> commit since the last revision: >> >> skip TANH > >> Currently, >> >> * in [8329816: Add SLEEF version 3.6.1 >> #19185](https://github.com/openjdk/jdk/pul

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v11]

2024-07-16 Thread Andrew Haley
On Tue, 9 Jul 2024 12:08:50 GMT, Hamlin Li wrote: >> Hi, >> Can you help to review the patch? >> This pr is based on previous work and discussion in [pr >> 16234](https://github.com/openjdk/jdk/pull/16234), [pr >> 18294](https://github.com/openjdk/jdk/pull/18294). >> * NOTE: This pr depends on

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v11]

2024-07-16 Thread Andrew Haley
On Mon, 15 Jul 2024 21:17:03 GMT, Mikael Vidstedt wrote: > I think the key question is whether we're comfortable relying on/pointing at > an external repository which may or may not be there tomorrow and/or where > tags may change outside of our control. Right. We should adopt best practice, b

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v9]

2024-07-16 Thread Andrew Haley
On Mon, 15 Jul 2024 17:35:59 GMT, Ludovic Henry wrote: > Given the Sleef build system currently uses cmake, we would have two choices > to build the header files as part of the OpenJDK build system I don't think that anyone is proposing to do that, so we can discount it altogether. > However,