Re: RFR: 8338290: Xcode project generator for hotspot [v3]

2024-08-22 Thread Afshin Zafari
On Wed, 21 Aug 2024 14:07:00 GMT, Magnus Ihse Bursie wrote: >> Add a make target to generate an Xcode project file for Hotspot. >> >> This PR is the result of a cooperation between me and @gerard-ziemski. >> Gerard developed the original Xcode generator (as a stand-alone project in >> https:/

Re: RFR: 8338290: Xcode project generator for hotspot

2024-08-21 Thread Afshin Zafari
On Tue, 13 Aug 2024 09:57:51 GMT, Magnus Ihse Bursie wrote: > Add a make target to generate an Xcode project file for Hotspot. > > This PR is the result of a cooperation between me and @gerard-ziemski. Gerard > developed the original Xcode generator (as a stand-alone project in > https://gith

Integrated: 8314438: NMT: Performance benchmarks are needed to have a baseline for comparison of improvements

2023-10-20 Thread Afshin Zafari
On Tue, 5 Sep 2023 07:53:36 GMT, Afshin Zafari wrote: > A new benchmark for measuring the NMT overhead in `summary` and `detail` > modes. > The tests are run using: > > make CONF=debug test TEST="micro:java.vm.runtime.NMTBenchmark" > MICRO="RESULTS_FORMAT=j

Re: RFR: 8314438: NMT: Performance benchmarks are needed to have a baseline for comparison of improvements [v3]

2023-09-26 Thread Afshin Zafari
On Tue, 26 Sep 2023 09:51:32 GMT, Magnus Ihse Bursie wrote: > Should there not be a label to alert NMT folks for reviewing? Thanks for the comment. - PR Comment: https://git.openjdk.org/jdk/pull/15563#issuecomment-1735229316

Re: RFR: 8314438: NMT: Performance benchmarks are needed to have a baseline for comparison of improvements [v3]

2023-09-26 Thread Afshin Zafari
penjdk.org/browse/JDK-8316813) is > created for measuring the virtual memory tracing parts of NMT. Afshin Zafari has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: - Merge branch 'master' into _8314438 - ne

Re: RFR: 8314438: NMT: Performance benchmarks are needed to have a baseline for comparison of improvements [v2]

2023-09-25 Thread Afshin Zafari
On Mon, 25 Sep 2023 07:41:24 GMT, Alan Bateman wrote: >> Afshin Zafari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> new benchmark moved to vm/runtime folder. > > test/micro/org/openjdk/bench/java/

Re: RFR: 8314438: NMT: Performance benchmarks are needed to have a baseline for comparison of improvements [v2]

2023-09-25 Thread Afshin Zafari
penjdk.org/browse/JDK-8316813) is > created for measuring the virtual memory tracing parts of NMT. Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision: new benchmark moved to vm/runtime folder. - Changes: -

Re: RFR: 8314438: NMT: Performance benchmarks are needed to have a baseline for comparison of improvements

2023-09-25 Thread Afshin Zafari
On Wed, 6 Sep 2023 19:56:10 GMT, Gerard Ziemski wrote: > The test will not compile for me unless I add: > > `import java.util.concurrent.TimeUnit;` Sorry, it was removed mistakenly before pushing the code. Now fixed. > You said `The JSON file can be used for visualising the results.` Can you

RFR: 8314438: NMT: Performance benchmarks are needed to have a baseline for comparison of improvements

2023-09-25 Thread Afshin Zafari
A new benchmark for measuring the NMT overhead in `summary` and `detail` modes. The tests are run using: make CONF=debug test TEST="micro:java.util.NMTBenchmark" MICRO="RESULTS_FORMAT=json" The results are written to a JSON file that can be visualized using [JMH Visualizer](https://jmh.moreth

Re: RFR: 8305590: Remove nothrow exception specifications from operator new [v3]

2023-04-26 Thread Afshin Zafari
On Mon, 24 Apr 2023 00:23:18 GMT, Kim Barrett wrote: > I believe this may have missed removing the exception specifier from an > operator new inside AnyObj, allocation.cpp, since gcc 12 and up on my end now > refuses to compile HotSpot with this change. I'll create a cleanup change for > this,

Integrated: 8305590: Remove nothrow exception specifications from operator new

2023-04-23 Thread Afshin Zafari
On Mon, 17 Apr 2023 17:09:44 GMT, Afshin Zafari wrote: > - The `throw()` (i.e., no throw) specifications are removed from the > instances of `operator new` where _do not_ return `nullptr`. > > - The `-fcheck-new` is removed from the gcc compile flags. > > - The `operator

Re: RFR: 8305590: Remove nothrow exception specifications from operator new [v3]

2023-04-21 Thread Afshin Zafari
On Thu, 20 Apr 2023 08:41:58 GMT, Afshin Zafari wrote: >> - The `throw()` (i.e., no throw) specifications are removed from the >> instances of `operator new` where _do not_ return `nullptr`. >> >> - The `-fcheck-new` is removed from the gcc compile flags. >>

Re: RFR: 8305590: Remove nothrow exception specifications from operator new [v2]

2023-04-20 Thread Afshin Zafari
On Thu, 20 Apr 2023 06:58:20 GMT, David Holmes wrote: >> A possible reason for keeping this `operator new` is to force the use of >> null return for oom for this class. >> If it's removed then we have the option of (perhaps unintentionally) using >> the terminating allocator. >> That doesn't se

Re: RFR: 8305590: Remove nothrow exception specifications from operator new [v3]

2023-04-20 Thread Afshin Zafari
On Tue, 18 Apr 2023 18:25:55 GMT, Kim Barrett wrote: >> Afshin Zafari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8305590: Remove nothrow exception specifications from operator new > > s

Re: RFR: 8305590: Remove nothrow exception specifications from operator new [v3]

2023-04-20 Thread Afshin Zafari
> > ### Tests > local: linux-x64 gtest:GrowableArrayCHeap, macosx-aarch64 hotspot:tier1 > mach5: tiers 1-5 Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision: 8305590: Remove nothrow exception specifications from operato

Re: RFR: 8305590: Remove nothrow exception specifications from operator new [v2]

2023-04-20 Thread Afshin Zafari
On Wed, 19 Apr 2023 11:49:49 GMT, David Holmes wrote: >> Afshin Zafari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8305590: Remove nothrow exception specifications from operator new > > s

Re: RFR: 8305590: Remove nothrow exception specifications from operator new [v2]

2023-04-19 Thread Afshin Zafari
On Wed, 19 Apr 2023 11:00:32 GMT, Kim Barrett wrote: >> Afshin Zafari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8305590: Remove nothrow exception specifications from operator new > > src/hotspot/s

Re: RFR: 8305590: Remove nothrow exception specifications from operator new [v2]

2023-04-19 Thread Afshin Zafari
On Tue, 18 Apr 2023 18:59:31 GMT, Kim Barrett wrote: >> src/hotspot/share/runtime/thread.hpp line 203: >> >>> 201: static bool is_JavaThread_protected_by_TLH(const JavaThread* target); >>> 202: >>> 203: void operator delete(void* p); >> >> Should you have removed delete and Thread::alloca

Re: RFR: 8305590: Remove nothrow exception specifications from operator new [v2]

2023-04-19 Thread Afshin Zafari
On Tue, 18 Apr 2023 18:29:13 GMT, Kim Barrett wrote: >> Afshin Zafari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8305590: Remove nothrow exception specifications from operator new > > src/hotspot/sh

Re: RFR: 8305590: Remove nothrow exception specifications from operator new [v2]

2023-04-19 Thread Afshin Zafari
> > ### Tests > local: linux-x64 gtest:GrowableArrayCHeap, macosx-aarch64 hotspot:tier1 > mach5: tiers 1-5 Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision: 8305590: Remove nothrow exception specifications from operato

RFR: 8305590: Remove nothrow exception specifications from operator new

2023-04-18 Thread Afshin Zafari
- The `throw()` (i.e., no throw) specifications are removed from the instances of `operator new` where _do not_ return `nullptr`. - The `-fcheck-new` is removed from the gcc compile flags. - The `operator new` and `operator delete` are deleted from `StackObj`. - The `GrowableArrayCHeap::operato