Integrated: JDK-8313244: NM flags handling in configure process

2023-08-11 Thread Andreas Steiner
On Fri, 4 Aug 2023 09:22:00 GMT, Andreas Steiner wrote: > On AIX we need the -X64 option for NM in the build. The handling is > equivalent to the other used tools flags like AR. > This change will replace the quick fix done in > https://bugs.openjdk.org/browse/JDK-8312466. This

Re: RFR: JDK-8313244: NM flags handling in configure process [v4]

2023-08-09 Thread Andreas Steiner
> On AIX we need the -X64 option for NM in the build. The handling is > equivalent to the other used tools flags like AR. > This change will replace the quick fix done in > https://bugs.openjdk.org/browse/JDK-8312466. Andreas Steiner has updated the pull request incrementa

Re: RFR: JDK-8313244: NM flags handling in configure process [v3]

2023-08-08 Thread Andreas Steiner
On Fri, 4 Aug 2023 14:37:04 GMT, Andreas Steiner wrote: >> On AIX we need the -X64 option for NM in the build. The handling is >> equivalent to the other used tools flags like AR. >> This change will replace the quick fix done in >> https://bugs.openjdk.org/browse/

Re: RFR: JDK-8313244: NM flags handling in configure process [v2]

2023-08-04 Thread Andreas Steiner
On Fri, 4 Aug 2023 12:35:20 GMT, Matthias Baesken wrote: > make/common/NativeCompilation.gmk uses NM too, is there a reason to avoid the > flag there? flags-other.m4 : the comment 'on AIX ...' is just stating the > obvious; maybe it should better mention that without -X64 we only process > 32b

Re: RFR: JDK-8313244: NM flags handling in configure process [v3]

2023-08-04 Thread Andreas Steiner
> On AIX we need the -X64 option for NM in the build. The handling is > equivalent to the other used tools flags like AR. > This change will replace the quick fix done in > https://bugs.openjdk.org/browse/JDK-8312466. Andreas Steiner has updated the pull request incrementa

Re: RFR: JDK-8313244: NM flags handling in configure process [v2]

2023-08-04 Thread Andreas Steiner
On Fri, 4 Aug 2023 09:50:44 GMT, Christoph Langer wrote: >> Andreas Steiner has updated the pull request incrementally with one >> additional commit since the last revision: >> >> remove needless else > > make/autoconf/flags-other.m4 line 96: > >> 94:

Re: RFR: JDK-8313244: NM flags handling in configure process [v2]

2023-08-04 Thread Andreas Steiner
> On AIX we need the -X64 option for NM in the build. The handling is > equivalent to the other used tools flags like AR. > This change will replace the quick fix done in > https://bugs.openjdk.org/browse/JDK-8312466. Andreas Steiner has updated the pull request incrementa

RFR: JDK-8313244: NM flags handling in configure process

2023-08-04 Thread Andreas Steiner
On AIX we need the -X64 option for NM in the build. The handling is equivalent to the other used tools flags like AR. This change will replace the quick fix done in https://bugs.openjdk.org/browse/JDK-8312466. - Commit messages: - JDK-8313244: NM flags handling in configure process

Integrated: JDK-8311938: Add default cups include location for configure on AIX

2023-08-04 Thread Andreas Steiner
On Tue, 1 Aug 2023 07:28:02 GMT, Andreas Steiner wrote: > Add the default include location(/opt/freeware/include/) for cups on AIX. > With this set the additional configure parameter --with-cups-include can be > removed, which was needed on AIX. This pull request has now been i

Re: RFR: JDK-8311938: Add default cups include location for configure on AIX [v4]

2023-08-03 Thread Andreas Steiner
> Add the default include location(/opt/freeware/include/) for cups on AIX. > With this set the additional configure parameter --with-cups-include can be > removed, which was needed on AIX. Andreas Steiner has updated the pull request incrementally with one additional commit since

Re: RFR: JDK-8311938: Add default cups include location for configure on AIX [v3]

2023-08-02 Thread Andreas Steiner
> Add the default include location(/opt/freeware/include/) for cups on AIX. > With this set the additional configure parameter --with-cups-include can be > removed, which was needed on AIX. Andreas Steiner has updated the pull request incrementally with one additional commit since

Re: RFR: JDK-8311938: Add default cups include location for configure on AIX [v2]

2023-08-02 Thread Andreas Steiner
On Tue, 1 Aug 2023 14:37:18 GMT, Christoph Langer wrote: > Currently, if somebody sets both, --with-cups= and --with-cups-include, > with-cups-include gets precedence. The problem is only theoretical The default for with-cups-include on AIX will be set only if --with-cups is not set. See my la

Re: RFR: JDK-8311938: Add default cups include location for configure on AIX

2023-08-01 Thread Andreas Steiner
On Tue, 1 Aug 2023 07:51:58 GMT, Matthias Baesken wrote: >> Add the default include location(/opt/freeware/include/) for cups on AIX. >> With this set the additional configure parameter --with-cups-include can be >> removed, which was needed on AIX. > > Looks reasonable, but you would overwrite

Re: RFR: JDK-8311938: Add default cups include location for configure on AIX [v2]

2023-08-01 Thread Andreas Steiner
> Add the default include location(/opt/freeware/include/) for cups on AIX. > With this set the additional configure parameter --with-cups-include can be > removed, which was needed on AIX. Andreas Steiner has updated the pull request incrementally with one additional commit since

RFR: JDK-8311938: Add default cups include location for configure on AIX

2023-08-01 Thread Andreas Steiner
Add the default include location(/opt/freeware/include/) for cups on AIX. With this set the additional configure parameter --with-cups-include can be removed, which was needed on AIX. - Commit messages: - JDK-8311938: Add default cups include location for configure on AIX Changes:

Integrated: JDK-8312466: /bin/nm usage in AIX makes needs -X64 flag

2023-07-27 Thread Andreas Steiner
On Wed, 26 Jul 2023 07:52:44 GMT, Andreas Steiner wrote: > On AIX the 'nm' needs -X64 option. This pull request has now been integrated. Changeset: 44576a7c Author:Andreas Steiner Committer: Christoph Langer URL: https://git.openjdk.o

Re: RFR: JDK-8312466: /bin/nm usage in AIX makes needs -X64 flag [v2]

2023-07-26 Thread Andreas Steiner
On Wed, 26 Jul 2023 14:18:49 GMT, Matthias Baesken wrote: > > OTOH, this cleanup could be done in another PR. For now, the code as it is > > would be ok, too. > > I agree, let's do the flags / macro adjustment in another issue. Andreas, I > can open one for you if you want. I would prefer to

Re: RFR: JDK-8312466: /bin/nm usage in AIX makes needs -X64 flag

2023-07-26 Thread Andreas Steiner
On Wed, 26 Jul 2023 08:01:29 GMT, Matthias Baesken wrote: > Hi Andreas, thanks for addressing this. Should it be 'needs' instead of > 'need' in the comment you added ? > > Btw did you look at the naming of the mangled symbols we check for > (SetupOperatorNewDeleteCheck) , are those names reall

Re: RFR: JDK-8312466: /bin/nm usage in AIX makes needs -X64 flag [v2]

2023-07-26 Thread Andreas Steiner
> On AIX the 'nm' needs -X64 option. Andreas Steiner has updated the pull request incrementally with one additional commit since the last revision: correction of comment - Changes: - all: https://git.openjdk.org/jdk/pull/15036/files - new: https://git.openjdk

RFR: JDK-8312466: /bin/nm usage in AIX makes needs -X64 flag

2023-07-26 Thread Andreas Steiner
On AIX the 'nm' needs -X64 option. - Commit messages: - JDK-8312466 Changes: https://git.openjdk.org/jdk/pull/15036/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15036&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312466 Stats: 6 lines in 1 file changed: 6 ins;

Integrated: JDK-8311955: c++filt is now ibm-llvm-cxxfilt when using xlc17 / clang on AIX

2023-07-23 Thread Andreas Steiner
On Fri, 21 Jul 2023 11:38:13 GMT, Andreas Steiner wrote: > When using xlc17 to build on AIX , the mentioned tool is > /opt/IBM/openxlC/17.1.1/tools/ibm-llvm-cxxfilt instead of c++filt to check > that global operators new and delete are not present in hotspot objects. This pull reques

RFR: JDK-8311955: c++filt is now ibm-llvm-cxxfilt when using xlc17 / clang on AIX

2023-07-21 Thread Andreas Steiner
When using xlc17 to build on AIX , the mentioned tool is /opt/IBM/openxlC/17.1.1/tools/ibm-llvm-cxxfilt instead of c++filt to check that global operators new and delete are not present in hotspot objects. - Commit messages: - JDK-8311955 Changes: https://git.openjdk.org/jdk/pull/1