Re: RFR: 8174269: Remove COMPAT locale data provider from JDK

2024-02-24 Thread Andrey Turbanov
On Fri, 23 Feb 2024 21:24:10 GMT, Naoto Sato wrote: > This PR intends to remove the legacy `COMPAT` locale data from the JDK. The > `COMPAT` locale data was introduced for applications' migratory purposes > transitioning to `CLDR`. It is becoming a technical debt and now is the time > to remov

Re: RFR: JDK-8320458: Improve structural navigation in API documentation

2023-12-20 Thread Andrey Turbanov
On Mon, 11 Dec 2023 16:36:09 GMT, Hannes Wallnöfer wrote: > This is a rather big change to update the structural navigation in API > documentation generated by JavaDoc. It adds a table of contents for the > current page to module, package, and class documentation, and replaces the > old sub-na

Re: RFR: JDK-8319413: Start of release updates for JDK 23 [v4]

2023-12-02 Thread Andrey Turbanov
On Thu, 30 Nov 2023 23:49:24 GMT, Joe Darcy wrote: >> Time to start making preparations for JDK 23. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Update symbol files to JDK 22 b26. test/langtools/tools/javac/versions/Versio

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v5]

2023-11-22 Thread Andrey Turbanov
On Wed, 15 Nov 2023 18:58:43 GMT, Jonathan Gibbons wrote: >> Please review a patch to add support for Markdown syntax in documentation >> comments, as described in the associated JEP. >> >> Notable features: >> >> * support for `///` documentation comments in `JavaTokenizer` >> * new module `j

Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v3]

2023-11-22 Thread Andrey Turbanov
On Mon, 20 Nov 2023 17:46:53 GMT, Joe Wang wrote: >> Implement the built-in Catalog. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > add a note; fix alignment src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/

Re: RFR: 8296246: Update Unicode Data Files to Version 15.1.0

2023-09-15 Thread Andrey Turbanov
On Wed, 13 Sep 2023 20:15:09 GMT, Naoto Sato wrote: > This PR is to incorporate the latest Unicode 15.1, which was released > yesterday. Besides the usual character data update, an upgraded > implementation of RegEx which reflects the Indic Consonant Break specified in > the latest Unicode Ann

Re: RFR: 8314483: Optionally override copyright header in generated source [v2]

2023-08-24 Thread Andrey Turbanov
On Thu, 24 Aug 2023 17:36:46 GMT, Erik Joelsson wrote: >> In the JDK build we have various build tools that generate source code from >> data files. For most of these tools, the source files are based on template >> files, which already have copyright headers, but for some, the complete >> sou

Re: RFR: 8294982: Implementation of Classfile API [v58]

2023-06-23 Thread Andrey Turbanov
On Wed, 8 Mar 2023 08:50:24 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >> ([JDK-8294957](https://bug

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v9]

2023-06-01 Thread Andrey Turbanov
On Wed, 31 May 2023 15:03:04 GMT, Alexander Zvegintsev wrote: >> Modern Linux systems often come with >> [Wayland](https://wayland.freedesktop.org/) by default. >> This comes with some difficulties, and one of them is the inability to get >> screenshots from the system. >> This is because we n

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v9]

2023-06-01 Thread Andrey Turbanov
On Wed, 31 May 2023 15:03:04 GMT, Alexander Zvegintsev wrote: >> Modern Linux systems often come with >> [Wayland](https://wayland.freedesktop.org/) by default. >> This comes with some difficulties, and one of them is the inability to get >> screenshots from the system. >> This is because we n

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v9]

2023-05-31 Thread Andrey Turbanov
On Wed, 31 May 2023 15:03:04 GMT, Alexander Zvegintsev wrote: >> Modern Linux systems often come with >> [Wayland](https://wayland.freedesktop.org/) by default. >> This comes with some difficulties, and one of them is the inability to get >> screenshots from the system. >> This is because we n

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v9]

2023-05-31 Thread Andrey Turbanov
On Wed, 31 May 2023 15:03:04 GMT, Alexander Zvegintsev wrote: >> Modern Linux systems often come with >> [Wayland](https://wayland.freedesktop.org/) by default. >> This comes with some difficulties, and one of them is the inability to get >> screenshots from the system. >> This is because we n

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v9]

2023-05-31 Thread Andrey Turbanov
On Wed, 31 May 2023 15:03:04 GMT, Alexander Zvegintsev wrote: >> Modern Linux systems often come with >> [Wayland](https://wayland.freedesktop.org/) by default. >> This comes with some difficulties, and one of them is the inability to get >> screenshots from the system. >> This is because we n

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v9]

2023-05-31 Thread Andrey Turbanov
On Wed, 31 May 2023 15:03:04 GMT, Alexander Zvegintsev wrote: >> Modern Linux systems often come with >> [Wayland](https://wayland.freedesktop.org/) by default. >> This comes with some difficulties, and one of them is the inability to get >> screenshots from the system. >> This is because we n

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v9]

2023-05-31 Thread Andrey Turbanov
On Wed, 31 May 2023 15:03:04 GMT, Alexander Zvegintsev wrote: >> Modern Linux systems often come with >> [Wayland](https://wayland.freedesktop.org/) by default. >> This comes with some difficulties, and one of them is the inability to get >> screenshots from the system. >> This is because we n

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v6]

2023-05-25 Thread Andrey Turbanov
On Tue, 23 May 2023 15:15:29 GMT, Alexander Zvegintsev wrote: >> Modern Linux systems often come with >> [Wayland](https://wayland.freedesktop.org/) by default. >> This comes with some difficulties, and one of them is the inability to get >> screenshots from the system. >> This is because we n

Re: RFR: 8306703: JFR: Summary views [v2]

2023-05-24 Thread Andrey Turbanov
On Wed, 24 May 2023 13:46:59 GMT, Erik Gahlin wrote: >> Could I have a review of an enhancement that adds a view command to jfr. >> >> Testing: tier1, tier2 + jdk/jdk/jfr >> >> For the change to work properly when streaming, fix of 8307738 needs to be >> applied. >> >> To simplify the review,

Re: RFR: 8307058: Implementation of Generational ZGC [v6]

2023-05-04 Thread Andrey Turbanov
On Thu, 4 May 2023 11:44:14 GMT, Stefan Karlsson wrote: >> Hi all, >> >> Please review the implementation of Generational ZGC, which can be turned on >> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational >> ZGC is a major rewrite of the non-generational ZGC version tha

Re: RFR: 8304265: Implementation of Foreign Function and Memory API (Third Preview) [v23]

2023-04-19 Thread Andrey Turbanov
On Thu, 13 Apr 2023 06:36:51 GMT, Per Minborg wrote: >> API changes for the FFM API (third preview) >> >> ### Specdiff >> https://cr.openjdk.org/~pminborg/panama/21/v2/specdiff/overview-summary.html >> >> ### Javadoc >> https://cr.openjdk.org/~pminborg/panama/21/v2/javadoc/api/java.base/java/la

Re: RFR: 8304896: Update to use jtreg 7.2

2023-04-18 Thread Andrey Turbanov
On Mon, 17 Apr 2023 14:56:16 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7.2. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the requiredVersion

Re: RFR: 8304896: Update to use jtreg 7.2

2023-04-18 Thread Andrey Turbanov
On Mon, 17 Apr 2023 14:56:16 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7.2. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the requiredVersion

Re: RFR: 8303485: Replacing os.name for operating system customization [v8]

2023-03-27 Thread Andrey Turbanov
On Mon, 27 Mar 2023 16:00:00 GMT, Roger Riggs wrote: >> Improvements to support OS specific customization for JDK internal use: >> - To select values and code; allowing elimination of unused code and values >> - Optionally evaluated by build processes, compilation, or archiving (i.e. >> CDS) >

Re: RFR: 8303485: Replacing os.name for operating system customization [v7]

2023-03-27 Thread Andrey Turbanov
On Mon, 27 Mar 2023 14:19:04 GMT, Daniel Fuchs wrote: >> As I can see it uses deprecated `SecurityManager`, but it's not deprecated >> itself. >> Do I miss something? Or javac generates warning even in such cases? > > https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/sun/sec

Re: RFR: 8303485: Replacing os.name for operating system customization [v7]

2023-03-27 Thread Andrey Turbanov
On Mon, 27 Mar 2023 14:15:59 GMT, Andrey Turbanov wrote: >> `GetPropertyAction::privilegedGetProperty` has been marked deprecated for >> removal because it uses the SecurityManager > > As I can see it uses deprecated `SecurityManager`, but it's not deprecated > its

Re: RFR: 8303485: Replacing os.name for operating system customization [v7]

2023-03-27 Thread Andrey Turbanov
On Mon, 27 Mar 2023 13:26:22 GMT, Daniel Fuchs wrote: >> src/java.base/unix/classes/java/lang/ProcessImpl.java line 97: >> >>> 95: * @throw Error if the requested launch mechanism is not found or >>> valid >>> 96: */ >>> 97: @SuppressWarnings("removal") >> >> What is deprecated f

Re: RFR: 8303485: Replacing os.name for operating system customization [v7]

2023-03-27 Thread Andrey Turbanov
On Fri, 24 Mar 2023 17:06:45 GMT, Roger Riggs wrote: >> Improvements to support OS specific customization for JDK internal use: >> - To select values and code; allowing elimination of unused code and values >> - Optionally evaluated by build processes, compilation, or archiving (i.e. >> CDS) >

Re: RFR: 8303229: JFR: Preserve disk repository after exit [v5]

2023-03-27 Thread Andrey Turbanov
On Thu, 23 Mar 2023 13:49:42 GMT, Erik Gahlin wrote: >> Hi, >> >> Could I have a review of an enhancement that adds the option >> preserve-repository=true/false to -XX:FlightRecorderOptions and jcmd >> JFR.configure. When set to true, chunk files in the repository will not be >> removed by th

Re: RFR: 8304265: Implementation of Foreign Function and Memory API (Third Preview) [v5]

2023-03-22 Thread Andrey Turbanov
On Tue, 21 Mar 2023 09:02:29 GMT, Per Minborg wrote: >> API changes for the FFM API (third preview) >> >> Specdiff: >> https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html >> >> Javadoc: >> https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.ht

Re: RFR: JDK-8304689: Add hidden option to disable external spec page

2023-03-22 Thread Andrey Turbanov
On Tue, 21 Mar 2023 21:08:01 GMT, Jonathan Gibbons wrote: > Please review a change to introduce a hidden option to temporarily disable > the "External Specifications" page while we add `@spec` tags, and until we > have a critical mass of such tags. src/jdk.javadoc/share/classes/jdk/javadoc/int

Re: RFR: JDK-8296149: Start of release updates for JDK 21 [v3]

2022-12-04 Thread Andrey Turbanov
On Sat, 3 Dec 2022 23:10:48 GMT, Joe Darcy wrote: >> Usual start-of-release updates. Symbol updates in initial version reflect >> JDK 20 build 21. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated change

Re: RFR: 8297444: Refactor the javacserver build tool [v2]

2022-11-24 Thread Andrey Turbanov
On Tue, 22 Nov 2022 23:40:30 GMT, Magnus Ihse Bursie wrote: >> Now that the javacserver no longer has any ambitions outside being a >> buildtool customized for the JDK build process, a lot of abstractions and >> generalizations can be removed. >> >> This will allow the actual behavior to be mo

Re: RFR: 8295653: Add a graph of the sealed class hierarchy for marked classes [v4]

2022-10-25 Thread Andrey Turbanov
On Mon, 24 Oct 2022 20:44:08 GMT, Magnus Ihse Bursie wrote: >> It would be possible to mark classes with `@sealedGraph` to indicate that >> the sealed hierarchy should be rendered graphically in the JavaDocs. Classes >> not marked would be unaffected, creating an opt-in approach. >> >> [Here](

Re: RFR: 8292008: Transition the JDK to the common standard of C11

2022-08-30 Thread Andrey Turbanov
On Tue, 30 Aug 2022 09:57:09 GMT, Magnus Ihse Bursie wrote: > This patch will set C11 as the "language level" for C code in the JDK code > base, similar to how we set C++14 for the C++ code. > > At this point, (almost) all our compilers support C11. The "almost" here is > the one exception, Vi

Re: RFR: 8290154: [JVMCI] Implement JVMCI for RISC-V [v4]

2022-07-26 Thread Andrey Turbanov
On Mon, 25 Jul 2022 14:38:26 GMT, Sacha Coppey wrote: >> This patch adds a partial JVMCI implementation for RISC-V, to allow using >> the GraalVM Native Image RISC-V LLVM backend, which does not use JVMCI for >> code emission. >> It creates the jdk.vm.ci.riscv64 and jdk.vm.ci.hotspot.riscv64 pa