Integrated: 8306408: Fix the format of several tables in building.md

2023-05-08 Thread Dingli Zhang
On Wed, 19 Apr 2023 02:49:55 GMT, Dingli Zhang wrote: > Hi all, > > Currently, the format of several tables in building.md looks a little > problematic and will incorrectly display the split line. In contrast, the > corresponding building.html will display the tables corre

Re: RFR: 8306408: Fix the format of several tables in building.md [v4]

2023-05-08 Thread Dingli Zhang
On Thu, 20 Apr 2023 00:23:34 GMT, Dingli Zhang wrote: >> Hi all, >> >> Currently, the format of several tables in building.md looks a little >> problematic and will incorrectly display the split line. In contrast, the >> corresponding building.html wil

Re: RFR: 8306408: Fix the format of several tables in building.md

2023-04-20 Thread Dingli Zhang
On Wed, 19 Apr 2023 18:34:33 GMT, Erik Joelsson wrote: >> I see we have this style of tables already present in building.md, so it >> should be fine. Generating building.html from this does cause a diff to the >> html file, so those still need to go in together. Please find a regenerated >> bu

Re: RFR: 8306408: Fix the format of several tables in building.md [v4]

2023-04-19 Thread Dingli Zhang
and the format of the tables > will display correctly. > > Please take a look and have some reviews. Thanks a lot. Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision: Updated html - Changes: - all: https://git.op

Re: RFR: 8306408: Fix the format of several tables in building.md

2023-04-19 Thread Dingli Zhang
On Wed, 19 Apr 2023 18:34:33 GMT, Erik Joelsson wrote: > > Hi @erikj79 I apologize for a missing change. Could you please run pandoc > > again for me? Thanks for your patience and help! > > Done. Thanks again! - PR Comment: https://git.openjdk.org/jdk/pull/13523#issuecomment-1515

Re: RFR: 8306408: Fix the format of several tables in building.md

2023-04-19 Thread Dingli Zhang
On Wed, 19 Apr 2023 13:08:31 GMT, Erik Joelsson wrote: >> Hi all, >> >> Currently, the format of several tables in building.md looks a little >> problematic and will incorrectly display the split line. In contrast, the >> corresponding building.html will display the tables correctly. >> >> Th

Re: RFR: 8306408: Fix the format of several tables in building.md [v3]

2023-04-19 Thread Dingli Zhang
and the format of the tables > will display correctly. > > Please take a look and have some reviews. Thanks a lot. Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision: Fix table of Operating System Requirements

Re: RFR: 8306408: Fix the format of several tables in building.md

2023-04-19 Thread Dingli Zhang
On Wed, 19 Apr 2023 13:08:31 GMT, Erik Joelsson wrote: > I see we have this style of tables already present in building.md, so it > should be fine. Generating building.html from this does cause a diff to the > html file, so those still need to go in together. Please find a regenerated > buildi

Re: RFR: 8306408: Fix the format of several tables in building.md [v2]

2023-04-19 Thread Dingli Zhang
and the format of the tables > will display correctly. > > Please take a look and have some reviews. Thanks a lot. Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision: Regenerated building.html - Changes: - all: ht

RFR: 8306408: Fix the format of several tables in building.md

2023-04-18 Thread Dingli Zhang
Hi all, Currently, the format of several tables in building.md looks a little problematic and will incorrectly display the split line. In contrast, the corresponding building.html will display the tables correctly. This patch will only change building.md and the format of the tables will displ

Re: RFR: 8295229: Try to verify gtest version [v2]

2022-10-12 Thread Dingli Zhang
On Wed, 12 Oct 2022 14:20:08 GMT, Magnus Ihse Bursie wrote: >> Inspired by the comment >> https://github.com/openjdk/jdk/pull/10503#issuecomment-1275500585 for >> JDK-8294623, I realized we need to do at least some kind of version >> verification of gtest. >> >> Since gtest do not properly de

Integrated: 8295033: hsdis configure error when cross-compiling with --with-binutils-src

2022-10-12 Thread Dingli Zhang
On Mon, 10 Oct 2022 06:32:09 GMT, Dingli Zhang wrote: > I built hsdis with the following parameters from source code of binutils > while cross-compiling: > > --with-hsdis=binutils \ > --with-binutils-src=/home/dingli/jdk-tools/binutils-2.38 > > > But configure will

Re: RFR: 8295033: hsdis configure error when cross-compiling with --with-binutils-src

2022-10-11 Thread Dingli Zhang
On Tue, 11 Oct 2022 12:57:28 GMT, Aleksey Shipilev wrote: >> Ok, we already have an exported value for `$host`, which is >> `$OPENJDK_TARGET_AUTOCONF_NAME`. Also, `$conf_openjdk_target` is used in the >> wrapper configure script. It is probably leaking into the main generated >> autoconf scrip

Re: RFR: 8295033: hsdis configure error when cross-compiling with --with-binutils-src [v4]

2022-10-11 Thread Dingli Zhang
nutils_target="--host=$host" > + fi > fi > binutils_cflags="$binutils_cflags $MACHINE_FLAG $JVM_PICFLAG > $C_O_FLAG_NORM" > > > > In the meantime, I removed some useless code about hsdis-demo because > hsdis-demo.c was removed i

Re: RFR: 8295033: hsdis configure error when cross-compiling with --with-binutils-src [v3]

2022-10-11 Thread Dingli Zhang
nutils_target="--host=$host" > + fi > fi > binutils_cflags="$binutils_cflags $MACHINE_FLAG $JVM_PICFLAG > $C_O_FLAG_NORM" > > > > In the meantime, I removed some useless code about hsdis-demo because > hsdis-demo.c was removed in

Re: RFR: 8295033: hsdis configure error when cross-compiling with --with-binutils-src [v2]

2022-10-11 Thread Dingli Zhang
nutils_target="--host=$host" > + fi > fi > binutils_cflags="$binutils_cflags $MACHINE_FLAG $JVM_PICFLAG > $C_O_FLAG_NORM" > > > > In the meantime, I removed some useless code about hsdis-demo because > hsdis-demo.c was removed in

Re: RFR: 8295033: hsdis configure error when cross-compiling with --with-binutils-src

2022-10-10 Thread Dingli Zhang
On Mon, 10 Oct 2022 12:50:08 GMT, Erik Joelsson wrote: >> I built hsdis with the following parameters from source code of binutils >> while cross-compiling: >> >> --with-hsdis=binutils \ >> --with-binutils-src=/home/dingli/jdk-tools/binutils-2.38 >> >> >> But configure will exit with the foll

RFR: 8295033: hsdis configure error when cross-compiling with --with-binutils-src

2022-10-09 Thread Dingli Zhang
I built hsdis with the following parameters from source code of binutils while cross-compiling: --with-hsdis=binutils \ --with-binutils-src=/home/dingli/jdk-tools/binutils-2.38 But configure will exit with the following error: checking whether we are cross compiling... configure: error: in `/