Is it possible to have the build in github's PR checks section to keep compiling files after an error?

2024-09-06 Thread Gerard Ziemski
hi, Is it possible to have the build in github's PR checks section keep compiling files after an error is encountered? This would help limit number of times a fix and commit is required, for a large changes involving refactoring/renaming changes that touch lots of files. This in turn would lim

Re: RFR: 8338290: Xcode project generator for hotspot

2024-08-21 Thread Gerard Ziemski
On Wed, 14 Aug 2024 13:33:39 GMT, Afshin Zafari wrote: > Thank you for this useful feature. Creating the Xcode project and opening it > work well. Is there any help/doc for building JVM with XCode? I got this > after opening the project in XCode and the first build try: `Command > PhaseScriptE

Re: RFR: 8338290: Xcode project generator for hotspot

2024-08-21 Thread Gerard Ziemski
On Tue, 13 Aug 2024 09:57:51 GMT, Magnus Ihse Bursie wrote: > Add a make target to generate an Xcode project file for Hotspot. > > This PR is the result of a cooperation between me and @gerard-ziemski. Gerard > developed the original Xcode generator (as a stand-alone project

Re: RFR: 8314438: NMT: Performance benchmarks are needed to have a baseline for comparison of improvements

2023-09-25 Thread Gerard Ziemski
On Tue, 5 Sep 2023 07:53:36 GMT, Afshin Zafari wrote: > A new benchmark for measuring the NMT overhead in `summary` and `detail` > modes. > The tests are run using: > > make CONF=debug test TEST="micro:java.util.NMTBenchmark" > MICRO="RESULTS_FORMAT=json" > > The results are written to a JS

Re: RFR: 8308341: JNI_GetCreatedJavaVMs returns a partially initialized JVM [v2]

2023-06-01 Thread Gerard Ziemski
On Wed, 31 May 2023 23:01:54 GMT, David Holmes wrote: >> > You have chosen to use an OS independent mechanism, at the cost of >> > exposing the implementation to the outside world, >by introducing a new >> > stage (needs CSR). >> >> That is not an accurate characterisation of this change. The

Re: RFR: 8308341: JNI_GetCreatedJavaVMs returns a partially initialized JVM [v2]

2023-05-31 Thread Gerard Ziemski
On Tue, 30 May 2023 14:39:21 GMT, Gerard Ziemski wrote: >>> I have one question though: why wouldn't it be enough to move `vm_created = >>> 1` from where we had it before, down to where we now have `vm_created = >>> COMPLETE` ? >> >> Because we n

Re: RFR: 8308341: JNI_GetCreatedJavaVMs returns a partially initialized JVM [v2]

2023-05-30 Thread Gerard Ziemski
On Mon, 29 May 2023 03:13:30 GMT, David Holmes wrote: >> We now track the in-progress and completed states of VM creation and only >> return a VM from JNI_GetCreatedJavaVMs when there is a fully initialized VM. >> >> Testing: >> - new regression test >> - tiers 1-3 (sanity) >> >> Thanks > >

Re: RFR: 8308341: JNI_GetCreatedJavaVMs returns a partially initialized JVM [v2]

2023-05-30 Thread Gerard Ziemski
On Mon, 29 May 2023 02:15:05 GMT, David Holmes wrote: > > I have one question though: why wouldn't it be enough to move `vm_created = > > 1` from where we had it before, down to where we now have `vm_created = > > COMPLETE` ? > > Because we need to prevent two threads from concurrently loading

Re: RFR: 8308341: JNI_GetCreatedJavaVMs returns a partially initialized JVM

2023-05-26 Thread Gerard Ziemski
On Thu, 25 May 2023 05:02:19 GMT, David Holmes wrote: > We now track the in-progress and completed states of VM creation and only > return a VM from JNI_GetCreatedJavaVMs when there is a fully initialized VM. > > Testing: > - new regression test > - tiers 1-3 (sanity) > > Thanks test/hotsp

Re: RFR: 8308341: JNI_GetCreatedJavaVMs returns a partially initialized JVM

2023-05-26 Thread Gerard Ziemski
On Thu, 25 May 2023 05:02:19 GMT, David Holmes wrote: > We now track the in-progress and completed states of VM creation and only > return a VM from JNI_GetCreatedJavaVMs when there is a fully initialized VM. > > Testing: > - new regression test > - tiers 1-3 (sanity) > > Thanks Looks fine