Re: RFR: 8211238: @Deprecated JFR event [v8]

2023-12-04 Thread Markus Grönlund
On Sun, 3 Dec 2023 16:44:28 GMT, Markus Grönlund wrote: >> A question about "level". Is the intention that the value can be anything, >> e.g. some new event next month might use the values "1", "2, "3"? Just >> asking because ordinarily depr

Re: RFR: 8211238: @Deprecated JFR event [v9]

2023-12-04 Thread Markus Grönlund
> Greetings, > > please help review this enhancement to add a JFR event to report runtime > invocations of methods that have been declared deprecated in the JDK. > > Testing: jdk_jfr, CI 1-6, stress testing > > Thanks > Markus Markus Grönlund has updated the pull

Re: RFR: 8211238: @Deprecated JFR event [v8]

2023-12-03 Thread Markus Grönlund
On Sun, 3 Dec 2023 16:33:48 GMT, Alan Bateman wrote: > A question about "level". Is the intention that the value can be anything, > e.g. some new event next month might use the values "1", "2, "3"? Just asking > because ordinarily deprecated vs. terminally deprecated is very specific to > the

Re: RFR: 8211238: @Deprecated JFR event [v8]

2023-12-03 Thread Markus Grönlund
> Greetings, > > please help review this enhancement to add a JFR event to report runtime > invocations of methods that have been declared deprecated in the JDK. > > Testing: jdk_jfr, CI 1-6, stress testing > > Thanks > Markus Markus Grönlund has updated the pull

Re: RFR: 8211238: @Deprecated JFR event [v7]

2023-12-03 Thread Markus Grönlund
> Greetings, > > please help review this enhancement to add a JFR event to report runtime > invocations of methods that have been declared deprecated in the JDK. > > Testing: jdk_jfr, CI 1-6, stress testing > > Thanks > Markus Markus Grönlund has updated the pull

Re: RFR: 8211238: @Deprecated JFR event [v6]

2023-12-03 Thread Markus Grönlund
> Greetings, > > please help review this enhancement to add a JFR event to report runtime > invocations of methods that have been declared deprecated in the JDK. > > Testing: jdk_jfr, CI 1-6, stress testing > > Thanks > Markus Markus Grönlund has updated the pull

Re: RFR: 8211238: @Deprecated JFR event [v5]

2023-12-03 Thread Markus Grönlund
> Greetings, > > please help review this enhancement to add a JFR event to report runtime > invocations of methods that have been declared deprecated in the JDK. > > Testing: jdk_jfr, CI 1-6, stress testing > > Thanks > Markus Markus Grönlund has updated the pull

Re: RFR: 8211238: @Deprecated JFR event [v2]

2023-12-03 Thread Markus Grönlund
On Sun, 3 Dec 2023 10:15:41 GMT, Alan Bateman wrote: >> Markus Grönlund has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Merge branch '8211238' of github.com:mgronlun/jdk into 8211238 >> -

Re: RFR: 8211238: @Deprecated JFR event [v4]

2023-12-03 Thread Markus Grönlund
> Greetings, > > please help review this enhancement to add a JFR event to report runtime > invocations of methods that have been declared deprecated in the JDK. > > Testing: jdk_jfr, CI 1-6, stress testing > > Thanks > Markus Markus Grönlund has updated the pull

Re: RFR: 8211238: @Deprecated JFR event [v3]

2023-12-03 Thread Markus Grönlund
> Greetings, > > please help review this enhancement to add a JFR event to report runtime > invocations of methods that have been declared deprecated in the JDK. > > Testing: jdk_jfr, CI 1-6, stress testing > > Thanks > Markus Markus Grönlund has updated the pull

Re: RFR: 8211238: @Deprecated JFR event [v2]

2023-12-02 Thread Markus Grönlund
> Greetings, > > please help review this enhancement to add a JFR event to report runtime > invocations of methods that have been declared deprecated in the JDK. > > Testing: jdk_jfr, CI 1-6, stress testing > > Thanks > Markus Markus Grönlund has updated the pull

RFR: 8211238: @Deprecated JFR event

2023-12-02 Thread Markus Grönlund
Greetings, please help review this enhancement to add a JFR event to report runtime invocations of methods that have been declared deprecated in the JDK. Testing: jdk_jfr, CI 1-6, stress testing Thanks Markus - Commit messages: - Merge branch 'openjdk:master' into 8211238 - whit

Re: RFR: 8306703: JFR: Summary views [v3]

2023-05-25 Thread Markus Grönlund
On Thu, 25 May 2023 10:34:45 GMT, Erik Gahlin wrote: >> Could I have a review of an enhancement that adds a view command to jfr. >> >> Testing: tier1, tier2 + jdk/jdk/jfr >> >> For the change to work properly when streaming, fix of 8307738 needs to be >> applied. >> >> To simplify the review,

Re: RFR: 8303229: JFR: Preserve disk repository after exit [v8]

2023-03-31 Thread Markus Grönlund
On Fri, 31 Mar 2023 18:56:20 GMT, Erik Gahlin wrote: >> Hi, >> >> Could I have a review of an enhancement that adds the option >> preserve-repository=true/false to -XX:FlightRecorderOptions and jcmd >> JFR.configure. When set to true, chunk files in the repository will not be >> removed by th

Re: RFR: 8298383: JFR: GenerateJfrFiles.java lacks copyright header [v2]

2022-12-08 Thread Markus Grönlund
On Thu, 8 Dec 2022 13:50:14 GMT, Erik Gahlin wrote: >> Could I have a review of a PR that adds missing copyright header to >> GenerateJfrFiles.java >> >> Testing: tier1 >> >> Thanks >> Erik > > Erik Gahlin has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8298175: JFR: Common timestamp for periodic events [v2]

2022-12-07 Thread Markus Grönlund
On Wed, 7 Dec 2022 07:07:13 GMT, Erik Gahlin wrote: >> Could I have review of infrastructure that makes it easier to write periodic >> events with the same timestamp. >> >> Testing: jdk/jdk/jfr + tier1 + tier2 >> >> Thanks >> Erik > > Erik Gahlin has updated the pull request incrementally with