Re: RFR: 8295343: sun/security/pkcs11 tests fail on Linux RHEL 8.6 and newer [v7]

2023-11-21 Thread Valerie Peng
On Tue, 21 Nov 2023 14:47:39 GMT, Matthew Donovan wrote: >> Hello, >> >> In this PR I removed NSS tests from the ProblemList and updated NssTest to >> use Sqlite databases. I also removed code in PKCS11Test.java that falls back >> to NSS libraries installed on the test system. The tests can st

Re: RFR: 8295343: sun/security/pkcs11 tests fail on Linux RHEL 8.6 and newer [v4]

2023-11-20 Thread Valerie Peng
On Tue, 24 Oct 2023 19:58:58 GMT, Matthew Donovan wrote: >> Hello, >> >> In this PR I removed NSS tests from the ProblemList and updated NssTest to >> use Sqlite databases. I also removed code in PKCS11Test.java that falls back >> to NSS libraries installed on the test system. The tests can st

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-05 Thread Valerie Peng
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote: > There are a number of files in the `test` directory that have an incorrect > copyright header, which includes the "classpath" exception text. This patch > removes that text from all test files that I could find it in. I did this > using a

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base [v3]

2023-07-03 Thread Valerie Peng
On Mon, 3 Jul 2023 17:51:10 GMT, Anthony Scarpino wrote: >> Hi, >> >> I need a code review for moving the contents of the jdk.crypto.ec module >> into java.base. This moves the SunEC JCE Provider (Elliptic Curve) into >> java.base. EC has always been separate from the base module/pkg because

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base [v2]

2023-06-29 Thread Valerie Peng
On Mon, 26 Jun 2023 22:52:18 GMT, Anthony Scarpino wrote: >> Hi, >> >> I need a code review for moving the contents of the jdk.crypto.ec module >> into java.base. This moves the SunEC JCE Provider (Elliptic Curve) into >> java.base. EC has always been separate from the base module/pkg becau

Re: RFR: 8290920: sspi_bridge.dll not built if BUILD_CRYPTO is false

2022-07-26 Thread Valerie Peng
On Tue, 26 Jul 2022 18:12:33 GMT, Weijun Wang wrote: > The DLL should be built no matter what `BUILD_CRYPTO` is. Looks good to me. - Marked as reviewed by valeriep (Reviewer). PR: https://git.openjdk.org/jdk/pull/9647