Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v3]

2024-05-13 Thread Weijun Wang
On Mon, 13 May 2024 11:47:38 GMT, Maurizio Cimadamore wrote: >> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting >> the use of JNI in the following ways: >> >> * `System::load` and `System::loadLibrary` are now restricted methods >> * `Runtime::load` and `Runtime::loa

Re: RFR: JDK-8325189: Enable this-escape javac warning in java.base

2024-02-07 Thread Weijun Wang
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote: > After the "this-escape" lint warning was added to javac (JDK-8015831), the > base module was not updated to be able to compile with this warning enabled. > This PR makes the necessary changes to allow the base module to build with > the warni

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base

2023-06-16 Thread Weijun Wang
On Tue, 13 Jun 2023 20:36:28 GMT, Anthony Scarpino wrote: > Hi, > > I need a code review for moving the contents of the jdk.crypto.ec module into > java.base. This moves the SunEC JCE Provider (Elliptic Curve) into > java.base. EC has always been separate from the base module/pkg because of

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v4]

2023-03-17 Thread Weijun Wang
On Fri, 17 Mar 2023 21:49:33 GMT, Weijun Wang wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adjust CF test to read in with UTF-8 to fix failing test > > make/jdk/src/classes

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v4]

2023-03-17 Thread Weijun Wang
On Fri, 17 Mar 2023 20:28:13 GMT, Justin Lu wrote: >> This PR converts Unicode sequences to UTF-8 native in .properties file. >> (Excluding the Unicode space and tab sequence). The conversion was done >> using native2ascii. >> >> In addition, the build logic is adjusted to support reading in t

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-25 Thread Weijun Wang
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-25 Thread Weijun Wang
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v4]

2022-10-01 Thread Weijun Wang
On Fri, 30 Sep 2022 17:38:54 GMT, Phil Race wrote: >> Why do we need to link to a URL? Why not `../../bridge/AccessBridgeCalls.c`? > > This is correct. > AccessBridge.h is published with the include/header files of the JDK and > anyone reading it there can't exactly make use of "../" Thanks @pr

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v4]

2022-09-30 Thread Weijun Wang
On Fri, 30 Sep 2022 04:05:51 GMT, Iris Clark wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> http -> https > > src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.h line > 34: > >> 32: * the follo

Integrated: 8290920: sspi_bridge.dll not built if BUILD_CRYPTO is false

2022-09-27 Thread Weijun Wang
On Tue, 26 Jul 2022 18:12:33 GMT, Weijun Wang wrote: > The DLL should be built no matter what `BUILD_CRYPTO` is. This pull request has now been integrated. Changeset: 5e1e449c Author: Weijun Wang URL: https://git.openjdk.org/jdk/commit/5e1e449c116d44fb77a21ce4cd5187cfc55263f2 St

Re: RFR: 8290920: sspi_bridge.dll not built if BUILD_CRYPTO is false [v2]

2022-07-27 Thread Weijun Wang
> The DLL should be built no matter what `BUILD_CRYPTO` is. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: indentation change - Changes: - all: https://git.openjdk.org/jdk/pull/9647/files - new: ht

RFR: 8290920: sspi_bridge.dll not built if BUILD_CRYPTO is false

2022-07-26 Thread Weijun Wang
The DLL should be built no matter what `BUILD_CRYPTO` is. - Commit messages: - the fix Changes: https://git.openjdk.org/jdk/pull/9647/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9647&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290920 Stats: 25 lines in 1 fil