RE: OpenJDK11 build on macOS with autoconf 2.72 / -std=gnu++11 option

2024-01-08 Thread Baesken, Matthias
Subject: Re: OpenJDK11 build on macOS with autoconf 2.72 / -std=gnu++11 option That looks like a neat solution. /Erik On 1/5/24 07:36, Baesken, Matthias wrote: > Seems there is already an util helper " UTIL_GET_NON_MATCHING_VALUES" . > So should we do something like this (maybe

Re: OpenJDK11 build on macOS with autoconf 2.72 / -std=gnu++11 option

2024-01-05 Thread erik . joelsson
That looks like a neat solution. /Erik On 1/5/24 07:36, Baesken, Matthias wrote: Seems there is already an util helper " UTIL_GET_NON_MATCHING_VALUES" . So should we do something like this (maybe with a few more unwanted -std= settings ? Seems the UTIL_GET_NON_MATCHING_VALUES so far acc

RE: OpenJDK11 build on macOS with autoconf 2.72 / -std=gnu++11 option

2024-01-05 Thread Baesken, Matthias
Seems there is already an util helper " UTIL_GET_NON_MATCHING_VALUES" . So should we do something like this (maybe with a few more unwanted -std= settings ? Seems the UTIL_GET_NON_MATCHING_VALUES so far accepts only fix strings, is that correct ? diff --git a/make/autoconf/toolchain.m

RE: OpenJDK11 build on macOS with autoconf 2.72 / -std=gnu++11 option

2024-01-04 Thread Baesken, Matthias
>> >> It looks like there is code to attempt to deal with that sort of thing in our >> build system. See TOOLCHAIN_POST_DETECTION in make/autoconf/toolchain.m4. >> That >> dates back to JDK 9. However, that only deals with CFLAGS and CXXFLAGS. The >> AC_PROG_CC/CXX feature affects the CC/CXX varia

RE: OpenJDK11 build on macOS with autoconf 2.72 / -std=gnu++11 option

2024-01-04 Thread Baesken, Matthias
Btw. Is there already something at make/autoconf that does similar filtering of unwanted flags ? The mentioned TOOLCHAIN_POST_DETECTION seems just to reset some variables like CXX_CFLAGS to old values , not sure if this is what we want here ? >Hi Erik, I created : > >https://bugs.openjdk.

Re: OpenJDK11 build on macOS with autoconf 2.72 / -std=gnu++11 option

2024-01-04 Thread erik . joelsson
On 1/3/24 13:03, Kim Barrett wrote: On Jan 3, 2024, at 7:16 AM, Baesken, Matthias wrote: Btw. I found this rather recent discussion about reverting the forcing of setting -std=gnu++11 in autoconf : https://urldefense.com/v3/__https://mail.gnu.org/archive/html/bug-autoconf/2023-12/msg0

RE: OpenJDK11 build on macOS with autoconf 2.72 / -std=gnu++11 option

2024-01-04 Thread Baesken, Matthias
>So autoconf forcibly selects a -std= option, possibly overriding either an >explicit option or the compiler's default. Who thought that was a good idea? >There are even comments from the time that question that "feature". > >It looks like there is code to attempt to deal with that sort of thing

Re: OpenJDK11 build on macOS with autoconf 2.72 / -std=gnu++11 option

2024-01-03 Thread Kim Barrett
> On Jan 3, 2024, at 7:16 AM, Baesken, Matthias > wrote: > > Btw. I found this rather recent discussion about reverting the forcing > of setting -std=gnu++11 in autoconf : > > https://urldefense.com/v3/__https://mail.gnu.org/archive/html/bug-autoconf/2023-12/msg00073.html__;!!ACWV5N9M2

RE: OpenJDK11 build on macOS with autoconf 2.72 / -std=gnu++11 option

2024-01-03 Thread Baesken, Matthias
Subject: RE: OpenJDK11 build on macOS with autoconf 2.72 / -std=gnu++11 option >Perhaps this is a clang vs gcc thing in the build system? With "-std=gnu++98" >only being applied for gcc, not for clang? Hi Kim, I saw this only with xcode/clang (after the update to autoconf 2.72)

Re: OpenJDK11 build on macOS with autoconf 2.72 / -std=gnu++11 option

2024-01-03 Thread Julian Waters
> So why is "-std=gnu++11" being used at all? autoconf has a heuristic that automatically checks "For compiler flags required to enable C++11 for the current compiler", and if the check passes, autoconf automatically adds -std=gnu++11 to the CFLAGS. Something is likely (wrongly) tripping this heur

RE: OpenJDK11 build on macOS with autoconf 2.72 / -std=gnu++11 option

2024-01-02 Thread Baesken, Matthias
Barrett Sent: Tuesday, 2 January 2024 22:35 To: Baesken, Matthias Cc: build-dev@openjdk.org; Magnus Ihse Bursie ; Langer, Christoph ; Erik Joelsson Subject: Re: OpenJDK11 build on macOS with autoconf 2.72 / -std=gnu++11 option * PGP Signed by an unknown key > On Jan 2, 2024, at 4:19 AM,

Re: OpenJDK11 build on macOS with autoconf 2.72 / -std=gnu++11 option

2024-01-02 Thread Kim Barrett
> On Jan 2, 2024, at 4:19 AM, Baesken, Matthias > wrote: > > Hi , was anyone seen the following issue ? > After an update from autoconf 2.71 to 2.72 on macOS (x86_6$9 , the > C++ flag detection changed in an unexpected way .It is an OpenJDK11 build > . > Previously with (auto

OpenJDK11 build on macOS with autoconf 2.72 / -std=gnu++11 option

2024-01-02 Thread Baesken, Matthias
Hi , was anyone seen the following issue ? After an update from autoconf 2.71 to 2.72 on macOS (x86_6$9 , the C++ flag detection changed in an unexpected way .It is an OpenJDK11 build . Previously with (autoconf 2.71) we had : checking for /jenkins/workspace/devkit-xcode-13