Re: RFR: 8292911: Add a note about jtreg failure handlers in the testing doc [v3]

2022-08-28 Thread Jaikiran Pai
On Fri, 26 Aug 2022 13:48:54 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change to the testing documentation which >> adds a note about failure handlers in jtreg? This addresses >> https://bugs.openjdk.org/browse/JDK-8292911. >> >> Recently, there have been users who have bee

Re: RFR: 8292911: Add a note about jtreg failure handlers in the testing doc [v3]

2022-08-26 Thread Jonathan Gibbons
On Fri, 26 Aug 2022 13:48:54 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change to the testing documentation which >> adds a note about failure handlers in jtreg? This addresses >> https://bugs.openjdk.org/browse/JDK-8292911. >> >> Recently, there have been users who have bee

Re: RFR: 8292911: Add a note about jtreg failure handlers in the testing doc [v3]

2022-08-26 Thread Erik Joelsson
On Fri, 26 Aug 2022 13:48:54 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change to the testing documentation which >> adds a note about failure handlers in jtreg? This addresses >> https://bugs.openjdk.org/browse/JDK-8292911. >> >> Recently, there have been users who have bee

Re: RFR: 8292911: Add a note about jtreg failure handlers in the testing doc [v3]

2022-08-26 Thread Lance Andersen
On Fri, 26 Aug 2022 13:48:54 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change to the testing documentation which >> adds a note about failure handlers in jtreg? This addresses >> https://bugs.openjdk.org/browse/JDK-8292911. >> >> Recently, there have been users who have bee

Re: RFR: 8292911: Add a note about jtreg failure handlers in the testing doc [v3]

2022-08-26 Thread Jaikiran Pai
> Can I please get a review of this change to the testing documentation which > adds a note about failure handlers in jtreg? This addresses > https://bugs.openjdk.org/browse/JDK-8292911. > > Recently, there have been users who have been prompted for sudo password when > running jtreg tests loca

Re: RFR: 8292911: Add a note about jtreg failure handlers in the testing doc [v2]

2022-08-26 Thread Jaikiran Pai
On Fri, 26 Aug 2022 13:12:19 GMT, Erik Joelsson wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> incorporate review comments > > doc/testing.md line 55: > >> 53: collecting this additional data isn't always necessa

Re: RFR: 8292911: Add a note about jtreg failure handlers in the testing doc

2022-08-26 Thread Jaikiran Pai
On Fri, 26 Aug 2022 13:08:03 GMT, Erik Joelsson wrote: > > > Inside Oracle, if you configure using Jib you should get the same version > > > of pandoc that was used to generate the existing html files. > > > > > > I gave that a try (and verified that it uses the jib installed pandoc), but > >

Re: RFR: 8292911: Add a note about jtreg failure handlers in the testing doc [v2]

2022-08-26 Thread Erik Joelsson
On Fri, 26 Aug 2022 06:07:21 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change to the testing documentation which >> adds a note about failure handlers in jtreg? This addresses >> https://bugs.openjdk.org/browse/JDK-8292911. >> >> Recently, there have been users who have bee

Re: RFR: 8292911: Add a note about jtreg failure handlers in the testing doc

2022-08-26 Thread Erik Joelsson
On Fri, 26 Aug 2022 06:04:14 GMT, Jaikiran Pai wrote: > > Inside Oracle, if you configure using Jib you should get the same version > > of pandoc that was used to generate the existing html files. > > I gave that a try (and verified that it uses the jib installed pandoc), but > it still ends u

Re: RFR: 8292911: Add a note about jtreg failure handlers in the testing doc [v2]

2022-08-25 Thread Jaikiran Pai
On Thu, 25 Aug 2022 13:34:57 GMT, Erik Joelsson wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> incorporate review comments > > doc/testing.md line 53: > >> 51: configured to allow running these commands, then it

Re: RFR: 8292911: Add a note about jtreg failure handlers in the testing doc

2022-08-25 Thread Jaikiran Pai
On Thu, 25 Aug 2022 10:44:32 GMT, Jaikiran Pai wrote: > Can I please get a review of this change to the testing documentation which > adds a note about failure handlers in jtreg? This addresses > https://bugs.openjdk.org/browse/JDK-8292911. > > Recently, there have been users who have been pro

Re: RFR: 8292911: Add a note about jtreg failure handlers in the testing doc [v2]

2022-08-25 Thread Jaikiran Pai
> Can I please get a review of this change to the testing documentation which > adds a note about failure handlers in jtreg? This addresses > https://bugs.openjdk.org/browse/JDK-8292911. > > Recently, there have been users who have been prompted for sudo password when > running jtreg tests loca

Re: RFR: 8292911: Add a note about jtreg failure handlers in the testing doc

2022-08-25 Thread Jaikiran Pai
On Thu, 25 Aug 2022 13:41:52 GMT, Erik Joelsson wrote: > Inside Oracle, if you configure using Jib you should get the same version of > pandoc that was used to generate the existing html files. I gave that a try (and verified that it uses the jib installed pandoc), but it still ends up generat

Re: RFR: 8292911: Add a note about jtreg failure handlers in the testing doc

2022-08-25 Thread Erik Joelsson
On Thu, 25 Aug 2022 10:44:32 GMT, Jaikiran Pai wrote: > Can I please get a review of this change to the testing documentation which > adds a note about failure handlers in jtreg? This addresses > https://bugs.openjdk.org/browse/JDK-8292911. > > Recently, there have been users who have been pro

RFR: 8292911: Add a note about jtreg failure handlers in the testing doc

2022-08-25 Thread Jaikiran Pai
Can I please get a review of this change to the testing documentation which adds a note about failure handlers in jtreg? This addresses https://bugs.openjdk.org/browse/JDK-8292911. Recently, there have been users who have been prompted for sudo password when running jtreg tests locally and thos