On Thu, 8 Sep 2022 13:54:02 GMT, Erik Joelsson wrote:
>> I looked up what kind of dependencies we are passing in through `DEPEND`.
>> None, it turns out. It is not used. So that is not a worry. We might
>> consider removing it. Sending in exceptional dependencies like that is never
>> a good d
On Thu, 8 Sep 2022 13:54:02 GMT, Erik Joelsson wrote:
>> I looked up what kind of dependencies we are passing in through `DEPEND`.
>> None, it turns out. It is not used. So that is not a worry. We might
>> consider removing it. Sending in exceptional dependencies like that is never
>> a good d
On Thu, 8 Sep 2022 09:45:03 GMT, Magnus Ihse Bursie wrote:
>> Actually, this is not an entirely correct description. EXTRA_DEPS points to
>> the `depend` javac plugin itself in buildtools. Once built, this is unlikely
>> to change. Dependency on the API changes themselves happen on a higher
>>
On Thu, 8 Sep 2022 09:40:13 GMT, Magnus Ihse Bursie wrote:
>> To clarify my last post. The Main compile rule has this prereq declaration:
>>
>>
>> $$($1_COMPILE_TARGET): $$($1_SRCS) $$($1_FILELIST) $$($1_DEPENDS) \
>> $$($1_VARDEPS_FILE) $$($1_EXTRA_DEPS) $$($1_JAVAC_SERVER_CONFIG)
>>
On Wed, 7 Sep 2022 16:30:33 GMT, Erik Joelsson wrote:
>>> ... and also that we _must_ include the vardeps file, since any change
>>> there should trigger a complete rebuild.
>>>
>>> The logic here seems correct, but apparently somewhat hard to fully
>>> understand correctly. Maybe a few lines
On Wed, 7 Sep 2022 13:57:45 GMT, Jan Lahoda wrote:
>> ... and also that we *must* include the vardeps file, since any change there
>> should trigger a complete rebuild.
>>
>> The logic here seems correct, but apparently somewhat hard to fully
>> understand correctly. Maybe a few lines of comme
On Tue, 6 Sep 2022 14:33:10 GMT, Magnus Ihse Bursie wrote:
>>> The `Depend` plugin will do a full build if a non-Java file is present in
>>> the list, which I hope should lead to a more reliable recompilation for
>>> some complex changes among the sources.
>>
>> Ah, I had missed that and that'
On Tue, 6 Sep 2022 13:19:48 GMT, Erik Joelsson wrote:
>> Right, I confused `$?` and `$+`. You are of course correct, this is the way
>> to get the changed targets. I had a bit of bad luck when I though about
>> this. 😄 (Theoretically, we could filter out anything that is not in
>> `$1_SRCS` f
On Mon, 5 Sep 2022 19:00:56 GMT, Magnus Ihse Bursie wrote:
>>> I think you really mean `$$($1_SRCS)` here, since the vardeps file is a
>>> build internal file that javac do not and should not care about. While I'm
>>> sure it will ignore it, the code here will be clearer if we don't pass it
>>
On Mon, 5 Sep 2022 16:33:08 GMT, Jan Lahoda wrote:
>> make/common/JavaCompilation.gmk line 455:
>>
>>> 453:$$(call LogWarn, Compiling up to $$(words $$($1_SRCS))
>>> files for $1)
>>> 454:$$(eval $$(call ListPathsSafely, $1_SRCS,
>>> $$($1_FILELIST)))
>>> 455:
On Thu, 1 Sep 2022 18:35:24 GMT, Jan Lahoda wrote:
>> Currently, when doing a small change inside a module that does not affect
>> the API of the module, the build system will skip rebuild of the dependent
>> modules. If there's a change that affects the module's API, the dependent
>> modules
On Mon, 5 Sep 2022 12:19:38 GMT, Magnus Ihse Bursie wrote:
> I think you really mean `$$($1_SRCS)` here, since the vardeps file is a build
> internal file that javac do not and should not care about. While I'm sure it
> will ignore it, the code here will be clearer if we don't pass it around wh
On Thu, 1 Sep 2022 18:35:24 GMT, Jan Lahoda wrote:
>> Currently, when doing a small change inside a module that does not affect
>> the API of the module, the build system will skip rebuild of the dependent
>> modules. If there's a change that affects the module's API, the dependent
>> modules
On Thu, 1 Sep 2022 18:35:24 GMT, Jan Lahoda wrote:
>> Currently, when doing a small change inside a module that does not affect
>> the API of the module, the build system will skip rebuild of the dependent
>> modules. If there's a change that affects the module's API, the dependent
>> modules
On Thu, 1 Sep 2022 18:35:24 GMT, Jan Lahoda wrote:
>> Currently, when doing a small change inside a module that does not affect
>> the API of the module, the build system will skip rebuild of the dependent
>> modules. If there's a change that affects the module's API, the dependent
>> modules
On Thu, 1 Sep 2022 16:48:48 GMT, Erik Joelsson wrote:
> Oh right, ListPathsSafely takes the data to write by reference, not by value
> (as in you supply the name of a variable that contains the data, not the data
> itself). I doubt `?` can be sent into an eval as a variable name, but I may
> b
> Currently, when doing a small change inside a module that does not affect the
> API of the module, the build system will skip rebuild of the dependent
> modules. If there's a change that affects the module's API, the dependent
> modules are recompiled. So far, this seems to work reasonably.
>
17 matches
Mail list logo
