On Thu, 2 Mar 2023 14:29:13 GMT, Adam Sotona wrote:
>> I had the same observation as Maurizio.
>
> I've extracted `StackMapFrameInfo` to the top level and moved
> `VerificationTypeInfo`, however it is still nested.
> Let me know if you think we should really avoid all nested or if info inside
>
On Wed, 1 Mar 2023 23:57:52 GMT, Paul Sandoz wrote:
>> Every case has been considered individually, evaluated on use cases and pros
>> and cons have been weighted. Unified approach across the whole API would be
>> nice, however not so simple and not the highest priority.
>
> I had the same obse
On Wed, 8 Feb 2023 11:00:14 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/classfile/attribute/StackMapTableAttribute.java
>> line 68:
>>
>>> 66: * A simple stack value.
>>> 67: */
>>> 68: public enum SimpleVerificationTypeInfo implements
>>> VerificationType
On Tue, 7 Feb 2023 16:04:07 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - javadoc fixes
>> - obsolete identifiers and unused imports cleanup
>> - TypeAnnotation.TypePathComponent cl
On Wed, 8 Feb 2023 11:19:32 GMT, Maurizio Cimadamore
wrote:
>> Any reference to an official specification of CharacterRangeInfo is
>> appreciated.
>> Thanks.
>
>> Any reference to an official specification of CharacterRangeInfo is
>> appreciated. Thanks.
>
> There's this - which points back t
On Wed, 8 Feb 2023 11:16:14 GMT, Maurizio Cimadamore
wrote:
>> `ofSymbols` is an alternative to `of` when conflicting method parameters.
>> In such case `of` refers to CP entries and `ofSymbols` refer to independent
>> symbols describing the objects, like for example `ClassDesc`,
>> `MethodTyp
On Wed, 8 Feb 2023 07:31:15 GMT, Adam Sotona wrote:
> Any reference to an official specification of CharacterRangeInfo is
> appreciated. Thanks.
There's this - which points back to javac code :-)
https://github.com/jacoco/jacoco/wiki/CharacterRangeTable
-
PR: https://git.openjdk.
On Wed, 8 Feb 2023 11:05:34 GMT, Adam Sotona wrote:
> `ofSymbols` is an alternative to `of` when conflicting method parameters. In
> such case `of` refers to CP entries and `ofSymbols` refer to independent
> symbols describing the objects, like for example `ClassDesc`,
> `MethodTypeDesc`, `Pac
On Tue, 7 Feb 2023 16:07:00 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - javadoc fixes
>> - obsolete identifiers and unused imports cleanup
>> - TypeAnnotation.TypePathComponent cl
On Tue, 7 Feb 2023 16:09:56 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - javadoc fixes
>> - obsolete identifiers and unused imports cleanup
>> - TypeAnnotation.TypePathComponent cl
On Tue, 7 Feb 2023 15:59:04 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - javadoc fixes
>> - obsolete identifiers and unused imports cleanup
>> - TypeAnnotation.TypePathComponent cl
On Tue, 7 Feb 2023 15:26:12 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - javadoc fixes
>> - obsolete identifiers and unused imports cleanup
>> - TypeAnnotation.TypePathComponent cl
On Tue, 7 Feb 2023 15:18:17 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - javadoc fixes
>> - obsolete identifiers and unused imports cleanup
>> - TypeAnnotation.TypePathComponent cl
On Tue, 7 Feb 2023 15:20:15 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - javadoc fixes
>> - obsolete identifiers and unused imports cleanup
>> - TypeAnnotation.TypePathComponent cl
On Mon, 6 Feb 2023 13:29:10 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957))
> will chain to this one.
>
16 matches
Mail list logo
