On Tue, 7 Mar 2023 08:35:34 GMT, Adam Sotona wrote:
>> I am unsure how you might use `BlockCodeBuilder`. If the current signature
>> is not changed then `transformFromHandler` seems reasonable (since its the
>> handler that pushes elements into its given builder).
>>
>> The other `transform` i
On Fri, 3 Mar 2023 15:51:25 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/classfile/instruction/NewObjectInstruction.java
>> line 38:
>>
>>> 36: * of a {@link CodeModel}.
>>> 37: */
>>> 38: public sealed interface NewObjectInstruction extends Instruction
>>
>> Should we
On Thu, 2 Mar 2023 22:05:24 GMT, Paul Sandoz wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> StackMapFrameInfo extracted to top level from StackMapTableAttribute
>
> src/java.base/share/classes/jdk/internal/classfil
On Thu, 2 Mar 2023 23:49:24 GMT, Paul Sandoz wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> StackMapFrameInfo extracted to top level from StackMapTableAttribute
>
> src/java.base/share/classes/jdk/internal/classfil
On Fri, 3 Mar 2023 16:33:49 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/classfile/impl/TransformImpl.java
>> line 63:
>>
>>> 61: private static final Runnable NOTHING = () -> { };
>>> 62:
>>> 63: interface FakeClassTransform extends ClassTransform {
>>
>> Renam
On Mon, 6 Mar 2023 17:45:27 GMT, Paul Sandoz wrote:
>> I see what you mean. `transforming` was selected to represent the
>> continuation of the code building process, similar to `trying` and
>> `catching`. While `transform` may imply that the actual code builder gets
>> transformed into someth
On Mon, 6 Mar 2023 17:34:35 GMT, Adam Sotona wrote:
>> The use-case seems fine to me (and that it only makes sense for building
>> code). I still think it's a "transform", but with a different source. Subtly
>> changing the name makes it seem different and fundamentally it is not
>> AFAICT. If
On Mon, 6 Mar 2023 17:15:25 GMT, Paul Sandoz wrote:
>> The `CodeBuilder::transforming` solves a bit different use cases than all
>> the other transform.
>> It is designed to be able to use code transformations on a code building
>> handler within a single pass.
>> Main reason is support of feat
On Thu, 2 Mar 2023 19:56:08 GMT, Paul Sandoz wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> StackMapFrameInfo extracted to top level from StackMapTableAttribute
>
> src/java.base/share/classes/jdk/internal/classfil
On Mon, 6 Mar 2023 17:02:46 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/classfile/CodeBuilder.java line 165:
>>
>>> 163: * @return this builder
>>> 164: */
>>> 165: default CodeBuilder transforming(CodeTransform transform,
>>> Consumer handler) {
>>
>> The
On Thu, 2 Mar 2023 23:28:23 GMT, Paul Sandoz wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> StackMapFrameInfo extracted to top level from StackMapTableAttribute
>
> src/java.base/share/classes/jdk/internal/classfil
On Fri, 3 Mar 2023 00:57:35 GMT, Paul Sandoz wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> StackMapFrameInfo extracted to top level from StackMapTableAttribute
>
> src/java.base/share/classes/jdk/internal/classfil
On Fri, 3 Mar 2023 15:50:33 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/classfile/instruction/NewMultiArrayInstruction.java
>> line 60:
>>
>>> 58: static NewMultiArrayInstruction of(ClassEntry arrayTypeEntry,
>>> 59:int dimensi
On Thu, 2 Mar 2023 20:54:39 GMT, Paul Sandoz wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> StackMapFrameInfo extracted to top level from StackMapTableAttribute
>
> src/java.base/share/classes/jdk/internal/classfil
On Thu, 2 Mar 2023 20:37:37 GMT, Paul Sandoz wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> StackMapFrameInfo extracted to top level from StackMapTableAttribute
>
> src/java.base/share/classes/jdk/internal/classfil
On Fri, 3 Mar 2023 14:53:19 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/classfile/instruction/CharacterRange.java
>> line 42:
>>
>>> 40: * the setting of the {@link Classfile.Option#processDebug(boolean)}
>>> option.
>>> 41: */
>>> 42: public sealed interface Characte
On Thu, 2 Mar 2023 19:31:50 GMT, Paul Sandoz wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> StackMapFrameInfo extracted to top level from StackMapTableAttribute
>
> src/java.base/share/classes/jdk/internal/classfil
On Thu, 2 Mar 2023 19:27:58 GMT, Paul Sandoz wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> StackMapFrameInfo extracted to top level from StackMapTableAttribute
>
> src/java.base/share/classes/jdk/internal/classfil
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957))
> will chain to this one.
>
37 matches
Mail list logo
