Re: RFR: 8300111: Add rpath for common lib locations for jpackageapplauncher

2023-01-23 Thread Erik Joelsson
On Tue, 10 Jan 2023 09:57:19 GMT, David wrote: > This patch adds the `-headerpad_max_install_names` linker argument to the > build of the `jpackageapplauncher` binary (osx only) > > Adding this argument allows the user to use the `install_name_tool` to add > search paths for the dynamic linker

Re: RFR: 8300111: Add rpath for common lib locations for jpackageapplauncher

2023-01-23 Thread Magnus Ihse Bursie
On Tue, 10 Jan 2023 09:57:19 GMT, David wrote: > This patch adds the `-headerpad_max_install_names` linker argument to the > build of the `jpackageapplauncher` binary (osx only) > > Adding this argument allows the user to use the `install_name_tool` to add > search paths for the dynamic linker

Re: RFR: 8300111: Add rpath for common lib locations for jpackageapplauncher

2023-01-14 Thread David
On Fri, 13 Jan 2023 22:36:24 GMT, Alexander Matveev wrote: >>> Hi David, Thank you for your contribution! >>> >>> I updated the title of the JBS bug issue to match this PR (matching titles >>> is a requirement, and the PR had a more descriptive title). >>> >>> The change itself look sane to m

Re: RFR: 8300111: Add rpath for common lib locations for jpackageapplauncher

2023-01-13 Thread Alexander Matveev
On Fri, 13 Jan 2023 13:34:08 GMT, David wrote: >> This patch adds the `-headerpad_max_install_names` linker argument to the >> build of the `jpackageapplauncher` binary (osx only) >> >> Adding this argument allows the user to use the `install_name_tool` to add >> search paths for the dynamic l

Re: RFR: 8300111: Add rpath for common lib locations for jpackageapplauncher

2023-01-13 Thread Alexander Matveev
On Tue, 10 Jan 2023 09:57:19 GMT, David wrote: > This patch adds the `-headerpad_max_install_names` linker argument to the > build of the `jpackageapplauncher` binary (osx only) > > Adding this argument allows the user to use the `install_name_tool` to add > search paths for the dynamic linker

Re: RFR: 8300111: Add rpath for common lib locations for jpackageapplauncher

2023-01-13 Thread Alexey Semenyuk
On Tue, 10 Jan 2023 09:57:19 GMT, David wrote: > This patch adds the `-headerpad_max_install_names` linker argument to the > build of the `jpackageapplauncher` binary (osx only) > > Adding this argument allows the user to use the `install_name_tool` to add > search paths for the dynamic linker

Re: RFR: 8300111: Add rpath for common lib locations for jpackageapplauncher

2023-01-13 Thread Magnus Ihse Bursie
On Tue, 10 Jan 2023 09:57:19 GMT, David wrote: > This patch adds the `-headerpad_max_install_names` linker argument to the > build of the `jpackageapplauncher` binary (osx only) > > Adding this argument allows the user to use the `install_name_tool` to add > search paths for the dynamic linker

Re: RFR: 8300111: Add rpath for common lib locations for jpackageapplauncher

2023-01-13 Thread David
On Tue, 10 Jan 2023 09:57:19 GMT, David wrote: > This patch adds the `-headerpad_max_install_names` linker argument to the > build of the `jpackageapplauncher` binary (osx only) > > Adding this argument allows the user to use the `install_name_tool` to add > search paths for the dynamic linker

Re: RFR: 8300111: Add rpath for common lib locations for jpackageapplauncher

2023-01-13 Thread Magnus Ihse Bursie
On Tue, 10 Jan 2023 09:57:19 GMT, David wrote: > This patch adds the `-headerpad_max_install_names` linker argument to the > build of the `jpackageapplauncher` binary (osx only) > > Adding this argument allows the user to use the `install_name_tool` to add > search paths for the dynamic linker

Re: RFR: 8300111: Add rpath for common lib locations for jpackageapplauncher

2023-01-13 Thread David
On Tue, 10 Jan 2023 22:59:20 GMT, Alexander Matveev wrote: > What additional paths except "@executable_path/../Frameworks/" your > application requires? If you just need @executable_path/../Frameworks/, then > I think we should just add this to rpath permanently, instead of using > -headerpad

Re: RFR: 8300111: Add rpath for common lib locations for jpackageapplauncher

2023-01-13 Thread Alexander Matveev
On Tue, 10 Jan 2023 09:57:19 GMT, David wrote: > This patch adds the `-headerpad_max_install_names` linker argument to the > build of the `jpackageapplauncher` binary (osx only) > > Adding this argument allows the user to use the `install_name_tool` to add > search paths for the dynamic linker

RFR: 8300111: Add rpath for common lib locations for jpackageapplauncher

2023-01-13 Thread David
This patch adds the `-headerpad_max_install_names` linker argument to the build of the `jpackageapplauncher` binary (osx only) Adding this argument allows the user to use the `install_name_tool` to add search paths for the dynamic linker to the launcher binary. This is required for certain use