Re: RFR: 8300806: Update googletest to v1.13.0 [v4]

2023-01-25 Thread Mikael Vidstedt
On Wed, 25 Jan 2023 18:19:44 GMT, Erik Joelsson wrote: >> Mikael Vidstedt has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update building docs to reflect new minimum gtest requirement > > Marked as reviewed by erikj (Reviewer). Thank yo

Re: RFR: 8300806: Update googletest to v1.13.0 [v4]

2023-01-25 Thread Erik Joelsson
On Mon, 23 Jan 2023 20:47:32 GMT, Mikael Vidstedt wrote: >> Please review this PR which updates the required version of googletest to >> v1.13.0. >> >> It’s been (quite) a while since we upgraded the version of googletest used >> to run the hotspot unit tests (test/hotspot/gtest). The current

Re: RFR: 8300806: Update googletest to v1.13.0 [v2]

2023-01-23 Thread Mikael Vidstedt
On Mon, 23 Jan 2023 14:03:53 GMT, Magnus Ihse Bursie wrote: >> Mikael Vidstedt has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update doc/building.html > > make/autoconf/lib-tests.m4 line 63: > >> 61: # Verify that the version i

Re: RFR: 8300806: Update googletest to v1.13.0 [v4]

2023-01-23 Thread Mikael Vidstedt
> Please review this PR which updates the required version of googletest to > v1.13.0. > > It’s been (quite) a while since we upgraded the version of googletest used to > run the hotspot unit tests (test/hotspot/gtest). The current version (1.8.1) > is from 2018 and there is build issue with Xc

Re: RFR: 8300806: Update googletest to v1.13.0 [v3]

2023-01-23 Thread Mikael Vidstedt
> Please review this PR which updates the required version of googletest to > v1.13.0. > > It’s been (quite) a while since we upgraded the version of googletest used to > run the hotspot unit tests (test/hotspot/gtest). The current version (1.8.1) > is from 2018 and there is build issue with Xc

Re: RFR: 8300806: Update googletest to v1.13.0 [v2]

2023-01-23 Thread Erik Joelsson
On Sat, 21 Jan 2023 00:09:18 GMT, Mikael Vidstedt wrote: >> Please review this PR which updates the required version of googletest to >> v1.13.0. >> >> It’s been (quite) a while since we upgraded the version of googletest used >> to run the hotspot unit tests (test/hotspot/gtest). The current

Re: RFR: 8300806: Update googletest to v1.13.0 [v2]

2023-01-23 Thread Magnus Ihse Bursie
On Sat, 21 Jan 2023 00:09:18 GMT, Mikael Vidstedt wrote: >> Please review this PR which updates the required version of googletest to >> v1.13.0. >> >> It’s been (quite) a while since we upgraded the version of googletest used >> to run the hotspot unit tests (test/hotspot/gtest). The current

Re: RFR: 8300806: Update googletest to v1.13.0 [v2]

2023-01-23 Thread Magnus Ihse Bursie
On Sat, 21 Jan 2023 00:09:18 GMT, Mikael Vidstedt wrote: >> Please review this PR which updates the required version of googletest to >> v1.13.0. >> >> It’s been (quite) a while since we upgraded the version of googletest used >> to run the hotspot unit tests (test/hotspot/gtest). The current

Re: RFR: 8300806: Update googletest to v1.13.0 [v2]

2023-01-20 Thread Mikael Vidstedt
> Please review this PR which updates the required version of googletest to > v1.13.0. > > It’s been (quite) a while since we upgraded the version of googletest used to > run the hotspot unit tests (test/hotspot/gtest). The current version (1.8.1) > is from 2018 and there is build issue with Xc

Re: RFR: 8300806: Update googletest to v1.13.0 [v2]

2023-01-20 Thread Mikael Vidstedt
On Fri, 20 Jan 2023 23:56:05 GMT, Erik Joelsson wrote: >> Mikael Vidstedt has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update doc/building.html > > doc/building.md line 873: > >> 871: >> 872: * by downloading and unpacking the sour

Re: RFR: 8300806: Update googletest to v1.13.0

2023-01-20 Thread Erik Joelsson
On Fri, 20 Jan 2023 22:24:32 GMT, Mikael Vidstedt wrote: > Please review this PR which updates the required version of googletest to > v1.13.0. > > It’s been (quite) a while since we upgraded the version of googletest used to > run the hotspot unit tests (test/hotspot/gtest). The current versi

RFR: 8300806: Update googletest to v1.13.0

2023-01-20 Thread Mikael Vidstedt
Please review this PR which updates the required version of googletest to v1.13.0. It’s been (quite) a while since we upgraded the version of googletest used to run the hotspot unit tests (test/hotspot/gtest). The current version (1.8.1) is from 2018 and there is build issue with Xcode 14.x whi