Re: RFR: 8301854: C4819 warnings were reported in libfreetype on Windows

2023-02-08 Thread Yasumasa Suenaga
On Mon, 6 Feb 2023 12:34:36 GMT, Yasumasa Suenaga wrote: > This is subtask of https://github.com/openjdk/jdk/pull/12427 . > > I have seen C4819 warning in libfreetype files on Windows (CP932: Japanese > locale) > > > d:\github-forked\jdk\src\java.desktop\share\native\libfreetype\src\autofit\a

Re: RFR: 8301854: C4819 warnings were reported in libfreetype on Windows

2023-02-07 Thread Magnus Ihse Bursie
On Mon, 6 Feb 2023 12:34:36 GMT, Yasumasa Suenaga wrote: > This is subtask of https://github.com/openjdk/jdk/pull/12427 . > > I have seen C4819 warning in libfreetype files on Windows (CP932: Japanese > locale) > > > d:\github-forked\jdk\src\java.desktop\share\native\libfreetype\src\autofit\a

Re: RFR: 8301854: C4819 warnings were reported in libfreetype on Windows

2023-02-07 Thread Magnus Ihse Bursie
On Mon, 6 Feb 2023 12:34:36 GMT, Yasumasa Suenaga wrote: > This is subtask of https://github.com/openjdk/jdk/pull/12427 . > > I have seen C4819 warning in libfreetype files on Windows (CP932: Japanese > locale) > > > d:\github-forked\jdk\src\java.desktop\share\native\libfreetype\src\autofit\a

Re: RFR: 8301854: C4819 warnings were reported in libfreetype on Windows

2023-02-07 Thread Magnus Ihse Bursie
On Tue, 7 Feb 2023 01:12:06 GMT, Phil Race wrote: > I grep'ed (with `-i`) in `doc` directory with `LANG`, `utf`, `locale`, but I > could not find out them. I guess locale of build environment is not mentioned > clearly. Is it correct? Yes, it is unfortunately not documented. :-( There is an op

Re: RFR: 8301854: C4819 warnings were reported in libfreetype on Windows

2023-02-06 Thread Phil Race
On Tue, 7 Feb 2023 02:46:10 GMT, Yasumasa Suenaga wrote: > > but "en_US-iso-8859-1" (eg) definitely should work, because that or some > > close equivalent (windows cp1252 or maybe 1250) are what we've considered > > as "must work" (SFAIK) > > According to Wikipedia article of > [CP1250](https

Re: RFR: 8301854: C4819 warnings were reported in libfreetype on Windows

2023-02-06 Thread Yasumasa Suenaga
On Tue, 7 Feb 2023 01:12:06 GMT, Phil Race wrote: > but "en_US-iso-8859-1" (eg) definitely should work, because that or some > close equivalent (windows cp1252 or maybe 1250) are what we've considered as > "must work" (SFAIK) According to Wikipedia article of [CP1250](https://en.wikipedia.org

Re: RFR: 8301854: C4819 warnings were reported in libfreetype on Windows

2023-02-06 Thread Phil Race
On Tue, 7 Feb 2023 00:01:56 GMT, Yasumasa Suenaga wrote: > I grep'ed (with `-i`) in `doc` directory with `LANG`, `utf`, `locale`, but I > could not find out them. I guess locale of build environment is not mentioned > clearly. Is it correct? > > I agree with you to use English locale (e.g. `LA

Re: RFR: 8301854: C4819 warnings were reported in libfreetype on Windows

2023-02-06 Thread Yasumasa Suenaga
On Mon, 6 Feb 2023 12:34:36 GMT, Yasumasa Suenaga wrote: > This is subtask of https://github.com/openjdk/jdk/pull/12427 . > > I have seen C4819 warning in libfreetype files on Windows (CP932: Japanese > locale) > > > d:\github-forked\jdk\src\java.desktop\share\native\libfreetype\src\autofit\a

Re: RFR: 8301854: C4819 warnings were reported in libfreetype on Windows

2023-02-06 Thread Phil Race
On Mon, 6 Feb 2023 12:34:36 GMT, Yasumasa Suenaga wrote: > This is subtask of https://github.com/openjdk/jdk/pull/12427 . > > I have seen C4819 warning in libfreetype files on Windows (CP932: Japanese > locale) > > > d:\github-forked\jdk\src\java.desktop\share\native\libfreetype\src\autofit\a

Re: RFR: 8301854: C4819 warnings were reported in libfreetype on Windows

2023-02-06 Thread Magnus Ihse Bursie
On Mon, 6 Feb 2023 12:34:36 GMT, Yasumasa Suenaga wrote: > This is subtask of https://github.com/openjdk/jdk/pull/12427 . > > I have seen C4819 warning in libfreetype files on Windows (CP932: Japanese > locale) > > > d:\github-forked\jdk\src\java.desktop\share\native\libfreetype\src\autofit\a

RFR: 8301854: C4819 warnings were reported in libfreetype on Windows

2023-02-06 Thread Yasumasa Suenaga
This is subtask of https://github.com/openjdk/jdk/pull/12427 . I have seen C4819 warning in libfreetype files on Windows (CP932: Japanese locale) d:\github-forked\jdk\src\java.desktop\share\native\libfreetype\src\autofit\afscript.h(1): warning C4819: ファイルは、現在のコード ページ (932) で表示できない文字を含んでいます。データ