Re: RFR: 8305089: [AIX] Implement missing socket options on AIX [v2]

2023-03-30 Thread Varada M
On Thu, 30 Mar 2023 12:41:26 GMT, Erik Joelsson wrote: >> Please update the copyright year on this file to `2016, 2023, ` > > AIX should be covered by `LIBS_unix := -ljava` as long as that's the only lib > it needs. @erikj79 @jaikiran I do think `LIBS_unix := -ljava` is the library AIX needs.

Re: RFR: 8305089: [AIX] Implement missing socket options on AIX [v2]

2023-03-30 Thread Varada M
On Thu, 30 Mar 2023 11:55:09 GMT, Jaikiran Pai wrote: >> Varada M has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update to copyright year > > src/jdk.net/aix/classes/jdk/net/AIXSocketOptions.java line 38: > >> 36: class AIXSocketOption

Re: RFR: 8305089: [AIX] Implement missing socket options on AIX [v2]

2023-03-30 Thread Varada M
On Thu, 30 Mar 2023 11:49:24 GMT, Jaikiran Pai wrote: >> make/modules/jdk.net/Lib.gmk line 30: >> >>> 28: >>> >>> 29: >>> 30: ifeq ($(call isTargetOs, linux macosx windows aix), true) >> >> Hello Varada, I'm not

Re: RFR: 8305089: [AIX] Implement missing socket options on AIX [v2]

2023-03-30 Thread Varada M
> Breaking this into two parts : > > 1. Implementing socket options for AIX > 2. DontFragmentTest failure > > - Implementing socket options for AIX : > > Unlike the linux, windows and macOS, AIX uses the default implementation for > socket options such as ipDontFragmentSupported(), > keepAl

Re: RFR: 8305089: [AIX] Implement missing socket options on AIX

2023-03-30 Thread Erik Joelsson
On Thu, 30 Mar 2023 06:39:57 GMT, Varada M wrote: > Breaking this into two parts : > > 1. Implementing socket options for AIX > 2. DontFragmentTest failure > > - Implementing socket options for AIX : > > Unlike the linux, windows and macOS, AIX uses the default implementation for > socket

Re: RFR: 8305089: [AIX] Implement missing socket options on AIX

2023-03-30 Thread Erik Joelsson
On Thu, 30 Mar 2023 11:49:24 GMT, Jaikiran Pai wrote: >> make/modules/jdk.net/Lib.gmk line 30: >> >>> 28: >>> >>> 29: >>> 30: ifeq ($(call isTargetOs, linux macosx windows aix), true) >> >> Hello Varada, I'm not

Re: RFR: 8305089: [AIX] Implement missing socket options on AIX

2023-03-30 Thread Erik Joelsson
On Thu, 30 Mar 2023 06:39:57 GMT, Varada M wrote: > Breaking this into two parts : > > 1. Implementing socket options for AIX > 2. DontFragmentTest failure > > - Implementing socket options for AIX : > > Unlike the linux, windows and macOS, AIX uses the default implementation for > socket

Re: RFR: 8305089: [AIX] Implement missing socket options on AIX

2023-03-30 Thread Jaikiran Pai
On Thu, 30 Mar 2023 06:39:57 GMT, Varada M wrote: > Breaking this into two parts : > > 1. Implementing socket options for AIX > 2. DontFragmentTest failure > > - Implementing socket options for AIX : > > Unlike the linux, windows and macOS, AIX uses the default implementation for > socket

Re: RFR: 8305089: [AIX] Implement missing socket options on AIX

2023-03-30 Thread Jaikiran Pai
On Thu, 30 Mar 2023 06:39:57 GMT, Varada M wrote: > Breaking this into two parts : > > 1. Implementing socket options for AIX > 2. DontFragmentTest failure > > - Implementing socket options for AIX : > > Unlike the linux, windows and macOS, AIX uses the default implementation for > socket

Re: RFR: 8305089: [AIX] Implement missing socket options on AIX

2023-03-30 Thread Jaikiran Pai
On Thu, 30 Mar 2023 11:47:50 GMT, Jaikiran Pai wrote: >> Breaking this into two parts : >> >> 1. Implementing socket options for AIX >> 2. DontFragmentTest failure >> >> - Implementing socket options for AIX : >> >> Unlike the linux, windows and macOS, AIX uses the default implementation fo

RFR: 8305089: [AIX] Implement missing socket options on AIX

2023-03-29 Thread Varada M
Breaking this into two parts : 1. Implementing socket options for AIX 2. DontFragmentTest failure - Implementing socket options for AIX : Unlike the linux, windows and macOS, AIX uses the default implementation for socket options such as ipDontFragmentSupported(), keepAliveOptionsSupported()