Re: RFR: 8305089: Implement missing socket options on AIX [v2]

2023-04-05 Thread Varada M
On Tue, 4 Apr 2023 17:48:18 GMT, Vyom Tewari wrote: >> Varada M has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update to copyright year > > Looks OK to me, the native code is same as Linux code with only difference is > the socket opti

Re: RFR: 8305089: Implement missing socket options on AIX [v2]

2023-04-04 Thread Vyom Tewari
On Thu, 30 Mar 2023 16:05:08 GMT, Varada M wrote: >> Breaking this into two parts : >> >> 1. Implementing socket options for AIX >> 2. DontFragmentTest failure >> >> - Implementing socket options for AIX : >> >> Unlike the linux, windows and macOS, AIX uses the default implementation for >

Re: RFR: 8305089: Implement missing socket options on AIX [v2]

2023-04-03 Thread Jaikiran Pai
On Thu, 30 Mar 2023 16:05:08 GMT, Varada M wrote: >> Breaking this into two parts : >> >> 1. Implementing socket options for AIX >> 2. DontFragmentTest failure >> >> - Implementing socket options for AIX : >> >> Unlike the linux, windows and macOS, AIX uses the default implementation for >

Re: RFR: 8305089: Implement missing socket options on AIX [v2]

2023-03-31 Thread Varada M
On Thu, 30 Mar 2023 16:05:08 GMT, Varada M wrote: >> Breaking this into two parts : >> >> 1. Implementing socket options for AIX >> 2. DontFragmentTest failure >> >> - Implementing socket options for AIX : >> >> Unlike the linux, windows and macOS, AIX uses the default implementation for >

Re: RFR: 8305089: Implement missing socket options on AIX [v2]

2023-03-31 Thread Varada M
On Fri, 31 Mar 2023 01:19:05 GMT, Jaikiran Pai wrote: >> `newInstance("jdk.net.AIXSocketOptions")` will try to invoke the default >> constructor `AIXSocketOptions() {}`. When we make it as private constructor >> PlatformSocketOptions instance will try to find jdk.net.AIXSocketOptions and >> w

Re: RFR: 8305089: Implement missing socket options on AIX [v2]

2023-03-30 Thread Jaikiran Pai
On Thu, 30 Mar 2023 16:42:45 GMT, Varada M wrote: >> src/jdk.net/aix/classes/jdk/net/AIXSocketOptions.java line 38: >> >>> 36: class AIXSocketOptions extends PlatformSocketOptions { >>> 37: >>> 38: public AIXSocketOptions() { >> >> It would be good to make this package private constructor