Re: RFR: 8305089: Implement missing socket options on AIX [v4]

2023-04-14 Thread Vyom Tewari
On Fri, 14 Apr 2023 07:59:49 GMT, Varada M wrote: >> Breaking this into two parts : >> >> 1. Implementing socket options for AIX >> 2. DontFragmentTest failure >> >> - Implementing socket options for AIX : >> >> Unlike the linux, windows and macOS, AIX uses the default implementation for >

Re: RFR: 8305089: Implement missing socket options on AIX [v4]

2023-04-14 Thread Varada M
On Fri, 14 Apr 2023 12:13:39 GMT, Daniel Fuchs wrote: >> Varada M has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains six commits: >> >> - Merge branch 'master' into aix_socket_options >> - Updated copyright year >> - Update to cop

Re: RFR: 8305089: Implement missing socket options on AIX [v4]

2023-04-14 Thread Daniel Fuchs
On Fri, 14 Apr 2023 12:09:48 GMT, Varada M wrote: >> Hello Varada, so the Linux version uses `SO_PEERCRED` socket option and when >> it fails, the error message says "get SO_PEERCRED failed". The AIX version >> uses `SO_PEERID` and if it fails, the current proposed form in this PR will >> repo

Re: RFR: 8305089: Implement missing socket options on AIX [v4]

2023-04-14 Thread Varada M
On Fri, 14 Apr 2023 11:58:53 GMT, Jaikiran Pai wrote: >> On linux it is implemented from >> [attachListener_linux.cpp](https://github.com/openjdk/jdk/blob/master/src/hotspot/os/linux/attachListener_linux.cpp#L361) >> and on aix it is from >> [attachListener_aix.cpp](https://github.com/openjdk/

Re: RFR: 8305089: Implement missing socket options on AIX [v4]

2023-04-14 Thread Daniel Fuchs
On Fri, 14 Apr 2023 07:59:49 GMT, Varada M wrote: >> Breaking this into two parts : >> >> 1. Implementing socket options for AIX >> 2. DontFragmentTest failure >> >> - Implementing socket options for AIX : >> >> Unlike the linux, windows and macOS, AIX uses the default implementation for >

Re: RFR: 8305089: Implement missing socket options on AIX [v4]

2023-04-14 Thread Jaikiran Pai
On Fri, 14 Apr 2023 11:33:13 GMT, Varada M wrote: >> I'm curious, what is the rationale? >> By comparison the Linux version has: >> >> handleError(env, rv, "get SO_PEERCRED failed"); > > On linux it is implemented from > [attachListener_linux.cpp](https://github.com/openjdk/jdk/blob/ma

Re: RFR: 8305089: Implement missing socket options on AIX [v4]

2023-04-14 Thread Varada M
On Fri, 14 Apr 2023 11:27:33 GMT, Daniel Fuchs wrote: >> It is intended > > I'm curious, what is the rationale? > By comparison the Linux version has: > > handleError(env, rv, "get SO_PEERCRED failed"); On linux it is implemented from [attachListener_linux.cpp](https://github.com/open

Re: RFR: 8305089: Implement missing socket options on AIX [v4]

2023-04-14 Thread Daniel Fuchs
On Fri, 14 Apr 2023 10:52:45 GMT, Varada M wrote: >> src/jdk.net/aix/native/libextnet/AIXSocketOptions.c line 130: >> >>> 128: >>> 129: if ((rv=getsockopt(fd, SOL_SOCKET, SO_PEERID, &cred_info, &len)) < >>> 0) { >>> 130: handleError(env, rv, "get failed"); >> >> Is the double spa

Re: RFR: 8305089: Implement missing socket options on AIX [v4]

2023-04-14 Thread Varada M
On Fri, 14 Apr 2023 09:10:22 GMT, Daniel Fuchs wrote: >> Varada M has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains six commits: >> >> - Merge branch 'master' into aix_socket_options >> - Updated copyright year >> - Update to cop

Re: RFR: 8305089: Implement missing socket options on AIX [v4]

2023-04-14 Thread Daniel Fuchs
On Fri, 14 Apr 2023 07:59:49 GMT, Varada M wrote: >> Breaking this into two parts : >> >> 1. Implementing socket options for AIX >> 2. DontFragmentTest failure >> >> - Implementing socket options for AIX : >> >> Unlike the linux, windows and macOS, AIX uses the default implementation for >

Re: RFR: 8305089: Implement missing socket options on AIX [v4]

2023-04-14 Thread Jaikiran Pai
On Fri, 14 Apr 2023 07:59:49 GMT, Varada M wrote: >> Breaking this into two parts : >> >> 1. Implementing socket options for AIX >> 2. DontFragmentTest failure >> >> - Implementing socket options for AIX : >> >> Unlike the linux, windows and macOS, AIX uses the default implementation for >

Re: RFR: 8305089: Implement missing socket options on AIX [v4]

2023-04-14 Thread Daniel JeliƄski
On Fri, 14 Apr 2023 07:59:49 GMT, Varada M wrote: >> Breaking this into two parts : >> >> 1. Implementing socket options for AIX >> 2. DontFragmentTest failure >> >> - Implementing socket options for AIX : >> >> Unlike the linux, windows and macOS, AIX uses the default implementation for >

Re: RFR: 8305089: Implement missing socket options on AIX [v4]

2023-04-14 Thread Varada M
> Breaking this into two parts : > > 1. Implementing socket options for AIX > 2. DontFragmentTest failure > > - Implementing socket options for AIX : > > Unlike the linux, windows and macOS, AIX uses the default implementation for > socket options such as ipDontFragmentSupported(), > keepAl