Re: RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL [v2]

2023-05-10 Thread Chen Liang
On Mon, 8 May 2023 20:05:50 GMT, Chen Liang wrote: >> This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. >> The root cause might be that JMH requires passing VM args to benchmarks in >> quotes, which might have triggered incorrect detections in `FIXPATH` (as in >> comp

Re: RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL [v2]

2023-05-09 Thread Chen Liang
On Mon, 8 May 2023 20:05:50 GMT, Chen Liang wrote: >> This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. >> The root cause might be that JMH requires passing VM args to benchmarks in >> quotes, which might have triggered incorrect detections in `FIXPATH` (as in >> comp

Re: RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL [v2]

2023-05-09 Thread Roger Riggs
On Mon, 8 May 2023 20:05:50 GMT, Chen Liang wrote: >> This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. >> The root cause might be that JMH requires passing VM args to benchmarks in >> quotes, which might have triggered incorrect detections in `FIXPATH` (as in >> comp

Re: RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL [v2]

2023-05-09 Thread Erik Joelsson
On Mon, 8 May 2023 20:05:50 GMT, Chen Liang wrote: >> This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. >> The root cause might be that JMH requires passing VM args to benchmarks in >> quotes, which might have triggered incorrect detections in `FIXPATH` (as in >> comp

Re: RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL [v2]

2023-05-09 Thread Chen Liang
On Mon, 8 May 2023 20:05:50 GMT, Chen Liang wrote: >> This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. >> The root cause might be that JMH requires passing VM args to benchmarks in >> quotes, which might have triggered incorrect detections in `FIXPATH` (as in >> comp

Re: RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL [v2]

2023-05-08 Thread Erik Joelsson
On Mon, 8 May 2023 20:05:50 GMT, Chen Liang wrote: >> This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. >> The root cause might be that JMH requires passing VM args to benchmarks in >> quotes, which might have triggered incorrect detections in `FIXPATH` (as in >> comp

Re: RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL

2023-05-08 Thread Chen Liang
On Thu, 20 Apr 2023 02:32:37 GMT, Chen Liang wrote: > This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. > The root cause might be that JMH requires passing VM args to benchmarks in > quotes, which might have triggered incorrect detections in `FIXPATH` (as in > compari

Re: RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL [v2]

2023-05-08 Thread Chen Liang
> This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. > The root cause might be that JMH requires passing VM args to benchmarks in > quotes, which might have triggered incorrect detections in `FIXPATH` (as in > comparison, `$1_MICRO_JAVA_OPTIONS += > --add-opens=java.bas

Re: RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL

2023-04-21 Thread Jorn Vernee
On Thu, 20 Apr 2023 21:33:59 GMT, Chen Liang wrote: > Do you know if fixpath will take unix-style path with spaces as input? If it > should reject spaces, then we can run fixpath before quote and reject this > quoted argument with space, which is known to be absent in unix paths. I'm not sure.

Re: RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL

2023-04-20 Thread Chen Liang
On Thu, 20 Apr 2023 18:39:59 GMT, Jorn Vernee wrote: > Simpler reproducer: > > ``` > bash -x ./make/scripts/fixpath.sh print '-Djava.library.path=/mnt/h/xyz > --add-exports=java.base/jdk.internal.org.objectweb.asm=ALL-UNNAMED' > ``` > > Shows: > > ``` > + print_command_line '-Djava.library.pa

Re: RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL

2023-04-20 Thread Jorn Vernee
On Thu, 20 Apr 2023 02:32:37 GMT, Chen Liang wrote: > This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. > The root cause might be that JMH requires passing VM args to benchmarks in > quotes, which might have triggered incorrect detections in `FIXPATH` (as in > compari

Re: RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL

2023-04-20 Thread Jorn Vernee
On Thu, 20 Apr 2023 02:32:37 GMT, Chen Liang wrote: > This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. > The root cause might be that JMH requires passing VM args to benchmarks in > quotes, which might have triggered incorrect detections in `FIXPATH` (as in > compari

Re: RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL

2023-04-20 Thread Jorn Vernee
On Thu, 20 Apr 2023 02:32:37 GMT, Chen Liang wrote: > This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. > The root cause might be that JMH requires passing VM args to benchmarks in > quotes, which might have triggered incorrect detections in `FIXPATH` (as in > compari

Re: RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL

2023-04-20 Thread Chen Liang
On Thu, 20 Apr 2023 02:32:37 GMT, Chen Liang wrote: > This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. > The root cause might be that JMH requires passing VM args to benchmarks in > quotes, which might have triggered incorrect detections in `FIXPATH` (as in > compari

Re: RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL

2023-04-20 Thread Jorn Vernee
On Thu, 20 Apr 2023 02:32:37 GMT, Chen Liang wrote: > This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. > The root cause might be that JMH requires passing VM args to benchmarks in > quotes, which might have triggered incorrect detections in `FIXPATH` (as in > compari

RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL

2023-04-19 Thread Chen Liang
This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. The root cause might be that JMH requires passing VM args to benchmarks in quotes, which might have triggered incorrect detections in `FIXPATH` (as in comparison, `$1_MICRO_JAVA_OPTIONS += --add-opens=java.base/java.io=A