Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v3]

2023-11-22 Thread Joe Wang
On Wed, 22 Nov 2023 08:58:41 GMT, Alan Bateman wrote: > I'm happy with the addition of the JDK built-in catalog, the inclusion of the > DTD defined by Java SE, and the docs updates. Thanks again, Alan, I really appreciate it! Finally got all pieces together, a nice foundation for the next. --

Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v3]

2023-11-22 Thread Joe Wang
On Wed, 22 Nov 2023 08:08:39 GMT, Andrey Turbanov wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add a note; fix alignment > > test/jaxp/javax/xml/jaxp/unittest/common/catalog/CatalogTestBase.java line > 299: > >> 2

Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v3]

2023-11-22 Thread Alan Bateman
On Mon, 20 Nov 2023 17:46:53 GMT, Joe Wang wrote: >> Implement the built-in Catalog. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > add a note; fix alignment I'm happy with the addition of the JDK built-in catalog, the inclus

Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v3]

2023-11-22 Thread Andrey Turbanov
On Mon, 20 Nov 2023 17:46:53 GMT, Joe Wang wrote: >> Implement the built-in Catalog. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > add a note; fix alignment src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/

Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v3]

2023-11-20 Thread Lance Andersen
On Mon, 20 Nov 2023 17:46:53 GMT, Joe Wang wrote: >> Implement the built-in Catalog. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > add a note; fix alignment Thank you Joe. All good by me and Congrats on moving this across t

Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v3]

2023-11-20 Thread Joe Wang
> Implement the built-in Catalog. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: add a note; fix alignment - Changes: - all: https://git.openjdk.org/jdk/pull/16719/files - new: https://git.openjdk.org/jdk/pull/16719/fil