Re: RFR: 8307058: Implementation of Generational ZGC [v8]

2023-05-08 Thread Quan Anh Mai
On Mon, 8 May 2023 09:01:07 GMT, Erik Österlund wrote: >> I think we use the flag `UseStoreImmI16` for these kinds of situations. > > We did indeed run into the predecoder issue when we used testw for normal > store barriers, so I changed to testl. However, this cmpw is only taken when > we use

Re: RFR: 8307058: Implementation of Generational ZGC [v8]

2023-05-08 Thread Erik Österlund
On Sat, 6 May 2023 05:22:48 GMT, Quan Anh Mai wrote: >> Stefan Karlsson has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 917 commits: >> >> - ZGC: Generational >> >>Co-authored-by: Stefan Karlsson >>Co-authored-by: Pe

Re: RFR: 8307058: Implementation of Generational ZGC [v8]

2023-05-08 Thread Erik Österlund
On Sat, 6 May 2023 08:14:24 GMT, Quan Anh Mai wrote: >> src/hotspot/cpu/x86/gc/z/zBarrierSetAssembler_x86.cpp line 310: >> >>> 308: // A not relocatable object could have spurious raw null pointers >>> in its fields after >>> 309: // getting promoted to the old generation. >>> 310:

Re: RFR: 8307058: Implementation of Generational ZGC [v8]

2023-05-06 Thread Quan Anh Mai
On Sat, 6 May 2023 04:08:42 GMT, Quan Anh Mai wrote: >> Stefan Karlsson has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 917 commits: >> >> - ZGC: Generational >> >>Co-authored-by: Stefan Karlsson >>Co-authored-by: Pe

Re: RFR: 8307058: Implementation of Generational ZGC [v8]

2023-05-05 Thread Quan Anh Mai
On Fri, 5 May 2023 07:43:17 GMT, Stefan Karlsson wrote: >> Hi all, >> >> Please review the implementation of Generational ZGC, which can be turned on >> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational >> ZGC is a major rewrite of the non-generational ZGC version tha

Re: RFR: 8307058: Implementation of Generational ZGC [v8]

2023-05-05 Thread Stefan Karlsson
> Hi all, > > Please review the implementation of Generational ZGC, which can be turned on > by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational > ZGC is a major rewrite of the non-generational ZGC version that exists in the > openjdk/jdk repository. It splits the heap i