Re: RFR: 8308753: Class-File API transition to Preview [v2]

2023-10-02 Thread Vicente Romero
On Mon, 2 Oct 2023 07:18:19 GMT, Adam Sotona wrote: >> src/java.base/share/classes/java/lang/classfile/AnnotationElement.java line >> 34: >> >>> 32: import jdk.internal.javac.PreviewFeature; >>> 33: >>> 34: /** >> >> shouldn't we have the preview header applied to all these compilation units?

Re: RFR: 8308753: Class-File API transition to Preview [v2]

2023-10-02 Thread Adam Sotona
On Fri, 29 Sep 2023 23:00:44 GMT, Vicente Romero wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> PreviewFeature annotated with JEP 457 > > make/jdk/src/classes/build/tools/module/GenModuleInfoSource.java line 476: >

Re: RFR: 8308753: Class-File API transition to Preview [v2]

2023-09-29 Thread Vicente Romero
On Tue, 26 Sep 2023 12:32:37 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK

Re: RFR: 8308753: Class-File API transition to Preview [v2]

2023-09-29 Thread Vicente Romero
On Tue, 26 Sep 2023 12:32:37 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK

Re: RFR: 8308753: Class-File API transition to Preview [v2]

2023-09-28 Thread Jonathan Gibbons
On Tue, 26 Sep 2023 12:32:37 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK

Re: RFR: 8308753: Class-File API transition to Preview [v2]

2023-09-26 Thread Adam Sotona
On Tue, 26 Sep 2023 13:10:15 GMT, Chen Liang wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> PreviewFeature annotated with JEP 457 > > src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java line 82: > >

Re: RFR: 8308753: Class-File API transition to Preview [v2]

2023-09-26 Thread Chen Liang
On Tue, 26 Sep 2023 12:32:37 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK

Re: RFR: 8308753: Class-File API transition to Preview [v2]

2023-09-26 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe