Re: RFR: 8313274: Failure building java.base-jmod target

2023-08-02 Thread David Holmes
On Wed, 2 Aug 2023 06:54:36 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to fix > https://bugs.openjdk.org/browse/JDK-8313274? > > The commit in this PR reverts the commit that was introduced in > https://github.com/openjdk/jdk/pull/14561. Martin, in the

Re: RFR: 8313274: Failure building java.base-jmod target

2023-08-02 Thread Jaikiran Pai
On Wed, 2 Aug 2023 06:54:36 GMT, Jaikiran Pai wrote: > tier testing is currently in progress with this change. tier1, tier2 and tier3 tests have passed with this change. - PR Comment: https://git.openjdk.org/jdk/pull/15118#issuecomment-1661821594

RFR: 8313274: Failure building java.base-jmod target

2023-08-02 Thread Jaikiran Pai
Can I please get a review of this change which proposes to fix https://bugs.openjdk.org/browse/JDK-8313274? The commit in this PR reverts the commit that was introduced in https://github.com/openjdk/jdk/pull/14561. Martin, in the 8313274 JBS issue, notes that the failure started happening with

Re: RFR: 8313274: Failure building java.base-jmod target

2023-08-01 Thread Jaikiran Pai
On Wed, 2 Aug 2023 05:24:28 GMT, David Holmes wrote: > @jaikiran I would concur - back out the change that caused the problem. Hello David, I have now opened a PR to revert that change https://github.com/openjdk/jdk/pull/15118 - PR Comment: https://git.openjdk.org/jdk/pull/15102#i

Re: RFR: 8313274: Failure building java.base-jmod target

2023-08-01 Thread David Holmes
On Tue, 1 Aug 2023 10:31:13 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to address the build >> failure noted in https://bugs.openjdk.org/browse/JDK-8313274? >> >> The build failure is consistently reproducible with `--with-jobs=1`. Martin, >> in that JB

Re: RFR: 8313274: Failure building java.base-jmod target

2023-08-01 Thread phuchau1989
On Tue, 1 Aug 2023 09:01:49 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to address the build > failure noted in https://bugs.openjdk.org/browse/JDK-8313274? > > The build failure is consistently reproducible with `--with-jobs=1`. Martin, > in that JBS iss

Re: RFR: 8313274: Failure building java.base-jmod target

2023-08-01 Thread Jaikiran Pai
On Tue, 1 Aug 2023 10:30:18 GMT, Alan Bateman wrote: > It also opens the door to accidental mix 'n match of modules from different > JDK modules. So I don't think this the right change for this issue. - PR Comment: https://git.openjdk.org/jdk/pull/15102#issuecomment-1660035694

Re: RFR: 8313274: Failure building java.base-jmod target

2023-08-01 Thread Alan Bateman
On Tue, 1 Aug 2023 09:01:49 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to address the build > failure noted in https://bugs.openjdk.org/browse/JDK-8313274? > > The build failure is consistently reproducible with `--with-jobs=1`. Martin, > in that JBS iss

Re: RFR: 8313274: Failure building java.base-jmod target

2023-08-01 Thread Jaikiran Pai
On Tue, 1 Aug 2023 09:01:49 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to address the build > failure noted in https://bugs.openjdk.org/browse/JDK-8313274? > > The build failure is consistently reproducible with `--with-jobs=1`. Martin, > in that JBS iss

RFR: 8313274: Failure building java.base-jmod target

2023-08-01 Thread Jaikiran Pai
Can I please get a review of this change which proposes to address the build failure noted in https://bugs.openjdk.org/browse/JDK-8313274? The build failure is consistently reproducible with `--with-jobs=1`. Martin, in that JBS issue, has narrowed down the commit to the change in https://github