Re: RFR: 8317132: Prepare HotSpot for permissive- [v9]

2023-10-31 Thread Julian Waters
On Tue, 31 Oct 2023 07:32:35 GMT, Kim Barrett wrote: >> I know he was away until October but not exactly when in October. > > Ick! I hadn't followed https://github.com/openjdk/jdk/pull/15096 closely, so > hadn't noticed the discussion there. Not sure why this is using a literal 0 > rather than `

Re: RFR: 8317132: Prepare HotSpot for permissive- [v9]

2023-10-31 Thread Kim Barrett
On Tue, 3 Oct 2023 07:45:42 GMT, David Holmes wrote: >> Is Thomas around? Would like to get his opinion of what to do with this >> particular snippet > > I know he was away until October but not exactly when in October. Ick! I hadn't followed https://github.com/openjdk/jdk/pull/15096 closely, s

Re: RFR: 8317132: Prepare HotSpot for permissive- [v9]

2023-10-30 Thread Julian Waters
> Prepare HotSpot for the permissive- Visual C++ flag, this change contains all > of the fixes required for HotSpot to compile under the stricter mode > activated when the permissive- flag is passed > > - Reworks code in topLevelUnhandledExceptionFilter for os_windows.cpp to > avoid goto jumpin