Re: RFR: 8317763: Follow-up to AVX512 intrinsics for Arrays.sort() PR [v3]

2023-10-11 Thread Sandhya Viswanathan
On Wed, 11 Oct 2023 18:31:44 GMT, Sandhya Viswanathan wrote: >> Also @forceinline in these changes only works for case when new intrinsics >> are not used. >> I would suggest to adapt/update JMH benchmark to cover all cases and see >> effect @forceinline without intrinsics. >> That will tell u

Re: RFR: 8317763: Follow-up to AVX512 intrinsics for Arrays.sort() PR [v3]

2023-10-11 Thread Vladimir Kozlov
On Wed, 11 Oct 2023 19:06:24 GMT, Vladimir Kozlov wrote: >> @vnkozlov Please advice if we can integrate this PR or if you would like to >> run some tests first. > > Okay. I will start testing for current changes. @sviswa7 please file RFE for > Zen 4. If we get patch for it we do followup change

Re: RFR: 8317763: Follow-up to AVX512 intrinsics for Arrays.sort() PR [v3]

2023-10-11 Thread iaroslavski
On Wed, 11 Oct 2023 17:22:56 GMT, Srinivas Vamsi Parasa wrote: > > Also @forceinline in these changes only works for case when new intrinsics > > are not used. I would suggest to adapt/update JMH benchmark to cover all > > cases and see effect @forceinline without intrinsics. That will tell us

Re: RFR: 8317763: Follow-up to AVX512 intrinsics for Arrays.sort() PR [v3]

2023-10-11 Thread Vladimir Kozlov
On Wed, 11 Oct 2023 18:31:44 GMT, Sandhya Viswanathan wrote: >> Also @forceinline in these changes only works for case when new intrinsics >> are not used. >> I would suggest to adapt/update JMH benchmark to cover all cases and see >> effect @forceinline without intrinsics. >> That will tell u

Re: RFR: 8317763: Follow-up to AVX512 intrinsics for Arrays.sort() PR [v3]

2023-10-11 Thread Sandhya Viswanathan
On Tue, 10 Oct 2023 22:29:55 GMT, Vladimir Kozlov wrote: >> Srinivas Vamsi Parasa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix whitespace in build script > > Also @forceinline in these changes only works for case when new intrinsi

Re: RFR: 8317763: Follow-up to AVX512 intrinsics for Arrays.sort() PR [v3]

2023-10-11 Thread Srinivas Vamsi Parasa
On Wed, 11 Oct 2023 06:59:47 GMT, iaroslavski wrote: > Also @forceinline in these changes only works for case when new intrinsics > are not used. I would suggest to adapt/update JMH benchmark to cover all > cases and see effect @forceinline without intrinsics. That will tell us which > @forcei