Re: RFR: 8319268: Build failure with GCC8.3.1 after 8313643 [v2]

2023-11-02 Thread xpbob
On Fri, 3 Nov 2023 04:04:49 GMT, Zhao Song wrote: > > @zhaosongzs Thank you for your suggestions xpbob is my account name, and > > when I click on profile, the name is empty. I set it up and jcheck worked I > > have not set a profile since I applied for an account. > > OK, but if you never set

Re: RFR: 8319268: Build failure with GCC8.3.1 after 8313643 [v2]

2023-11-02 Thread Zhao Song
On Thu, 2 Nov 2023 16:09:28 GMT, Zhao Song wrote: >> @erikj79 >> Thanks for the review. >> The code has been updated > > Hi @xpbob, > The jcheck is continuously failing because your GitHub name is `null`. Please > set your name in your profile. > And out of curiosity, I want to know did you se

Re: RFR: 8319268: Build failure with GCC8.3.1 after 8313643 [v2]

2023-11-02 Thread xpbob
On Thu, 2 Nov 2023 16:09:28 GMT, Zhao Song wrote: >> @erikj79 >> Thanks for the review. >> The code has been updated > > Hi @xpbob, > The jcheck is continuously failing because your GitHub name is `null`. Please > set your name in your profile. > And out of curiosity, I want to know did you se

Re: RFR: 8319268: Build failure with GCC8.3.1 after 8313643 [v2]

2023-11-02 Thread Zhao Song
On Thu, 2 Nov 2023 13:58:01 GMT, null wrote: >> null has updated the pull request incrementally with one additional commit >> since the last revision: >> >> add comments > > @erikj79 > Thanks for the review. > The code has been updated Hi @xpbob, The jcheck is continuously failing because

Re: RFR: 8319268: Build failure with GCC8.3.1 after 8313643 [v2]

2023-11-02 Thread null
On Thu, 2 Nov 2023 07:14:14 GMT, null wrote: >> Build failure with GCC8.3.1 >> >> === Output from failing command(s) repeated here === >> * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o: >> /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc: >> I

Re: RFR: 8319268: Build failure with GCC8.3.1 after 8313643 [v2]

2023-11-02 Thread Erik Joelsson
On Thu, 2 Nov 2023 07:14:14 GMT, null wrote: >> Build failure with GCC8.3.1 >> >> === Output from failing command(s) repeated here === >> * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o: >> /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc: >> I

Re: RFR: 8319268: Build failure with GCC8.3.1 after 8313643 [v2]

2023-11-02 Thread null
> Build failure with GCC8.3.1 > > === Output from failing command(s) repeated here === > * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o: > /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc: > In function 'hb_bool_t hb_ot_layout_get_font_extents(h

Re: RFR: 8319268: Build failure with GCC8.3.1 after 8313643 [v2]

2023-11-02 Thread Jie Fu
On Thu, 2 Nov 2023 07:11:49 GMT, null wrote: >> Build failure with GCC8.3.1 >> >> === Output from failing command(s) repeated here === >> * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o: >> /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc: >> I