Re: RFR: 8320533: Adjust capstone integration for v6 changes [v3]

2023-11-29 Thread Erik Joelsson
On Mon, 27 Nov 2023 20:04:54 GMT, Erik Joelsson wrote: > > What's the issue with this? Full name on my profile "Galder Zamarreño". > > I've dug into this a bit and here is what I've found. The letter > [`ñ`](https://www.compart.com/en/unicode/U+00F1#:~:text=%E2%80%9C%C3%B1%E2%80%9D%20U%2B00F1%2

Re: RFR: 8320533: Adjust capstone integration for v6 changes [v3]

2023-11-27 Thread Galder Zamarreño
On Mon, 27 Nov 2023 20:04:54 GMT, Erik Joelsson wrote: >>> What's the issue with this? Full name on my profile "Galder Zamarreño". >> >> I don't know really. Could be a bug with the Skara bots that choke on the ñ >> (but I think we've had users with accented characters in their username >> be

Re: RFR: 8320533: Adjust capstone integration for v6 changes [v3]

2023-11-27 Thread Erik Joelsson
On Mon, 27 Nov 2023 14:50:30 GMT, Magnus Ihse Bursie wrote: > What's the issue with this? Full name on my profile "Galder Zamarreño". I've dug into this a bit and here is what I've found. The letter [`ñ`](https://www.compart.com/en/unicode/U+00F1#:~:text=%E2%80%9C%C3%B1%E2%80%9D%20U%2B00F1%20La

Re: RFR: 8320533: Adjust capstone integration for v6 changes [v3]

2023-11-27 Thread Magnus Ihse Bursie
On Mon, 27 Nov 2023 08:30:47 GMT, Galder Zamarreño wrote: > What's the issue with this? Full name on my profile "Galder Zamarreño". I don't know really. Could be a bug with the Skara bots that choke on the ñ (but I think we've had users with accented characters in their username before, so it

Re: RFR: 8320533: Adjust capstone integration for v6 changes [v5]

2023-11-27 Thread Andrew Haley
On Mon, 27 Nov 2023 07:38:28 GMT, Galder Zamarreño wrote: >> FYI @theRealAph >> >> It includes a couple of commits to integrate with Capstone v6 while still >> working with Capstone v5 and before: >> * `CAPSTONE_ARCH` for aarch64 is now `CS_ARCH_AARCH64` instead of >> `CS_ARCH_ARM64`. See [thi

Re: RFR: 8320533: Adjust capstone integration for v6 changes [v3]

2023-11-27 Thread Galder Zamarreño
On Mon, 27 Nov 2023 06:12:01 GMT, Galder Zamarreño wrote: >> Galder Zamarreño has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8320533: Comment undef call > > Hmmm, had to change the title. > ⚠️ @galderz the full name on your profile doe

Re: RFR: 8320533: Adjust capstone integration for v6 changes [v5]

2023-11-27 Thread Magnus Ihse Bursie
On Mon, 27 Nov 2023 07:38:28 GMT, Galder Zamarreño wrote: >> FYI @theRealAph >> >> It includes a couple of commits to integrate with Capstone v6 while still >> working with Capstone v5 and before: >> * `CAPSTONE_ARCH` for aarch64 is now `CS_ARCH_AARCH64` instead of >> `CS_ARCH_ARM64`. See [thi

Re: RFR: 8320533: Adjust capstone integration for v6 changes [v5]

2023-11-26 Thread Galder Zamarreño
> FYI @theRealAph > > It includes a couple of commits to integrate with Capstone v6 while still > working with Capstone v5 and before: > * `CAPSTONE_ARCH` for aarch64 is now `CS_ARCH_AARCH64` instead of > `CS_ARCH_ARM64`. See [this > document](https://github.com/Rot127/capstone/blob/v6-release-

Re: RFR: 8320533: Adjust capstone integration for v6 changes [v2]

2023-11-26 Thread Galder Zamarreño
On Sat, 25 Nov 2023 00:56:59 GMT, Jatin Bhateja wrote: >> Added a comment. > > Please also update the copyright year for this file. Updated - PR Review Comment: https://git.openjdk.org/jdk/pull/16788#discussion_r1405744455

Re: RFR: 8320533: Adjust capstone integration for v6 changes [v3]

2023-11-26 Thread Galder Zamarreño
On Thu, 23 Nov 2023 16:31:22 GMT, Galder Zamarreño wrote: >> FYI @theRealAph >> >> It includes a couple of commits to integrate with Capstone v6 while still >> working with Capstone v5 and before: >> * `CAPSTONE_ARCH` for aarch64 is now `CS_ARCH_AARCH64` instead of >> `CS_ARCH_ARM64`. See [thi

Re: RFR: 8320533: Adjust capstone integration for v6 changes [v4]

2023-11-26 Thread Galder Zamarreño
> FYI @theRealAph > > It includes a couple of commits to integrate with Capstone v6 while still > working with Capstone v5 and before: > * `CAPSTONE_ARCH` for aarch64 is now `CS_ARCH_AARCH64` instead of > `CS_ARCH_ARM64`. See [this > document](https://github.com/Rot127/capstone/blob/v6-release-

Re: RFR: 8320533: Adjust capstone integration for v6 changes [v2]

2023-11-24 Thread Jatin Bhateja
On Thu, 23 Nov 2023 16:28:15 GMT, Galder Zamarreño wrote: >> src/utils/hsdis/capstone/hsdis-capstone.c line 54: >> >>> 52: #include >>> 53: #include >>> 54: >> >> Need a comment about this `undef` > > Added a comment. Please also update the copyright year for this file. - PR R

Re: RFR: 8320533: Adjust capstone integration for v6 changes [v3]

2023-11-24 Thread Magnus Ihse Bursie
On Thu, 23 Nov 2023 16:31:22 GMT, Galder Zamarreño wrote: >> FYI @theRealAph >> >> It includes a couple of commits to integrate with Capstone v6 while still >> working with Capstone v5 and before: >> * `CAPSTONE_ARCH` for aarch64 is now `CS_ARCH_AARCH64` instead of >> `CS_ARCH_ARM64`. See [thi

Re: RFR: 8320533: Adjust capstone integration for v6 changes [v3]

2023-11-24 Thread Andrew Haley
On Thu, 23 Nov 2023 16:31:22 GMT, Galder Zamarreño wrote: >> FYI @theRealAph >> >> It includes a couple of commits to integrate with Capstone v6 while still >> working with Capstone v5 and before: >> * `CAPSTONE_ARCH` for aarch64 is now `CS_ARCH_AARCH64` instead of >> `CS_ARCH_ARM64`. See [thi

Re: RFR: 8320533: Adjust capstone integration for v6 changes [v3]

2023-11-24 Thread Andrew Haley
On Thu, 23 Nov 2023 16:31:22 GMT, Galder Zamarreño wrote: >> FYI @theRealAph >> >> It includes a couple of commits to integrate with Capstone v6 while still >> working with Capstone v5 and before: >> * `CAPSTONE_ARCH` for aarch64 is now `CS_ARCH_AARCH64` instead of >> `CS_ARCH_ARM64`. See [thi

Re: RFR: 8320533: Adjust capstone integration for v6 changes [v2]

2023-11-23 Thread Galder Zamarreño
On Thu, 23 Nov 2023 09:19:11 GMT, Andrew Haley wrote: >> Galder Zamarreño has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. The pull request >> contains two new

Re: RFR: 8320533: Adjust capstone integration for v6 changes [v3]

2023-11-23 Thread Galder Zamarreño
> FYI @theRealAph > > It includes a couple of commits to integrate with Capstone v6 while still > working with Capstone v5 and before: > * `CAPSTONE_ARCH` for aarch64 is now `CS_ARCH_AARCH64` instead of > `CS_ARCH_ARM64`. See [this > document](https://github.com/Rot127/capstone/blob/v6-release-

Re: RFR: 8320533: Adjust capstone integration for v6 changes [v2]

2023-11-23 Thread Magnus Ihse Bursie
On Thu, 23 Nov 2023 09:09:37 GMT, Galder Zamarreño wrote: >> FYI @theRealAph >> >> It includes a couple of commits to integrate with Capstone v6 while still >> working with Capstone v5 and before: >> * `CAPSTONE_ARCH` for aarch64 is now `CS_ARCH_AARCH64` instead of >> `CS_ARCH_ARM64`. See [thi

Re: RFR: 8320533: Adjust capstone integration for v6 changes [v2]

2023-11-23 Thread Andrew Haley
On Thu, 23 Nov 2023 09:09:37 GMT, Galder Zamarreño wrote: >> FYI @theRealAph >> >> It includes a couple of commits to integrate with Capstone v6 while still >> working with Capstone v5 and before: >> * `CAPSTONE_ARCH` for aarch64 is now `CS_ARCH_AARCH64` instead of >> `CS_ARCH_ARM64`. See [thi

Re: RFR: 8320533: Adjust capstone integration for v6 changes [v2]

2023-11-23 Thread Galder Zamarreño
> FYI @theRealAph > > It includes a couple of commits to integrate with Capstone v6 while still > working with Capstone v5 and before: > * `CAPSTONE_ARCH` for aarch64 is now `CS_ARCH_AARCH64` instead of > `CS_ARCH_ARM64`. See [this > document](https://github.com/Rot127/capstone/blob/v6-release-

RFR: 8320533: Adjust capstone integration for v6 changes

2023-11-22 Thread Galder Zamarreño
FYI @theRealAph It includes a couple of commits to integrate with Capstone v6 while still working with Capstone v5 and before: * `CAPSTONE_ARCH` for aarch64 is now `CS_ARCH_AARCH64` instead of `CS_ARCH_ARM64`. See [this document](https://github.com/Rot127/capstone/blob/v6-release-guide/docs/cs_