Re: RFR: 8324243: Fix GCC 14 build [v2]

2024-02-04 Thread Julian Waters
On Fri, 2 Feb 2024 09:26:28 GMT, Kim Barrett wrote: >> Sam James has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - fix whitespace >> - Revert "harfbuzz: Cherry-pick upstream fix for GCC 14" >> >>This reverts commit acdd606c5d8

Re: RFR: 8324243: Fix GCC 14 build [v2]

2024-02-04 Thread Julian Waters
On Fri, 2 Feb 2024 06:35:26 GMT, Sam James wrote: >> This fixes building with GCC 14: >> * ~Cherry-pick a fix from Harfbuzz upstream~ >> * Apply other `-Wcalloc-transposed-args` fixes to the JDK sources >> >> -Wcalloc-transposed-args errors out with GCC 14 as the OpenJDK build uses >> -Werror. >

Re: RFR: 8324243: Fix GCC 14 build [v2]

2024-02-02 Thread Kim Barrett
On Fri, 2 Feb 2024 06:35:26 GMT, Sam James wrote: >> This fixes building with GCC 14: >> * Cherry-pick a fix from Harfbuzz upstream >> * Apply other `-Wcalloc-transposed-args` fixes to the JDK sources >> >> -Wcalloc-transposed-args errors out with GCC 14 as the OpenJDK build uses >> -Werror. >>

Re: RFR: 8324243: Fix GCC 14 build [v2]

2024-02-01 Thread Magnus Ihse Bursie
On Fri, 2 Feb 2024 06:35:26 GMT, Sam James wrote: >> This fixes building with GCC 14: >> * Cherry-pick a fix from Harfbuzz upstream >> * Apply other `-Wcalloc-transposed-args` fixes to the JDK sources >> >> -Wcalloc-transposed-args errors out with GCC 14 as the OpenJDK build uses >> -Werror. >>