Re: RFR: 8325194: GHA: Add macOS M1 testing [v5]

2024-02-07 Thread Christoph Langer
On Wed, 7 Feb 2024 19:30:17 GMT, George Adams wrote: > > Opened [JDK-8325444](https://bugs.openjdk.org/browse/JDK-8325444) and > > trying a fix in https://github.com/RealCLanger/jdk/actions/runs/7820130826 > > I like your approach, it feels more robust Yeah, but didn't work. Here's a PR with s

Re: RFR: 8325194: GHA: Add macOS M1 testing [v5]

2024-02-07 Thread George Adams
On Wed, 7 Feb 2024 19:29:02 GMT, Christoph Langer wrote: > Opened [JDK-8325444](https://bugs.openjdk.org/browse/JDK-8325444) and trying > a fix in https://github.com/RealCLanger/jdk/actions/runs/7820130826 I like your approach, it feels more robust - PR Comment: https://git.openjd

Re: RFR: 8325194: GHA: Add macOS M1 testing [v5]

2024-02-07 Thread Christoph Langer
On Sat, 3 Feb 2024 21:55:25 GMT, George Adams wrote: >> Now that macOS M1 executors are [available in GitHub >> actions](https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/) >> it makes sense to move the build to run on M1 (rathe

Re: RFR: 8325194: GHA: Add macOS M1 testing [v5]

2024-02-07 Thread George Adams
On Wed, 7 Feb 2024 19:21:24 GMT, Christoph Langer wrote: >> Okay, this one regressed GHA for new PRs: >> https://github.com/stefank/jdk/actions/runs/7817217154/job/21324582843 >> >> >> Run # Build JTReg and move files to the proper locations >> realpath: bootjdk/jdk: No such file or directory

Re: RFR: 8325194: GHA: Add macOS M1 testing [v5]

2024-02-07 Thread Christoph Langer
On Wed, 7 Feb 2024 15:59:00 GMT, Aleksey Shipilev wrote: > Okay, this one regressed GHA for new PRs: > https://github.com/stefank/jdk/actions/runs/7817217154/job/21324582843 > > ``` > Run # Build JTReg and move files to the proper locations > realpath: bootjdk/jdk: No such file or directory > `

Re: RFR: 8325194: GHA: Add macOS M1 testing [v5]

2024-02-07 Thread Aleksey Shipilev
On Sat, 3 Feb 2024 21:55:25 GMT, George Adams wrote: >> Now that macOS M1 executors are [available in GitHub >> actions](https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/) >> it makes sense to move the build to run on M1 (rathe

Re: RFR: 8325194: GHA: Add macOS M1 testing [v3]

2024-02-06 Thread Magnus Ihse Bursie
On Sat, 3 Feb 2024 16:15:11 GMT, George Adams wrote: > Noting that macos-14 is arm64 only in GitHub so such a change might not be > useful in this scenario. That's a shame, really. It would be good if we switched x64 to macos-14 as soon as it is available, so we are on the same version. -

Re: RFR: 8325194: GHA: Add macOS M1 testing [v5]

2024-02-06 Thread Magnus Ihse Bursie
On Sat, 3 Feb 2024 21:55:25 GMT, George Adams wrote: >> Now that macOS M1 executors are [available in GitHub >> actions](https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/) >> it makes sense to move the build to run on M1 (rathe

Re: RFR: 8325194: GHA: Add macOS M1 testing [v5]

2024-02-04 Thread Christoph Langer
On Sat, 3 Feb 2024 21:55:25 GMT, George Adams wrote: >> Now that macOS M1 executors are [available in GitHub >> actions](https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/) >> it makes sense to move the build to run on M1 (rathe

Re: RFR: 8325194: GHA: Add macOS M1 testing [v4]

2024-02-04 Thread George Adams
On Sat, 3 Feb 2024 21:45:27 GMT, Aleksey Shipilev wrote: >> George Adams has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update copyright headers > > .github/actions/get-jtreg/action.yml line 66: > >> 64: fi >> 65: # Bui

Re: RFR: 8325194: GHA: Add macOS M1 testing [v4]

2024-02-03 Thread Aleksey Shipilev
On Sat, 3 Feb 2024 16:22:14 GMT, George Adams wrote: >> Now that macOS M1 executors are [available in GitHub >> actions](https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/) >> it makes sense to move the build to run on M1 (rathe

Re: RFR: 8325194: GHA: Add macOS M1 testing [v4]

2024-02-03 Thread George Adams
On Sat, 3 Feb 2024 21:45:27 GMT, Aleksey Shipilev wrote: >> George Adams has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update copyright headers > > .github/actions/get-jtreg/action.yml line 66: > >> 64: fi >> 65: # Bui

Re: RFR: 8325194: GHA: Add macOS M1 testing [v5]

2024-02-03 Thread George Adams
> Now that macOS M1 executors are [available in GitHub > actions](https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/) > it makes sense to move the build to run on M1 (rather than cross-compiled) > and also enable testing on the p

Re: RFR: 8325194: GHA: Add macOS M1 testing [v4]

2024-02-03 Thread George Adams
> Now that macOS M1 executors are [available in GitHub > actions](https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/) > it makes sense to move the build to run on M1 (rather than cross-compiled) > and also enable testing on the p

Re: RFR: 8325194: GHA: Add macOS M1 testing [v3]

2024-02-03 Thread George Adams
On Sat, 3 Feb 2024 14:09:50 GMT, Christoph Langer wrote: > Do we maybe want to go to 'macos-14' on both MacOS architectures? Maybe do it > in a prior, separate change? Noting that macos-14 is arm64 only in GitHub so such a change might not be intentional in this scenario. > Other than that I

Re: RFR: 8325194: GHA: Add macOS M1 testing [v3]

2024-02-03 Thread Christoph Langer
On Sat, 3 Feb 2024 11:49:24 GMT, George Adams wrote: >> Now that macOS M1 executors are [available in GitHub >> actions](https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/) >> it makes sense to move the build to run on M1 (rathe

Re: RFR: 8325194: GHA: Add macOS M1 testing [v3]

2024-02-03 Thread George Adams
> Now that macOS M1 executors are [available in GitHub > actions](https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/) > it makes sense to move the build to run on M1 (rather than cross-compiled) > and also enable testing on the p

Re: RFR: 8325194: GHA: Add macOS M1 testing [v2]

2024-02-03 Thread George Adams
> Now that macOS M1 executors are [available in GitHub > actions](https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/) > it makes sense to move the build to run on M1 (rather than cross-compiled) > and also enable testing on the p

RFR: 8325194: GHA: Add macOS M1 testing

2024-02-03 Thread George Adams
Now that macOS M1 executors are [available in GitHub actions](https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/) it makes sense to move the build to run on M1 (rather than cross-compiled) and also enable testing on the platform.