Re: RFR: 8329086: Clean up java.desktop native compilation [v3]

2024-03-27 Thread Erik Joelsson
On Wed, 27 Mar 2024 10:39:35 GMT, Magnus Ihse Bursie wrote: >> This is a follow-up on >> [JDK-8328680](https://bugs.openjdk.org/browse/JDK-8328680), making the same >> kind of cleanup to java.desktop. Some code needed more special treatment >> here, so there is some additional effects outside

Re: RFR: 8329086: Clean up java.desktop native compilation [v3]

2024-03-27 Thread Magnus Ihse Bursie
On Wed, 27 Mar 2024 10:39:35 GMT, Magnus Ihse Bursie wrote: >> This is a follow-up on >> [JDK-8328680](https://bugs.openjdk.org/browse/JDK-8328680), making the same >> kind of cleanup to java.desktop. Some code needed more special treatment >> here, so there is some additional effects outside

Re: RFR: 8329086: Clean up java.desktop native compilation [v3]

2024-03-27 Thread Magnus Ihse Bursie
On Tue, 26 Mar 2024 23:38:07 GMT, Magnus Ihse Bursie wrote: >> The code, prior to this PR, includes these lines: >> >> # The fast floor code loses precision. >> LCMS_CFLAGS=-DCMS_DONT_USE_FAST_FLOOR -DCMS_NO_HALF_SUPPORT >> >> >> This will overwrite the value of `LCMS_CFLAGS` as given in `spec

Re: RFR: 8329086: Clean up java.desktop native compilation [v3]

2024-03-27 Thread Magnus Ihse Bursie
> This is a follow-up on > [JDK-8328680](https://bugs.openjdk.org/browse/JDK-8328680), making the same > kind of cleanup to java.desktop. Some code needed more special treatment > here, so there is some additional effects outside of the modules/java.desktop > directory. The code was also in wor

Re: RFR: 8329086: Clean up java.desktop native compilation [v2]

2024-03-27 Thread Magnus Ihse Bursie
> This is a follow-up on > [JDK-8328680](https://bugs.openjdk.org/browse/JDK-8328680), making the same > kind of cleanup to java.desktop. Some code needed more special treatment > here, so there is some additional effects outside of the modules/java.desktop > directory. The code was also in wor

Re: RFR: 8329086: Clean up java.desktop native compilation

2024-03-26 Thread Magnus Ihse Bursie
On Tue, 26 Mar 2024 23:10:44 GMT, Magnus Ihse Bursie wrote: >> This took me a while to decode. The old code will unconditionally override >> `LCMS_CFLAGS` which means whatever value it gets in configure is >> overwritten. That certainly seems like a bug. >> >> Your current patch clears the var

Re: RFR: 8329086: Clean up java.desktop native compilation

2024-03-26 Thread Magnus Ihse Bursie
On Tue, 26 Mar 2024 22:01:33 GMT, Erik Joelsson wrote: >> This is a follow-up on >> [JDK-8328680](https://bugs.openjdk.org/browse/JDK-8328680), making the same >> kind of cleanup to java.desktop. Some code needed more special treatment >> here, so there is some additional effects outside of th

Re: RFR: 8329086: Clean up java.desktop native compilation

2024-03-26 Thread Magnus Ihse Bursie
On Tue, 26 Mar 2024 19:36:04 GMT, Phil Race wrote: >> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 280: >> >>> 278: # as includes, instead the system headers should be used. >>> 279: LIBLCMS_HEADERS_FROM_SRC := false >>> 280: # FIXME: Keep old behavior and reset LCMS_CFLAGS. This

Re: RFR: 8329086: Clean up java.desktop native compilation

2024-03-26 Thread Erik Joelsson
On Tue, 26 Mar 2024 19:19:14 GMT, Phil Race wrote: >> This is a follow-up on >> [JDK-8328680](https://bugs.openjdk.org/browse/JDK-8328680), making the same >> kind of cleanup to java.desktop. Some code needed more special treatment >> here, so there is some additional effects outside of the >

Re: RFR: 8329086: Clean up java.desktop native compilation

2024-03-26 Thread Erik Joelsson
On Tue, 26 Mar 2024 12:51:38 GMT, Magnus Ihse Bursie wrote: > This is a follow-up on > [JDK-8328680](https://bugs.openjdk.org/browse/JDK-8328680), making the same > kind of cleanup to java.desktop. Some code needed more special treatment > here, so there is some additional effects outside of t

Re: RFR: 8329086: Clean up java.desktop native compilation

2024-03-26 Thread Erik Joelsson
On Tue, 26 Mar 2024 19:36:04 GMT, Phil Race wrote: >> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 280: >> >>> 278: # as includes, instead the system headers should be used. >>> 279: LIBLCMS_HEADERS_FROM_SRC := false >>> 280: # FIXME: Keep old behavior and reset LCMS_CFLAGS. This

Re: RFR: 8329086: Clean up java.desktop native compilation

2024-03-26 Thread Magnus Ihse Bursie
On Tue, 26 Mar 2024 19:46:00 GMT, Phil Race wrote: >> This is a follow-up on >> [JDK-8328680](https://bugs.openjdk.org/browse/JDK-8328680), making the same >> kind of cleanup to java.desktop. Some code needed more special treatment >> here, so there is some additional effects outside of the >

Re: RFR: 8329086: Clean up java.desktop native compilation

2024-03-26 Thread Magnus Ihse Bursie
On Tue, 26 Mar 2024 23:01:55 GMT, Magnus Ihse Bursie wrote: >> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 145: >> >>> 143: -delayload:gdi32.dll -delayload:imm32.dll -delayload:ole32.dll >>> \ >>> 144: -delayload:shell32.dll -delayload:shlwapi.dll >>> -delayload:user3

Re: RFR: 8329086: Clean up java.desktop native compilation

2024-03-26 Thread Magnus Ihse Bursie
On Tue, 26 Mar 2024 19:25:47 GMT, Phil Race wrote: >> This is a follow-up on >> [JDK-8328680](https://bugs.openjdk.org/browse/JDK-8328680), making the same >> kind of cleanup to java.desktop. Some code needed more special treatment >> here, so there is some additional effects outside of the >

Re: RFR: 8329086: Clean up java.desktop native compilation

2024-03-26 Thread Magnus Ihse Bursie
On Tue, 26 Mar 2024 19:19:14 GMT, Phil Race wrote: >> This is a follow-up on >> [JDK-8328680](https://bugs.openjdk.org/browse/JDK-8328680), making the same >> kind of cleanup to java.desktop. Some code needed more special treatment >> here, so there is some additional effects outside of the >

Re: RFR: 8329086: Clean up java.desktop native compilation

2024-03-26 Thread Phil Race
On Tue, 26 Mar 2024 13:00:41 GMT, Magnus Ihse Bursie wrote: >> This is a follow-up on >> [JDK-8328680](https://bugs.openjdk.org/browse/JDK-8328680), making the same >> kind of cleanup to java.desktop. Some code needed more special treatment >> here, so there is some additional effects outside

Re: RFR: 8329086: Clean up java.desktop native compilation

2024-03-26 Thread Phil Race
On Tue, 26 Mar 2024 12:51:38 GMT, Magnus Ihse Bursie wrote: > This is a follow-up on > [JDK-8328680](https://bugs.openjdk.org/browse/JDK-8328680), making the same > kind of cleanup to java.desktop. Some code needed more special treatment > here, so there is some additional effects outside of t

Re: RFR: 8329086: Clean up java.desktop native compilation

2024-03-26 Thread Magnus Ihse Bursie
On Tue, 26 Mar 2024 12:51:38 GMT, Magnus Ihse Bursie wrote: > This is a follow-up on > [JDK-8328680](https://bugs.openjdk.org/browse/JDK-8328680), making the same > kind of cleanup to java.desktop. Some code needed more special treatment > here, so there is some additional effects outside of t

RFR: 8329086: Clean up java.desktop native compilation

2024-03-26 Thread Magnus Ihse Bursie
This is a follow-up on [JDK-8328680](https://bugs.openjdk.org/browse/JDK-8328680), making the same kind of cleanup to java.desktop. Some code needed more special treatment here, so there is some additional effects outside of the modules/java.desktop directory. The code was also in worse shape t

Re: RFR: 8329086: Clean up java.desktop native compilation

2024-03-26 Thread Magnus Ihse Bursie
On Tue, 26 Mar 2024 12:51:38 GMT, Magnus Ihse Bursie wrote: > This is a follow-up on > [JDK-8328680](https://bugs.openjdk.org/browse/JDK-8328680), making the same > kind of cleanup to java.desktop. Some code needed more special treatment > here, so there is some additional effects outside of t