Re: RFR: JDK-8300592: ASan build does not correctly propagate options to some test launchers [v2]

2023-01-25 Thread Justin King
On Wed, 25 Jan 2023 15:28:14 GMT, Magnus Ihse Bursie wrote: >> Justin King has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Remove extra whitespace >> >>Signed-off-by: Justin King >> - Always link ASan default options to any t

Re: RFR: JDK-8300592: ASan build does not correctly propagate options to some test launchers [v3]

2023-01-25 Thread Justin King
> Update some custom launchers to set the default ASan options, without it the > tests fail due to incompatibility with LSan. Additionally adds `-fno-common` > for ASan build, as suggested by the docs. Justin King has updated the pull request incrementally with one additional commit since the l

Re: RFR: JDK-8300592: ASan build does not correctly propagate options to some test launchers [v2]

2023-01-25 Thread Magnus Ihse Bursie
On Mon, 23 Jan 2023 19:39:44 GMT, Justin King wrote: >> Update some custom launchers to set the default ASan options, without it the >> tests fail due to incompatibility with LSan. Additionally adds `-fno-common` >> for ASan build, as suggested by the docs. > > Justin King has updated the pull

Re: RFR: JDK-8300592: ASan build does not correctly propagate options to some test launchers [v2]

2023-01-23 Thread Justin King
> Update some custom launchers to set the default ASan options, without it the > tests fail due to incompatibility with LSan. Additionally adds `-fno-common` > for ASan build, as suggested by the docs. Justin King has updated the pull request incrementally with two additional commits since the

Re: RFR: JDK-8300592: ASan build does not correctly propagate options to some test launchers

2023-01-23 Thread Justin King
On Wed, 18 Jan 2023 20:40:40 GMT, Justin King wrote: > Update some custom launchers to set the default ASan options, without it the > tests fail due to incompatibility with LSan. Additionally adds `-fno-common` > for ASan build, as suggested by the docs. > I think this should be added to _all_

Re: RFR: JDK-8300592: ASan build does not correctly propagate options to some test launchers

2023-01-23 Thread Magnus Ihse Bursie
On Wed, 18 Jan 2023 20:40:40 GMT, Justin King wrote: > Update some custom launchers to set the default ASan options, without it the > tests fail due to incompatibility with LSan. Additionally adds `-fno-common` > for ASan build, as suggested by the docs. I think this should be added to *all* t

Re: RFR: JDK-8300592: ASan build does not correctly propagate options to some test launchers

2023-01-19 Thread Justin King
On Wed, 18 Jan 2023 20:40:40 GMT, Justin King wrote: > Update some custom launchers to set the default ASan options, without it the > tests fail due to incompatibility with LSan. Additionally adds `-fno-common` > for ASan build, as suggested by the docs. @magicus Yet more build fixes for ASan.

RFR: JDK-8300592: ASan build does not correctly propagate options to some test launchers

2023-01-18 Thread Justin King
Update some custom launchers to set the default ASan options, without it the tests fail due to incompatibility with LSan. Additionally adds `-fno-common` for ASan build, as suggested by the docs. - Commit messages: - Fix ASan build for custom test launchers Changes: https://git.op