On Thu, 18 Jan 2024 16:21:46 GMT, Julian Waters wrote:
>> [JDK-8323008](https://bugs.openjdk.org/browse/JDK-8323008) reports unwanted
>> autoconf flags being added to the command line, and solves the issue by
>> filtering out the added flags by force. This is not optimal however, as
>> doing s
On Mon, 12 Feb 2024 14:09:49 GMT, Julian Waters wrote:
>> I have verified that this works fine in the Oracle internal CI.
>>
>> Erik's point still stands:
>>> I still think it would be prudent to verify this patch with all the
>>> currently accepted versions of autoconf (2.69, 2.70, 2.71, 2.72)
On Mon, 12 Feb 2024 14:09:49 GMT, Julian Waters wrote:
> That said, should I test autoconf on all platforms too?
No, that seems over the top. For this purpose, we must assume that all autoconf
on all platforms behave the same.
-
PR Comment: https://git.openjdk.org/jdk/pull/17401#i
On Mon, 12 Feb 2024 13:57:55 GMT, Magnus Ihse Bursie wrote:
> I have verified that this works fine in the Oracle internal CI.
>
> Erik's point still stands:
>
> > I still think it would be prudent to verify this patch with all the
> > currently accepted versions of autoconf (2.69, 2.70, 2.71,
On Thu, 18 Jan 2024 16:21:46 GMT, Julian Waters wrote:
>> [JDK-8323008](https://bugs.openjdk.org/browse/JDK-8323008) reports unwanted
>> autoconf flags being added to the command line, and solves the issue by
>> filtering out the added flags by force. This is not optimal however, as
>> doing s
On Thu, 18 Jan 2024 16:21:46 GMT, Julian Waters wrote:
>> [JDK-8323008](https://bugs.openjdk.org/browse/JDK-8323008) reports unwanted
>> autoconf flags being added to the command line, and solves the issue by
>> filtering out the added flags by force. This is not optimal however, as
>> doing s
On Thu, 18 Jan 2024 16:21:46 GMT, Julian Waters wrote:
>> [JDK-8323008](https://bugs.openjdk.org/browse/JDK-8323008) reports unwanted
>> autoconf flags being added to the command line, and solves the issue by
>> filtering out the added flags by force. This is not optimal however, as
>> doing s
On Fri, 19 Jan 2024 21:17:20 GMT, Erik Joelsson wrote:
> I would just like to point out that it was a change in autoconf behavior
> that triggered this whole ordeal in the first place
I'm not entirely sure that is the case. It might as well have been a latent bug
that was triggered by changes
On Fri, 19 Jan 2024 14:21:28 GMT, Julian Waters wrote:
> Haha, thanks both. Though one thing has been annoying me ever since I wrote
> this, it's the fact that no "AC_UNDEF" exists to erase macros defined by
> AC_DEFUN. Overwriting macros like this, especially macros that are part of
> the "au
On Fri, 19 Jan 2024 14:14:46 GMT, Magnus Ihse Bursie wrote:
> In contrast with Erik I'm not so worried about future breakage. Autoconf has
> basically stalled in development since decades. If someone were to pick up
> development again (like what happened with GNU Make) we will surely see signs
On Thu, 18 Jan 2024 16:21:46 GMT, Julian Waters wrote:
>> [JDK-8323008](https://bugs.openjdk.org/browse/JDK-8323008) reports unwanted
>> autoconf flags being added to the command line, and solves the issue by
>> filtering out the added flags by force. This is not optimal however, as
>> doing s
On Thu, 18 Jan 2024 16:21:46 GMT, Julian Waters wrote:
>> [JDK-8323008](https://bugs.openjdk.org/browse/JDK-8323008) reports unwanted
>> autoconf flags being added to the command line, and solves the issue by
>> filtering out the added flags by force. This is not optimal however, as
>> doing s
On Fri, 19 Jan 2024 01:22:27 GMT, Julian Waters wrote:
> I found out that the issue of having AC_PROG_CC and AC_PROG_CXX being called
> by AC_REQUIRE can be solved by directly overwriting them in util.m4, rather
> than providing our own UTIL_PROG_CC and so on. Unsure how satisfactory this
> is
On Thu, 18 Jan 2024 16:21:46 GMT, Julian Waters wrote:
>> [JDK-8323008](https://bugs.openjdk.org/browse/JDK-8323008) reports unwanted
>> autoconf flags being added to the command line, and solves the issue by
>> filtering out the added flags by force. This is not optimal however, as
>> doing s
> [JDK-8323008](https://bugs.openjdk.org/browse/JDK-8323008) reports unwanted
> autoconf flags being added to the command line, and solves the issue by
> filtering out the added flags by force. This is not optimal however, as doing
> so leaves the autoconf message that the flags were added still
15 matches
Mail list logo