Re: [PATCH 1/4] rbd: allocate image requests with a slab allocator

2013-05-02 Thread Alex Elder
On 05/02/2013 11:19 AM, Josh Durgin wrote: > It looks like the GFP flags used throughout request creation > could be cleanup up (there's a mix of ATOMIC, KERNEL, and NOIO). > I just noticed since this changes a GFP_ATOMIC to GFP_KERNEL. > Making them consistent can be a later patch though. Well th

Re: [PATCH 1/4] rbd: allocate image requests with a slab allocator

2013-05-02 Thread Josh Durgin
It looks like the GFP flags used throughout request creation could be cleanup up (there's a mix of ATOMIC, KERNEL, and NOIO). I just noticed since this changes a GFP_ATOMIC to GFP_KERNEL. Making them consistent can be a later patch though. Reviewed-by: Josh Durgin On 05/01/2013 02:35 PM, Alex E

[PATCH 1/4] rbd: allocate image requests with a slab allocator

2013-05-01 Thread Alex Elder
Create a slab cache to manage rbd_img_request allocation. Nothing too fancy at this point--we'll still initialize everything at allocation time (no constructor) This is part of: http://tracker.ceph.com/issues/3926 Signed-off-by: Alex Elder --- drivers/block/rbd.c | 39 +++